From above email link, https://cs.chromium.org/chromium/src/remoting/signaling/jid_util.cc?q=tolower+file:%5Esrc/remoting/+package:%5Echromium$&dr=C&l=17
actual code is ________________
std::string NormalizeJid(const std::string& jid) {
std::string bare_jid;
std::string resource;
if (SplitJidResource(jid, &bare_jid, &resource)) {
return base::ToLowerASCII(bare_jid) + "/" + resource;
}
return base::ToLowerASCII(bare_jid);
}
----------------------------- after removing base::ToLowerASCII() this method from above code. This bug is resolved. -------------------------
Is there any other consequences if we don't make bare_jid to lowerCase ? I don't see any.
std::string NormalizeJid(const std::string& jid) {
std::string bare_jid;
std::string resource;
if (SplitJidResource(jid, &bare_jid, &resource)) {
return (bare_jid) + "/" + resource;
}
return (bare_jid);
}
It looks like that code was added in https://codereview.chromium.org/1131653002 to fix bug 485134 , which is basically the same as this one. I don't think removing it is the right thing to do; maybe whatever comparison this method is being applied to just needs it to be applied to both components.
Was the error message "The access code is invalid. Please try again."? If so, it looks like this is reproducible when sharing from a mixed case email address.
Looks like https://codereview.chromium.org/2577333003 fixed a related problem for mixed case scenario, but now authentication fails with that change on the client side.
- In sharing options (Remoting Assitance.exe ), This upper-lower case email id does not work But why does it work with remoting_host.exe(enabling chrome remote desktop ). why do these two thing behaves differently ?
Is my assumption of having same code(dll) for both sharing(remoting_assitance.exe ) and remote access(remoting_host.exe), Correct ?
Comment 1 by jamiewa...@chromium.org
, Apr 3 2017