New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707823 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 688263



Sign in to add a comment

Update webview_public_framework_jar to N-MR1

Project Member Reported by mikec...@chromium.org, Apr 3 2017

Issue description

We need to update the webview_public_framework_jar to N-MR1 now that upstream sdk (third_party/android_tools/sdk) has been rolled to N-MR1.

Having an older version of this jar causes issues when trying to use new N-MR1 apis (monochrome won't compile).

Need to update this:
https://cs.chromium.org/chromium/src/build/config/android/config.gni?type=cs&sq=package:chromium&l=90



Can we just update this jar, or are there more steps required? Last time it was updated it was done as part of a much larger CL...
https://codereview.chromium.org/2298093008


Also, does anyone know where I should grab this jar from?

 
Cc: mikec...@chromium.org

Comment 2 by boliu@chromium.org, Apr 3 2017

Pinged instructions on chat, but it's basically:
* checkout appropriate aosp branch
* choose the generic eng build
* make android_system_stubs
* copy out  out/target/common/obj/JAVA_LIBRARIES/android_system_stubs_current_intermediates/classes.jar to prebuilts/sdk/system_current/android.jar to chromium, and give it an appropriate name
Owner: mikec...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2b501b65e0987b4f2a23561a4906eb02f955a40

commit a2b501b65e0987b4f2a23561a4906eb02f955a40
Author: Mike Case <mikecase@google.com>
Date: Tue Apr 04 01:39:51 2017

Update webview_public_framework_jar to N-MR1.

Adding frameworks jar build from the android-7.1.1_r28 tag
in AOSP.

Bug:707823

Change-Id: Ifbe2c91aa1b495b0959b5de026bc9fd690474b12
Reviewed-on: https://chromium-review.googlesource.com/466631
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Commit-Position: refs/heads/master@{#461605}
[modify] https://crrev.com/a2b501b65e0987b4f2a23561a4906eb02f955a40/build/config/android/config.gni
[add] https://crrev.com/a2b501b65e0987b4f2a23561a4906eb02f955a40/third_party/android_platform/webview/frameworks_7.1.1_r28.jar

Status: Fixed (was: Started)

Sign in to add a comment