New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707817 link

Starred by 1 user
Status: Archived
Owner:
jam@chromium.org
Closed: Apr 2017
Cc:
xiy...@chromium.org
alemate@chromium.org
dcheng@chromium.org
█ nasko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Dialog is not closable clicking on [x] button

Project Member Reported by warx@chromium.org, Apr 3 2017 
ToT chrome

Eula screen, Click 'Chrome open source licenses' link to open a dialog, then click the [x] button using the mouse, dialog cannot be closed.

This worked two weeks ago. A recent CL must break this.
Screenshot from 2017-04-03 09:49:46.png
63.8 KB View Download

Comment 1 by warx@chromium.org, Apr 3 2017

Cc: dcheng@chromium.org nasko@chromium.org
Owner: jam@chromium.org
Status: Assigned (was: Untriaged)
The line to blame is: https://cs.chromium.org/chromium/src/ui/views/controls/webview/web_dialog_view.cc?q=web_dialog_view+package:%5Echromium$&l=114, which is introduced in crrev.com/2783723002.

Pass it to CL owner, and add reviewers.

Comment 2 by warx@chromium.org, Apr 3 2017

Labels: -Pri-3 M-59 Pri-2
Summary: Dialog is not closable clicking on [x] button (was: Dialog is not closable clicking on [x] button on oobe)
Note: it not only affects the dialogs on oobe, but also in session dialogs like captive portal login dialog.

Comment 3 by warx@chromium.org, Apr 13 2017

Status: Fixed (was: Assigned)
This sounds like fixed because of the revert? 

https://codereview.chromium.org/2812743002

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment