Relevant spec: https://html.spec.whatwg.org/#imagebitmapsource Since we don't do cascading typedefs, this needs to be added after 695662 was done.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/060c140872ae52c49ba012edc39a39b0a09040cf commit 060c140872ae52c49ba012edc39a39b0a09040cf Author: fserb <fserb@chromium.org> Date: Thu Apr 13 19:01:48 2017 Adds SVGImageElement as a ImageBitmapSource BUG= 707815 Review-Url: https://codereview.chromium.org/2802813002 Cr-Commit-Position: refs/heads/master@{#464487} [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt [add] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image-expected.html [add] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/frame/ImageBitmap.cpp [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/frame/ImageBitmap.h [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/html/BUILD.gn [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/html/HTMLImageElement.cpp [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/html/HTMLImageElement.h [rename] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/html/canvas/ImageElementBase.cpp [rename] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/html/canvas/ImageElementBase.h [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/svg/SVGImageElement.cpp [modify] https://crrev.com/060c140872ae52c49ba012edc39a39b0a09040cf/third_party/WebKit/Source/core/svg/SVGImageElement.h
\o/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b8f933cd4669908b9989308505fdab3eadfff3a commit 2b8f933cd4669908b9989308505fdab3eadfff3a Author: brucedawson <brucedawson@chromium.org> Date: Thu Apr 13 21:57:10 2017 Revert of Adds SVGImageElement as a ImageBitmapSource (patchset #8 id:140001 of https://codereview.chromium.org/2802813002/ ) Reason for revert: On 2017/04/13 19:02:48, commit-bot: I haz the power wrote: > Committed patchset #8 (id:140001) as > https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf This is breaking some builds due to path name limits. This .rsp path is 193 characters long: obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl/HTMLImageElementOrSVGImageElementOrHTMLVideoElementOrHTMLCanvasElementOrBlobOrImageDataOrImageBitmapOrOffscreenCanvas.obj.rsp This is 73 characters: C:\b\build\slave\chromium-win-x64-pgo-builder\build\src\out\Release_x64 So that's 267. MAX_PATH in Windows is 260 (https://msdn.microsoft.com/en-us/library/cc249520.aspx). I'm not sure why all the files are being glommed together to create the mega-path so I'm not sure what the alternative is. Presumably changing the path generation function. Original issue's description: > Adds SVGImageElement as a ImageBitmapSource > > BUG= 707815 > > Review-Url: https://codereview.chromium.org/2802813002 > Cr-Commit-Position: refs/heads/master@{#464487} > Committed: https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf TBR=esprehn@chromium.org,chrishtr@chromium.org,fs@opera.com,junov@chromium.org,fserb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 707815 Review-Url: https://codereview.chromium.org/2817093002 Cr-Commit-Position: refs/heads/master@{#464562} [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt [delete] https://crrev.com/da26a507e1367331f15769f75797fd70032a08b8/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image-expected.html [delete] https://crrev.com/da26a507e1367331f15769f75797fd70032a08b8/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/frame/ImageBitmap.h [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/html/BUILD.gn [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/html/HTMLImageElement.cpp [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/html/HTMLImageElement.h [rename] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/html/canvas/CanvasImageElementSource.cpp [rename] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/html/canvas/CanvasImageElementSource.h [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/svg/SVGImageElement.cpp [modify] https://crrev.com/2b8f933cd4669908b9989308505fdab3eadfff3a/third_party/WebKit/Source/core/svg/SVGImageElement.h
Reopening this due to name hell.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc40833a6cfeded6637f7570ff51be6933e44dd commit dfc40833a6cfeded6637f7570ff51be6933e44dd Author: fserb <fserb@chromium.org> Date: Thu Apr 20 03:17:22 2017 Adds SVGImageElement as a ImageBitmapSource BUG= 707815 Review-Url: https://codereview.chromium.org/2802813002 Cr-Original-Commit-Position: refs/heads/master@{#464487} Committed: https://chromium.googlesource.com/chromium/src/+/060c140872ae52c49ba012edc39a39b0a09040cf Review-Url: https://codereview.chromium.org/2802813002 Cr-Commit-Position: refs/heads/master@{#465882} [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt [add] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image-expected.html [add] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-image.html [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/bindings/scripts/utilities.py [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/frame/ImageBitmap.cpp [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/frame/ImageBitmap.h [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/html/BUILD.gn [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/html/HTMLImageElement.cpp [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/html/HTMLImageElement.h [rename] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/html/canvas/ImageElementBase.cpp [rename] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/html/canvas/ImageElementBase.h [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/svg/SVGImageElement.cpp [modify] https://crrev.com/dfc40833a6cfeded6637f7570ff51be6933e44dd/third_party/WebKit/Source/core/svg/SVGImageElement.h
crisis averted. Donerino.
Comment 1 by fs...@chromium.org
, Apr 3 2017