New issue
Advanced search Search tips

Issue 707812 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[LLVM] Need to enable new compiler flag

Project Member Reported by cmt...@chromium.org, Apr 3 2017

Issue description

Need to enable new flag, which records command line in objects built by clang, in ChromeOS by default.

Should try to time this with compiler update.
 

Comment 1 by cmtice@google.com, Apr 18 2017

Cc: cmt...@chromium.org
 Issue 712742  has been merged into this issue.

Comment 2 by cmt...@chromium.org, May 17 2017

Just for the record, the flag we want to add to clang compiles is '-grecord-gcc-switches'.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7193f0b7182be0c1ee35f38178bc98222823ed38

commit 7193f0b7182be0c1ee35f38178bc98222823ed38
Author: Caroline Tice <cmtice@google.com>
Date: Fri Jun 16 03:13:57 2017

[llvm/gcc] Fix record-gcc-switches flags.

Remove the -frecord-gcc-switches from the GCC flags; add
-grecord-gcc-switches to the clang flags.

BUG= chromium:707812 
TEST=Tested with chromiumos-sdk trybot, with trybots for elm-release.
x86-alex-release, link-llvm-toolchain and daisy-llvm-toolchain.

Change-Id: I9fac80fe6e4c9c83c2ed3340718c6b7eebbcb213
Reviewed-on: https://chromium-review.googlesource.com/536233
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/7193f0b7182be0c1ee35f38178bc98222823ed38/sys-devel/gcc/files/sysroot_wrapper.hardened.body
[rename] https://crrev.com/7193f0b7182be0c1ee35f38178bc98222823ed38/sys-devel/gcc/gcc-4.9.2-r156.ebuild
[rename] https://crrev.com/7193f0b7182be0c1ee35f38178bc98222823ed38/sys-devel/llvm/llvm-5.0_pre300080-r8.ebuild
[modify] https://crrev.com/7193f0b7182be0c1ee35f38178bc98222823ed38/sys-devel/llvm/files/clang_host_wrapper.body

Comment 4 by cmt...@chromium.org, Jun 16 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/33606c0200d441aed644ed213823f5953c6d7569

commit 33606c0200d441aed644ed213823f5953c6d7569
Author: Caroline Tice <cmtice@google.com>
Date: Thu Oct 05 07:34:17 2017

[gcc] Remove '-frecord-gcc-switches' from the sysroot_wrapper.

This flag is unnecessary and causes some issues with the aarch64
compiler.

BUG= chromium:707812 
TEST=Successfully built & tested with the following trybots:
     chromiumos-sdk, link-release, veyron_jaq-release

Change-Id: Icd34bfcca41f271d78d58ed53f66bcc0addfe41a
Reviewed-on: https://chromium-review.googlesource.com/692744
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/33606c0200d441aed644ed213823f5953c6d7569/sys-devel/gcc/files/sysroot_wrapper.hardened.body
[rename] https://crrev.com/33606c0200d441aed644ed213823f5953c6d7569/sys-devel/gcc/gcc-4.9.2-r165.ebuild

Sign in to add a comment