New issue
Advanced search Search tips

Issue 707807 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome
Pri: 3
Type: Bug

Blocked on:
issue 706298
issue 708784

Blocking:
issue 619103


Participants' hotlists:
invalidation-glyph-overflow


Sign in to add a comment

Sometimes line box visual overflow doesn't contain all glyph overflows

Project Member Reported by wangxianzhu@chromium.org, Apr 3 2017

Issue description

https://codereview.chromium.org/2788193002 rebaselined the test and it now passes. However, the expected-png shows under-invalidated pixels at the right side of a glyph.
 
Cc: drott@chromium.org e...@chromium.org
Components: Blink>Fonts
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
Please see https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/platform/linux/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.png?q=platform/linux/paint/selection/text-selection-newline-mixed-ltr-rtl-expected.png+package:%5Echromium$&l=1. The dark red pixels are under-invalidated.

The cause might be that visual overflow of line box doesn't cover all glyph overflows. drott@ can you take a look?

(BTW, sometimes I saw residues near the bottom of glyphs in the edit box of bugs.chromium.org. Not sure if this is the same issue.)

Comment 2 Deleted

I just reproduced a glyph overflow issue on Pixel ChromeBook:

1. Input some text containing 'y', 'g' etc. in a multiline edit box in crbug.com or codereview.chromium.org.
2. Move caret to the beginning of the line and delete some characters.

Actual: some pixels at the bottom are left at their original places. The spellcheck marks also have the same problem.
Screenshot 2017-04-03 at 7.50.03 PM.png
19.7 KB View Download
Issue 706298 has been merged into this issue.
Labels: -Pri-3 Pri-2
Summary: Sometimes line box visual overflow doesn't contain all glyph overflows (was: paint/selection/text-selection-newline-mixed-ltr-rtl.html raster under-invalidation about glyph overflow)
The following info is from bug 706298:

The issue also reproduces with the attached test case on Android Chrome 57+ and WebView:
1. Push the file onto device: adb push textarea.html /sdcard/
2. Open the file in chrome (/sdcard/textarea.html)
3. Zoom in the page to maximum
4. Input some indic characters with high ascend and delete them

textarea.html
56 bytes View Download
Labels: OS-Android OS-Chrome
Owner: wangxianzhu@chromium.org
As one of my CLs exposed this bug in more cases and is treated as a regression in bug 706298, I'll try to fix this bug.
Labels: -Pri-2 ReleaseBlock-Stable M-58 Pri-1
Cc: wangxianzhu@chromium.org
Labels: -Pri-1 -ReleaseBlock-Stable -M-58 Pri-3
Owner: drott@chromium.org
I'm separating the two bugs because the fix for bug 706298 might be a workaround, while this bug is for a better fix to the general problem of glyph overflows.
Blockedon: 708784
Blockedon: 706298
Blockedon: 709462
Cc: kojii@chromium.org
See also  http://crbug.com/674279#c17  which could be related/helpful.
Blockedon: -709462

Comment 15 by drott@chromium.org, Apr 24 2017

Owner: ----
Status: Available (was: Assigned)
I currently don't have a lot of bandwidth to look into this. If someone wants to take over, please feel free to take the issue.
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 25 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by kojii@chromium.org, Apr 26 2018

Status: Available (was: Untriaged)

Sign in to add a comment