explore thinLTO on Chrome OS |
||||||||||||||
Issue descriptionWe need to explore thinLTO on Chrome for better performance.
,
Apr 11 2017
,
Apr 18 2017
Note that we intend to use LLD as the linker for the deployment of ThinLTO on Linux, you may want to consider doing the same. LLD is not only faster than gold but supports features that are unavailable with the gold plugin, such as ThinLTO cache pruning. Using LLD will also mean fewer configurations to support in the Chromium build system.
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d7a94f52e35abd17a571f074ccdb0105d3c35b71 commit d7a94f52e35abd17a571f074ccdb0105d3c35b71 Author: Yunlian Jiang <yunlian@google.com> Date: Tue Apr 18 05:50:18 2017 chromeos-chrome: Add thinlto support.. This adds thinlto support for chromeos-chrome. BUG= chromium:707803 TEST=cbuildbot falco-release elm-release daisy-release Change-Id: I4c0b074c0a22d332f4bc36c8094bb615a38c89da Reviewed-on: https://chromium-review.googlesource.com/474237 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/d7a94f52e35abd17a571f074ccdb0105d3c35b71/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c459f770aecd618c2a9302e6cdd9cdaea84e5c97 commit c459f770aecd618c2a9302e6cdd9cdaea84e5c97 Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Apr 18 22:46:52 2017 Revert "chromeos-chrome: Add thinlto support.." This reverts commit d7a94f52e35abd17a571f074ccdb0105d3c35b71. Reason for revert: It breaks all the informational builders. See one example builder log: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/peach_pit-tot-chrome-pfq-informational/builds/5908/steps/SyncChrome/logs/stdio Original change's description: > chromeos-chrome: Add thinlto support.. > > This adds thinlto support for chromeos-chrome. > > BUG= chromium:707803 > TEST=cbuildbot falco-release elm-release daisy-release > > Change-Id: I4c0b074c0a22d332f4bc36c8094bb615a38c89da > Reviewed-on: https://chromium-review.googlesource.com/474237 > Commit-Ready: Manoj Gupta <manojgupta@chromium.org> > Tested-by: Manoj Gupta <manojgupta@chromium.org> > Reviewed-by: Manoj Gupta <manojgupta@chromium.org> > TBR=cmtice@chromium.org,yunlian@chromium.org,llozano@chromium.org,rahulchaudhry@chromium.org,laszio@chromium.org,manojgupta@chromium.org,victorhsieh@chromium.org,chirantan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:707803 Change-Id: I05f184c6cffba3507b866659cde5e0d59ee660e2 Reviewed-on: https://chromium-review.googlesource.com/481007 Reviewed-by: Victor Hsieh <victorhsieh@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/c459f770aecd618c2a9302e6cdd9cdaea84e5c97/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1f57b768f72bcb5e400d9632d63b750e1d2d10cf commit 1f57b768f72bcb5e400d9632d63b750e1d2d10cf Author: Yunlian Jiang <yunlian@google.com> Date: Wed Apr 26 20:37:06 2017 chromeos-chrome: Add thinlto support.. This adds thinlto support for chromeos-chrome. BUG= chromium:707803 TEST=cbuildbot falco-release elm-release daisy-release apply the patch to chromeos-chrome-60.0.3077.0_rc-r1.ebuild emerge-carolin chromeos-chrome Change-Id: I67a295ae20aa15b964471665db0f668bfb748945 Reviewed-on: https://chromium-review.googlesource.com/486143 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/1f57b768f72bcb5e400d9632d63b750e1d2d10cf/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0170f4909915ef8e233412e5f4445e8f13af5f37 commit 0170f4909915ef8e233412e5f4445e8f13af5f37 Author: Yunlian Jiang <yunlian@google.com> Date: Fri May 19 20:57:48 2017 chromeos-chrome: use llvm-ar llvm-ranlib when clang is used. This sets the AR and RANLIB to llvm-ar and llvm-ranlib when USE="thinlto" is set. This also set the use_thin_lto flag when USE="thinlto" is set. BUG= chromium:707803 TEST=cbuildbot falco-release elm-release daisy-release Change-Id: I5b213d48d2e9f758359f51b4128f4aed1e09d447 Reviewed-on: https://chromium-review.googlesource.com/506439 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0170f4909915ef8e233412e5f4445e8f13af5f37/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/388776b8062880933c82b18503f4a58f86183e11 commit 388776b8062880933c82b18503f4a58f86183e11 Author: Yunlian Jiang <yunlian@google.com> Date: Wed May 24 21:03:49 2017 Run configure with --enable-lto on ChromeOS x86-64 This is needed for thinlto for Chrome on ChromeOS. BUG= chromium:707803 chromium:559255 TEST=ffmpeg builds with thinlto and non-thinlto. Change-Id: Id19bc04fdee7390fb2823e2a2201c68ff37c9ea3 Reviewed-on: https://chromium-review.googlesource.com/509888 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> [modify] https://crrev.com/388776b8062880933c82b18503f4a58f86183e11/chromium/config/ChromeOS/linux/x64/config.h [modify] https://crrev.com/388776b8062880933c82b18503f4a58f86183e11/chromium/scripts/build_ffmpeg.py [modify] https://crrev.com/388776b8062880933c82b18503f4a58f86183e11/chromium/config/ChromeOS/linux/x64/config.asm
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/513231b6b6fb10f70eefec4f6b3ca2dad2c5e4ca commit 513231b6b6fb10f70eefec4f6b3ca2dad2c5e4ca Author: Yunlian Jiang <yunlian@google.com> Date: Thu Jun 08 06:45:37 2017 chromeos-chrome: set allow_posix_link_time_opt when thinlto is used. The allow_posix_link_time_opt needs to set to True to enable thinlto. BUG= chromium:707803 TEST=cbuildbot falco the -flto=thin flag is added when USE=thinlto is set Change-Id: Iad2122a60032566ae7163bc1327ccae7e09dd55f Reviewed-on: https://chromium-review.googlesource.com/525934 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/513231b6b6fb10f70eefec4f6b3ca2dad2c5e4ca/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f56d9afda18b291296f71de1f91cb3c8f9e6f671 commit f56d9afda18b291296f71de1f91cb3c8f9e6f671 Author: Ting-Yuan Huang <laszio@chromium.org> Date: Tue Jun 27 15:45:21 2017 cros_sdk: increase max open files to 32768 ThinLTO opens lots of files at the same time. BUG= chromium:707803 TEST=enter and leave SDK ulimit -a shows 'open files (-n) 32768' Change-Id: Ie7de79620b6f39e761cbe4ebdc2bb1e93d9aec0b Reviewed-on: https://chromium-review.googlesource.com/540675 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/f56d9afda18b291296f71de1f91cb3c8f9e6f671/scripts/cros_sdk.py
,
Aug 3 2017
,
Oct 16 2017
,
Oct 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/a56b15600ef59326d10d7ff9fcaeba7f2847a518 commit a56b15600ef59326d10d7ff9fcaeba7f2847a518 Author: Yunlian Jiang <yunlian@google.com> Date: Sat Oct 28 07:11:37 2017 Disable USE=thinlto for profile collecting boards. We plan to enable thinlto for Chrome, but we do not want to use thinlto when we are collecting profiles. BUG= chromium:707803 TEST=unittests of chromite Change-Id: I651b5cbb05aefc82556e07fdde570db98dadcf3d Reviewed-on: https://chromium-review.googlesource.com/739951 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/a56b15600ef59326d10d7ff9fcaeba7f2847a518/cbuildbot/config_dump.json [modify] https://crrev.com/a56b15600ef59326d10d7ff9fcaeba7f2847a518/cbuildbot/chromeos_config.py
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5526fff5c688c7b28f028a5fbbdb3b38c2315c24 commit 5526fff5c688c7b28f028a5fbbdb3b38c2315c24 Author: Yunlian Jiang <yunlian@google.com> Date: Fri Nov 03 23:29:00 2017 chromeos-chrome: limit the size of import functions for thinlto. Vanilla thinlto causes the code size increases more than 20% for Chrome. This flag limits the size of imported functions for cross module inlining to 30 instructions. As a result, the code size increases less than 10% and the performance gain thinlto is kept. BUG= chromium:707803 TEST=USE="thinlto" emerge-terra chromeos-chrome measure the performance and code size. Change-Id: I0c91683cc692d67cc7abe23d059314ae7a2120c9 Reviewed-on: https://chromium-review.googlesource.com/747722 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5526fff5c688c7b28f028a5fbbdb3b38c2315c24/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Nov 21 2017
The experiment numbers is at https://docs.google.com/a/google.com/document/d/1-hl84nxuhKuNthEtGhg2BJwm8uXrITA-Ga3ulBI7fQc/edit?usp=sharing
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3105f25cb7a52428211a91a159e1831bc9eb960b commit 3105f25cb7a52428211a91a159e1831bc9eb960b Author: Yunlian Jiang <yunlian@google.com> Date: Thu Nov 30 09:13:06 2017 chromeos-chrome: use some llvm utility globally. Thinlto needs llvm utilities like llvm-ar, llvm-ranlib and so on. When enabling chromeos-chrome on canary, we want to disable it for SimpleChrome workflow. In case users want to enable thinlto in SimpleChrome, they can only change the use_thin_lto flag to make it work. BUG= chromium:707803 TEST=cbuildbot chell-chrome-pfq kevin-chrome-pfq Change-Id: I7f8d88a21ffba008ec11e6db1ed639ee87b7c0f5 Reviewed-on: https://chromium-review.googlesource.com/791252 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/3105f25cb7a52428211a91a159e1831bc9eb960b/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/434f4eef1a0f545c548ed86c5033fbd4dd523e8d commit 434f4eef1a0f545c548ed86c5033fbd4dd523e8d Author: Yunlian Jiang <yunlian@google.com> Date: Tue Dec 05 23:30:13 2017 Enable thinlto on caroline and terra release builds. We want to enable thinlto on Chrome for better performance and CFI. As a first step, we enable two AMD64 boards first. The design doc and the performance numbers can be found at the bug entry. BUG= chromium:707803 TEST=cbuildbot caroline-release terra-release Change-Id: Ia49fd06603bc601ba970d80470146f909dbd4f4a Reviewed-on: https://chromium-review.googlesource.com/790753 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/434f4eef1a0f545c548ed86c5033fbd4dd523e8d/cbuildbot/config_dump.json [modify] https://crrev.com/434f4eef1a0f545c548ed86c5033fbd4dd523e8d/cbuildbot/chromeos_config.py
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bd74301e52a1f228c5b22b00585fdd0488dd7558 commit bd74301e52a1f228c5b22b00585fdd0488dd7558 Author: Yunlian Jiang <yunlian@google.com> Date: Fri Dec 08 11:59:14 2017 chromeos-chrome: move thinlto tuning flag to EBUILD only. We want to provide simple chrome user a switch to enable/disable ThinLTO by modifying the gn files. We had set some flag that can be used only when ThinLTO is enabled, if users want to disable thinLTO, they need to modify the CFLAGS and so on. This CL moves these flags to EBUILD only so that simple chrome workflow user does not need to take care of this part. BUG= chromium:707803 TEST=USE="thinlto" emerge-falco chromeos-chrome still uses these flag. Simplechrome workflow does not include these flags. Change-Id: I8965126a86474c3a19f3080f7e032d833b0b80d1 Reviewed-on: https://chromium-review.googlesource.com/809237 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/bd74301e52a1f228c5b22b00585fdd0488dd7558/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Dec 26 2017
,
Jan 2 2018
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
,
Jan 4 2018
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/75a237e9add9f755d307fb9a1b9a8335ea45a447 commit 75a237e9add9f755d307fb9a1b9a8335ea45a447 Author: Yunlian Jiang <yunlian@chromium.org> Date: Wed Jan 10 23:44:51 2018 Disable thinlto on arm board. We want to enable thinlto on release builds of amd64 boards first. To do that, we need to mask the USE flag 'thinlto' on arm boards first. BUG= chromium:707803 TEST=equery-kevin u chromeos-chrome | grep thinlto shows nothing. Change-Id: I321f790237b22a5d5e1a025d3450af151d4eb109 Reviewed-on: https://chromium-review.googlesource.com/860562 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/75a237e9add9f755d307fb9a1b9a8335ea45a447/profiles/arch/arm/package.use.mask
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a6c5a1bbaf514502f8b15f076b0b15fe6c02822 commit 5a6c5a1bbaf514502f8b15f076b0b15fe6c02822 Author: Yunlian Jiang <yunlian@chromium.org> Date: Tue Jan 23 15:28:12 2018 Enable lto optimization for ChromeOS build. We want to enable lto optimization for ChromeOS when using ThinLTO. BUG= chromium:707803 TEST=USE="-gold lld thinlto" emerge-samus chromeos-chrome does not have -Wl,-lto=O0 flag. Change-Id: I0a1f06e60d4d2084e391e058e411956197e18aee Reviewed-on: https://chromium-review.googlesource.com/874635 Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#531241} [modify] https://crrev.com/5a6c5a1bbaf514502f8b15f076b0b15fe6c02822/build/config/compiler/BUILD.gn
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e292b75677598efbea7f3613a824082cb525871b commit e292b75677598efbea7f3613a824082cb525871b Author: Yunlian Jiang <yunlian@chromium.org> Date: Sat Jan 27 00:12:11 2018 Revert "Enable thinlto on caroline and terra release builds." This reverts commit 434f4eef1a0f545c548ed86c5033fbd4dd523e8d. Reason for revert: crbug.com/799642 Original change's description: > Enable thinlto on caroline and terra release builds. > > We want to enable thinlto on Chrome for better performance and > CFI. As a first step, we enable two AMD64 boards first. > The design doc and the performance numbers can be found at the > bug entry. > > BUG= chromium:707803 > TEST=cbuildbot caroline-release terra-release > > Change-Id: Ia49fd06603bc601ba970d80470146f909dbd4f4a > Reviewed-on: https://chromium-review.googlesource.com/790753 > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > Tested-by: Yunlian Jiang <yunlian@chromium.org> > Reviewed-by: Caroline Tice <cmtice@chromium.org> Bug: chromium:707803 Change-Id: I6cc26fa3cb0b95c102a5f3382c1594f444403990 Reviewed-on: https://chromium-review.googlesource.com/889182 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/e292b75677598efbea7f3613a824082cb525871b/cbuildbot/config_dump.json [modify] https://crrev.com/e292b75677598efbea7f3613a824082cb525871b/cbuildbot/chromeos_config.py
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/43959729b1c59dc875c388e04abe54ae0c246d2a commit 43959729b1c59dc875c388e04abe54ae0c246d2a Author: Yunlian Jiang <yunlian@chromium.org> Date: Mon Jan 29 17:31:28 2018 Revert "Enable thinlto on caroline and terra release builds." This reverts commit 434f4eef1a0f545c548ed86c5033fbd4dd523e8d. Reason for revert: crbug.com/799642 Original change's description: > Enable thinlto on caroline and terra release builds. > > We want to enable thinlto on Chrome for better performance and > CFI. As a first step, we enable two AMD64 boards first. > The design doc and the performance numbers can be found at the > bug entry. > > BUG= chromium:707803 > TEST=cbuildbot caroline-release terra-release > > Change-Id: Ia49fd06603bc601ba970d80470146f909dbd4f4a > Reviewed-on: https://chromium-review.googlesource.com/790753 > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > Tested-by: Yunlian Jiang <yunlian@chromium.org> > Reviewed-by: Caroline Tice <cmtice@chromium.org> Bug: chromium:707803 Change-Id: I6cc26fa3cb0b95c102a5f3382c1594f444403990 Previous-Reviewed-on: https://chromium-review.googlesource.com/889182 (cherry picked from commit 518a855efeba72b5d17b7315c940b07a41b9270a) Reviewed-on: https://chromium-review.googlesource.com/890393 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Trybot-Ready: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/43959729b1c59dc875c388e04abe54ae0c246d2a/cbuildbot/config_dump.json [modify] https://crrev.com/43959729b1c59dc875c388e04abe54ae0c246d2a/cbuildbot/chromeos_config.py
,
Feb 5 2018
,
Feb 9 2018
,
Feb 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b3e4450256b9612a60ab8875e9f5cdb727b5b28e commit b3e4450256b9612a60ab8875e9f5cdb727b5b28e Author: Yunlian Jiang <yunlian@chromium.org> Date: Sat Feb 24 11:21:27 2018 Re-Enable thinlto on caroline and terra release builds. This reverts commit e292b75677598efbea7f3613a824082cb525871b. Reason for revert: We worked around the error in crbug.com/799642. Original change's description: > Revert "Enable thinlto on caroline and terra release builds." > > This reverts commit 434f4eef1a0f545c548ed86c5033fbd4dd523e8d. > > Reason for revert: crbug.com/799642 > > Original change's description: > > Enable thinlto on caroline and terra release builds. > > > > We want to enable thinlto on Chrome for better performance and > > CFI. As a first step, we enable two AMD64 boards first. > > The design doc and the performance numbers can be found at the > > bug entry. > > > > BUG= chromium:707803 > > TEST=cbuildbot caroline-release terra-release > > > > Change-Id: Ia49fd06603bc601ba970d80470146f909dbd4f4a > > Reviewed-on: https://chromium-review.googlesource.com/790753 > > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > > Tested-by: Yunlian Jiang <yunlian@chromium.org> > > Reviewed-by: Caroline Tice <cmtice@chromium.org> > > Bug: chromium:707803 > Change-Id: I6cc26fa3cb0b95c102a5f3382c1594f444403990 > Reviewed-on: https://chromium-review.googlesource.com/889182 > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > Tested-by: Yunlian Jiang <yunlian@chromium.org> > Reviewed-by: Caroline Tice <cmtice@chromium.org> Bug: chromium:707803 Change-Id: I4a00144823a397102d373a001d2eb4c32a9ebd0c Reviewed-on: https://chromium-review.googlesource.com/935801 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> [modify] https://crrev.com/b3e4450256b9612a60ab8875e9f5cdb727b5b28e/cbuildbot/config_dump.json [modify] https://crrev.com/b3e4450256b9612a60ab8875e9f5cdb727b5b28e/cbuildbot/chromeos_config.py
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1c9ef7aafd767dd1b3533f5c132b39f35b6574f4 commit 1c9ef7aafd767dd1b3533f5c132b39f35b6574f4 Author: Yunlian Jiang <yunlian@chromium.org> Date: Fri Mar 02 03:13:37 2018 add terra-chrome-pfq builder to experimental. We have enabled thinlto on caroline and terra release builder. We need to test ThinLTO builds on chrome-pfq builder to make sure the chrome builds with thinlto before uprev. BUG= chromium:707803 TEST=chromite unittest passes. Change-Id: I6a9758fd6d232f579d5fdd3a01bc0da68327a9fd Reviewed-on: https://chromium-review.googlesource.com/938150 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/1c9ef7aafd767dd1b3533f5c132b39f35b6574f4/cbuildbot/config_dump.json [modify] https://crrev.com/1c9ef7aafd767dd1b3533f5c132b39f35b6574f4/cbuildbot/waterfall_layout_dump.txt [modify] https://crrev.com/1c9ef7aafd767dd1b3533f5c132b39f35b6574f4/cbuildbot/chromeos_config.py
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b12784f6a2ba2e2fbad0a6b6ffce7bdbca6de426 commit b12784f6a2ba2e2fbad0a6b6ffce7bdbca6de426 Author: Yunlian Jiang <yunlian@chromium.org> Date: Tue Mar 13 20:04:52 2018 Enable ThinLTO on all AMD64 boards. We have enabled ThinLTO on Caroline and Terra boards in R65 and so far so good. This CL enables ThinLTO on all the release builders. Because we masked the useflag 'thinlto' from all the arm boards, this CL only takes effects on all the AMD64 boards. BUG= chromium:707803 TEST=cbuildbot samus-release lumpy-release kevin-release Change-Id: I66a7eeb5926e8f28d4b33af958cbbe053a13a0d9 Reviewed-on: https://chromium-review.googlesource.com/949089 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org> [modify] https://crrev.com/b12784f6a2ba2e2fbad0a6b6ffce7bdbca6de426/cbuildbot/config_dump.json [modify] https://crrev.com/b12784f6a2ba2e2fbad0a6b6ffce7bdbca6de426/cbuildbot/chromeos_config.py
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5 commit b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Mar 16 22:50:01 2018 Roll src/third_party/chromite/ 3b75c9d82..3ad8f333d (31 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567 $ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s' 2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."" 2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." 2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2] 2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." 2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket. 2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob" 2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. 2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob 2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland. 2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds. 2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues. 2018-03-14 ihf chromeos_config: add more arcnext experimental coverage. 2018-03-14 ayatane autotest-pre-cq: Remove this [1/2] 2018-03-14 norvez chromeos_config: remove dead code 2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning. 2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation. 2017-09-14 craigb image_test: Remove check that kernel is not ELF. 2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental" 2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq" 2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config 2018-03-13 achuith cbuildbot: Add missing files to index. 2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion 2018-03-13 dgarrett precq-launcher: Start using Legoland build details page. 2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest. 2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq 2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental 2018-03-12 haddowk [chromite] Make guado_moblab important again 2018-03-13 chrome-bot Update config settings by config-updater. 2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite 2018-03-12 yunlian Enable ThinLTO on all AMD64 boards. 2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON. Created with: roll-dep src/third_party/chromite BUG=821930, 822517 , 821615 ,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib6aaddf338307e994865a092ecb322a432148692 Reviewed-on: https://chromium-review.googlesource.com/967273 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543855} [modify] https://crrev.com/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5/DEPS
,
Mar 29 2018
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8b1631d14c1acc30615a58707def82125505076d commit 8b1631d14c1acc30615a58707def82125505076d Author: Yunlian Jiang <yunlian@chromium.org> Date: Fri Mar 30 02:51:38 2018 chromeos-config: remove USE=thinlto from terra and caroline-release We have enabled thinlto on all the AMD64 boards, so there is no need to keep this flag for terra and caroline boards. BUG= chromium:707803 TEST=unitest passes Change-Id: I01f777a434125fd2cb308df3a1ed9a546ff05c39 Reviewed-on: https://chromium-review.googlesource.com/986506 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/8b1631d14c1acc30615a58707def82125505076d/cbuildbot/chromeos_config.py
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7017df438ed3652f4095a51536b11f715bd04fcb commit 7017df438ed3652f4095a51536b11f715bd04fcb Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Mar 30 06:23:43 2018 Roll src/third_party/chromite/ 33146a204..36a9c890b (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/33146a20418a..36a9c890b979 $ git log 33146a204..36a9c890b --date=short --no-merges --format='%ad %ae %s' 2018-03-29 yunlian Add USE=thinlto for AMD64 release buidlers only. 2018-03-29 vapier gs: update to 4.30 2018-03-29 yunlian chromeos-config: remove USE=thinlto from terra and caroline-release 2018-03-27 smbarber chromeos_config: add tael to external waterfall 2018-03-28 dgarrett precq: Add eve-no-vmtest-pre-cq. Created with: roll-dep src/third_party/chromite BUG= chromium:827217 ,chromium:None,chromium:707803,chromium:824615,chromium:820252 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I83683cdbd852c5097195bb0689107322912eeb7f Reviewed-on: https://chromium-review.googlesource.com/987452 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547117} [modify] https://crrev.com/7017df438ed3652f4095a51536b11f715bd04fcb/DEPS
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/29c686803a7199b5d94b6d3ed51c22a801ee494c commit 29c686803a7199b5d94b6d3ed51c22a801ee494c Author: Yunlian Jiang <yunlian@google.com> Date: Thu May 10 18:42:36 2018 Enable thinlto on Chrome for AMD64 boards. We have enabled ThinLTO on release builders for Chrome on AMD64 boards. Now we want to enable it for all the builds for consistency. BUG= chromium:707803 TEST=equery-samus w chromeos-chrome shows +thinlto if chromeos-chrome version becomes greater than chromeos-chrome-68.0.3428 Change-Id: I1d904bf422f134cba18f247608e143fc388ac241 Reviewed-on: https://chromium-review.googlesource.com/1052376 Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [add] https://crrev.com/29c686803a7199b5d94b6d3ed51c22a801ee494c/profiles/arch/amd64/package.use
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/724f6f0c6ec8fa4ded329d1752bdf1e6acaa705f commit 724f6f0c6ec8fa4ded329d1752bdf1e6acaa705f Author: Yunlian Jiang <yunlian@google.com> Date: Mon May 14 22:32:56 2018 clean up USE="thinlto" flag. We have enabled USE="thinlto" by default for all the AMD64 configurations, so there is no need to set the use flags in chromeos_config. It also sets USE="thinlto" for toolchain builders so that we can test this flag for ARM board. BUG= chromium:707803 TEST=equery-samus u chromeos-chrome shows USE="thinlto" is set. run_test passes. Change-Id: Idfd1c847674460cb766357879ea4f11bea6ffbd6 Reviewed-on: https://chromium-review.googlesource.com/1057442 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/724f6f0c6ec8fa4ded329d1752bdf1e6acaa705f/cbuildbot/config_dump.json [modify] https://crrev.com/724f6f0c6ec8fa4ded329d1752bdf1e6acaa705f/cbuildbot/chromeos_config.py
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e7c73958d7c7b2ee1735f0c393f0c92cf7ca41a commit 9e7c73958d7c7b2ee1735f0c393f0c92cf7ca41a Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon May 14 23:58:32 2018 Roll src/third_party/chromite/ b15c2c282..7e9e7b065 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/b15c2c28232c..7e9e7b065a98 $ git log b15c2c282..7e9e7b065 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 gmeinke cbuildbot: remove format command from build_stages 2018-05-14 yunlian clean up USE="thinlto" flag. Created with: roll-dep src/third_party/chromite BUG= chromium:707803 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3ae9a5d244e8fdf2bdb889819d79904f3d591402 Reviewed-on: https://chromium-review.googlesource.com/1058436 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558536} [modify] https://crrev.com/9e7c73958d7c7b2ee1735f0c393f0c92cf7ca41a/DEPS
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Oct 10
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 5 2017