Upload a cl for review to flip the flag to make the screen rotation animation enabled by default.
Changed the flag to kAshDisableSmoothScreenRotationName.

https://codereview.chromium.org/2837773003/

The flag has been changed to kAshDisableSmoothScreenRotation.

Default is sync in test code. Many tests are setup with the switch in ash_test_helper, so in the test will call sync by default. Any test for new animation, we need to remove the switch or attach empty switch.


When removing the flag, we need to put the tests using async animation. For any test requires sync animation, will use the new enum to choose the sync mode.

Hi oshima@, is it ok to remove this flag now.

Thanks!

sgtm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1041214265f46e6bd84299fc7205f12c47b90bb

commit b1041214265f46e6bd84299fc7205f12c47b90bb
Author: wutao <wutao@chromium.org>
Date: Tue Dec 11 19:12:43 2018

ash: Remove flag kAshDisableSmoothScreenRotation

This feature has been enabled by default since M60. It is stable enough
to be always enabled.

Bug:  707800 
Test: manual and coverred by unittest.
Change-Id: I03e88f0b3a95d4f76ebd3a51f9f9241f257c82c3
Reviewed-on: https://chromium-review.googlesource.com/c/1370953
Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615616}
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/ash/display/display_configuration_controller_unittest.cc
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/ash/rotator/screen_rotation_animator.h
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/ash/test/ash_test_helper.cc
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/chrome/browser/about_flags.cc
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/b1041214265f46e6bd84299fc7205f12c47b90bb/chrome/browser/flag_descriptions.h