Find bar shows "1 of 0" |
||||||
Issue descriptionChrome Version: 59.0.3062.0 What steps will reproduce the problem? (1) Navigate to a page with a text field, such as https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_form_submit (2) Type a unique string into the text field, such as "abcde". (3) Use find-in-page to search for this text. (find bar shows "1 of 1") (4) Delete the text from the text field. (5) Search again for the same thing using the down arrow or by hitting Enter in the find bar. What is the expected result? The find bar should update its results to show "0 of 0". What happens instead? The find bar shows "1 of 0". This is not a valid state.
,
Apr 4 2017
,
Apr 7 2017
,
Apr 7 2017
,
Apr 7 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78afc8b02f24bd416c58f4c4d58c3bf0c0c7f8b8 commit 78afc8b02f24bd416c58f4c4d58c3bf0c0c7f8b8 Author: Paul Meyer <paulmeyer@chromium.org> Date: Fri Apr 07 18:17:25 2017 Fix find-in-page "1 of 0" bug. This patch enabled FindRequestManager to update the active match ordinal properly when all matches are dynamically removed from the page between subsequent find requests. BUG= 707798 Review-Url: https://codereview.chromium.org/2790213002 Cr-Commit-Position: refs/heads/master@{#461522} (cherry picked from commit 0f4e7a51e872861c59e466cbb498caa4ea54b808) Review-Url: https://codereview.chromium.org/2802283002 . Cr-Commit-Position: refs/branch-heads/3029@{#625} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/78afc8b02f24bd416c58f4c4d58c3bf0c0c7f8b8/content/browser/find_request_manager.cc
,
Apr 12 2017
Verified the issue on Mac os 10.12.2 , windows 7 and ubuntu 14.04 using chrome beta M58 #58.0.3029.68 and issue seems fixed. Steps followed to verify the issue : (1) Navigate chrome to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_form_submit (2) Typed a unique string into the text field, such as "abcde". (3) Used find-in-page to search for this text. (find bar shows "1 of 1") (4) Deleted the text from the text field. (5) Searched again for the same thing using the down arrow or by hitting Enter in the find bar adn observed that the find bar updated its results to show "0 of 0". Attached screencast for reference. Adding TE-Verified lables. Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Apr 3 2017