Ideally the implementations should depend on media_type parameter but having true for has_image_contents for all types(link, audio, video ...) is a bit confusing. The value hasImageContents is being filled properly in ContextMenuClientImpl::showContextMenu for image and canvas element. So isn't it nice to have default value as false?

I'm not familiar with this code, but that does sound like an odd default. Maybe prepare a CL and see what the reviewer says?

ok, i will do that

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d68c1beaad7929dddc6e6e1278dd03fedcd348eb

commit d68c1beaad7929dddc6e6e1278dd03fedcd348eb
Author: srirama.m <srirama.m@samsung.com>
Date: Fri Apr 14 12:04:28 2017

Change default value of has_image_contents

The default value of has_image_contents(in context_menu_params.cc, WebContextMenuData.h) is true by default.
These values mean there is an image content for the long pressed node.

Changed default value to false to make it less confusing for
elements(Link, video) other than image, canvas.
This value is being set properly incase of canvas and image elements
in ContextMenuClientImpl::ShowContextMenu and it is being used only
incase of media_type kMediaTypeImage in render_view_context_menu.cc.
So this change will not cause any difference to the existing code flow.

BUG= 707789 

Review-Url: https://codereview.chromium.org/2803233002
Cr-Commit-Position: refs/heads/master@{#464717}

[modify] https://crrev.com/d68c1beaad7929dddc6e6e1278dd03fedcd348eb/content/public/common/context_menu_params.cc
[modify] https://crrev.com/d68c1beaad7929dddc6e6e1278dd03fedcd348eb/third_party/WebKit/public/web/WebContextMenuData.h