Issue metadata
Sign in to add a comment
|
32kb regression in resource_sizes (MonochromePublic.apk) at 460926:460926 |
||||||||||||||||||||
Issue descriptionCaused by: "Support for OpenType Font Variations on Windows" https://codereview.chromium.org/2792453002 Graph link: https://chromeperf.appspot.com/report?sid=ec464e89358810af9b857af88d316e5ee1b735fc532f3b1a883380d26d29da06&rev=460926 From the description, this should not have affected Android.
,
Apr 3 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8983325011995909728
,
Apr 3 2017
thestig@, is pdf support compiled for Android? We added 3 files to FreeType in order to be able to share FreeType between PDFium and Blink. If Chrome does not compile the built in PDFium for Android, but instead relies on the system PDF viewer and downloading, then we can exempt building the 3 files "src/src/type1/type1.c", "src/src/psaux/psaux.c", and "src/src/cid/type1cid.c" from building for Android.
,
Apr 3 2017
=== Auto-CCing suspected CL author stgao@chromium.org === Hi stgao@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : stgao Commit : 27b5c368e1cd8535b26aacc593e544e18d04d29f Date : Thu Mar 30 23:26:51 2017 Subject: Reland of Support for OpenType Font Variations on Windows (patchset #1 id:1 of https://codereview.chromium.org/2786263002/ ) Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : resource_sizes Metric : MonochromePublic.apk_Specifics/normalized apk size Change : 0.04% | 73410412.0 -> 73443180.0 Revision Result N chromium@460925 73410412 +- 0.0 6 good chromium@460926 73443180 +- 0.0 6 bad <-- To Run This Test src/build/android/resource_sizes.py --chromium-output-directory {CHROMIUM_OUTPUT_DIR} --chartjson {CHROMIUM_OUTPUT_DIR}/apks/MonochromePublic.apk Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8983325011995909728 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5734424974458880 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 3 2017
That's certainly the case. There is no pdfium for Android Chrome.
,
Apr 3 2017
Route to drott@ as drott@ is the author of the original CL.
,
Apr 4 2017
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/945c459ee86d70a798af66346f7025453d9b16cd commit 945c459ee86d70a798af66346f7025453d9b16cd Author: drott <drott@chromium.org> Date: Mon Apr 10 11:23:09 2017 Do not build type1, type1cid and psaux FreeType modules on Android In 27b5c368e1cd8535b26aacc593e544e18d04d29f we added three additional FreeType modules required by PDFium on desktop. Since we do not build PDFium for Android we do not need to build those modules for the Android platform and can save on binary size. BUG= 707782 Review-Url: https://codereview.chromium.org/2800393002 Cr-Commit-Position: refs/heads/master@{#463219} [modify] https://crrev.com/945c459ee86d70a798af66346f7025453d9b16cd/third_party/freetype/BUILD.gn [modify] https://crrev.com/945c459ee86d70a798af66346f7025453d9b16cd/third_party/freetype/include/freetype-custom-config/ftmodule.h
,
Apr 10 2017
Locally, the improvement looks good. Could you verify the savings, agrieve@? Thank you in advance.
,
Apr 10 2017
Looks like we won't be able to verify until https://bugs.chromium.org/p/chromium/issues/detail?id=710025 is fixed.
,
Apr 11 2017
Confirmed! https://chromeperf.appspot.com/report?sid=ec464e89358810af9b857af88d316e5ee1b735fc532f3b1a883380d26d29da06&rev=463219 Last commit shrunk the apk by 61474 bytes. \o/
,
Apr 11 2017
Thanks for verifying. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by agrieve@google.com
, Apr 3 2017