New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707774 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-25
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

PRESUBMIT errors message is incorrect

Project Member Reported by serg...@chromium.org, Apr 3 2017

Issue description

I've noticed that presubmit errors for team tags list incorrect files for components mapping to multiple teams. For example, in log https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F398742%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout, there is a line:

... The component "Blink>Canvas" has more than one team: paint-dev@chromium.org is used in third_party/WebKit/Source/platform/graphics, ...

The file third_party/WebKit/Source/platform/graphics contains "Blink>Paint" component, not "Blink>Canvas".
 
Another example in the same log:

... The component "Blink>HTML" has more than one team: blink-network-dev@chromium.org is used in third_party/WebKit/public/platform/modules/fetch, third_party/pywebsocket, third_party/WebKit/Source/modules/fetch, third_party/WebKit/Source/core/xmlhttprequest, net/data/websocket, ...

None of these files contain Blink>HTML component.
seems we are listing all OWNERS of a specific team instead of specific team+component. wait for robertocn to comment on this.
Components: -Infra Infra>Client>Chrome
Roberto, friendly ping. :-)
Cc: -robert...@chromium.org
Owner: robert...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Roberto to get his response.
NextAction: 2017-04-25
I am sorry I missed this. I will take a look tomorrow morning.

This is pending code review.
Cc: kateso...@chromium.org
This is the patch that fixes this: https://chromium-review.googlesource.com/c/498055/
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcd156bf1084bef8db83843f294ff6c61b5a243

commit abcd156bf1084bef8db83843f294ff6c61b5a243
Author: Roberto Carrillo <robertocn@google.com>
Date: Wed May 31 04:17:49 2017

[Component tags] List only offending dirs in presubmit message.

This is to fix a problem where the error message lists all the
directories owned by the teams that share a component instead of only
those that actually have the component specified.

BUG= 707774 
R=ymzhang,sshruthi,katesonia

Change-Id: Ibee24a40604d0e0e4e0475f937782887cf360ab7
Reviewed-on: https://chromium-review.googlesource.com/498055
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475792}
[modify] https://crrev.com/abcd156bf1084bef8db83843f294ff6c61b5a243/tools/checkteamtags/checkteamtags.py

Status: Fixed (was: Assigned)
Thanks.

Sign in to add a comment