New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707767 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit 16 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

Refactor suggestions UI metrics recording

Project Member Reported by dgn@chromium.org, Apr 3 2017

Issue description

Here are the different ways we record events in the context of ntp suggestions:

- UMA recorded directly from Java: NewTabPageUMA, maybe other things
- UMA recorded inderectily through the content suggestions metrics backend: SnippetsBridge
- Events notified to the scheduler: SnippetsBridge. We just send usage signals to the scheduler so that is can adjust the fetch frequency.
- Other?

A first issue with the way we do that currently is that the general metrics recording should not be tied to a bridge instance. The metrics recording itself is done through plain functions.
Event notifications themselves also doesn't need it as it is all related to the single content suggestions service that is accessible through the profile anyway.

That would leave the SnippetsBridge with functions related to being a suggestions source and more 2 way communication between java and c++.

The second issue is how some general suggestions metrics should not care about being in the NTP or not, so move out of NewTabPageUMA.
 

Comment 1 by treib@chromium.org, Apr 3 2017

Cc: treib@chromium.org markusheintz@chromium.org jkrcal@chromium.org
Labels: OS-iOS
+markusheintz has been thinking about this too, specifically about moving metrics out of the bridge. This will be particularly important for iOS, since we don't want to duplicate the metrics code.

Comment 2 by dgn@chromium.org, Apr 3 2017

I filed this thinking mostly about the java side of the recording, but if can improve also the c++ side it's even better!

Comment 3 by dgn@chromium.org, May 22 2017

Owner: treib@chromium.org
For java this was mostly fixed in  issue 710268  and with https://codereview.chromium.org/2846233003 (issue 693593)

Passing over to treib@ if there is something to do for C++/iOS

Comment 4 by dgn@google.com, Jun 28 2017

Blocking: -677672
Issue 677672 not blocked on this anymore after #c3

Comment 5 by treib@chromium.org, Jun 28 2017

Cc: gambard@chromium.org
Owner: markusheintz@chromium.org
Status: Started (was: Available)
I think we're in a much better state now here, though two metrics (dismissals of suggestions and of categories) are still recorded from the bridge. I guess it should be easy to move those into the service - that should happen at least before we launch on iOS.

All that said, I'm not very up to date with the latest on metrics. Over to Markus for that.
Components: -UI>Browser>NewTabPage UI>Browser>ContentSuggestions

Sign in to add a comment