^^^ For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
^^^
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64bdeb2244044a245c98c092075f750345acd9a0 commit 64bdeb2244044a245c98c092075f750345acd9a0 Author: sebsg <sebsg@chromium.org> Date: Fri Apr 21 02:04:45 2017 [Payments] Normalize Shipping Address sent to merchant on Desktop. BUG= 707765 Review-Url: https://codereview.chromium.org/2829503002 Cr-Commit-Position: refs/heads/master@{#466226} [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/chrome/browser/payments/chrome_payment_request_delegate.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/chrome/browser/payments/chrome_payment_request_delegate.h [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/autofill/core/browser/address.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/autofill/core/browser/autofill_data_util.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/autofill/core/browser/autofill_data_util.h [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/autofill/core/browser/autofill_data_util_unittest.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/payments/content/payment_request_state.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/payments/content/payment_response_helper.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/payments/content/payment_response_helper.h [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/payments/core/address_normalizer.h [modify] https://crrev.com/64bdeb2244044a245c98c092075f750345acd9a0/components/payments/core/payment_request_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1203bae1a53e9d825f2c8fdffda0083ad4c5384a commit 1203bae1a53e9d825f2c8fdffda0083ad4c5384a Author: keishi <keishi@chromium.org> Date: Fri Apr 21 03:42:54 2017 Revert of [Payments] Normalize Shipping Address sent to merchant on Desktop. (patchset #4 id:240001 of https://codereview.chromium.org/2829503002/ ) Reason for revert: Might have caused PaymentResponseHelperTest.GeneratePaymentResponse_* tests to fail on Mac10.9 Tests (dbg) https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/39635 Original issue's description: > [Payments] Normalize Shipping Address sent to merchant on Desktop. > > BUG= 707765 > > Review-Url: https://codereview.chromium.org/2829503002 > Cr-Commit-Position: refs/heads/master@{#466226} > Committed: https://chromium.googlesource.com/chromium/src/+/64bdeb2244044a245c98c092075f750345acd9a0 TBR=anthonyvd@chromium.org,rouslan@chromium.org,sebsg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 707765 Review-Url: https://codereview.chromium.org/2832003003 Cr-Commit-Position: refs/heads/master@{#466249} [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/chrome/browser/payments/chrome_payment_request_delegate.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/chrome/browser/payments/chrome_payment_request_delegate.h [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/autofill/core/browser/address.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/autofill/core/browser/autofill_data_util.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/autofill/core/browser/autofill_data_util.h [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/autofill/core/browser/autofill_data_util_unittest.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/payments/content/payment_request_state.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/payments/content/payment_response_helper.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/payments/content/payment_response_helper.h [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/payments/core/address_normalizer.h [modify] https://crrev.com/1203bae1a53e9d825f2c8fdffda0083ad4c5384a/components/payments/core/payment_request_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a9c23403a7f9840cf4d9cbc517535ad6b8de953 commit 8a9c23403a7f9840cf4d9cbc517535ad6b8de953 Author: sebsg <sebsg@chromium.org> Date: Fri Apr 21 17:05:15 2017 Reland: Normalize shipping address for merchant on Desktop. The CL was causing some tests to fail, because the FakeAddressNormalizer in tests initialized the AddressValidator with a null storage, which triggered an assertion failure in some cases. By creating an AddressNormalizer interface, the FakeAddressNormalizer doesn't need to create an AddressValidator object and can be used in test more easily. BUG= 707765 Original CL: https://codereview.chromium.org/2829503002/ Review-Url: https://codereview.chromium.org/2829903004 Cr-Commit-Position: refs/heads/master@{#466369} [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/autofill/android/personal_data_manager_android.h [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/payments/chrome_payment_request_delegate.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/payments/chrome_payment_request_delegate.h [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/autofill/core/browser/address.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/autofill/core/browser/autofill_data_util.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/autofill/core/browser/autofill_data_util.h [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/autofill/core/browser/autofill_data_util_unittest.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/content/payment_request_state.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/content/payment_response_helper.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/content/payment_response_helper.h [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/content/payment_response_helper_unittest.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/core/BUILD.gn [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/core/address_normalizer.h [rename] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/core/address_normalizer_impl.cc [add] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/core/address_normalizer_impl.h [rename] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/core/address_normalizer_impl_unittest.cc [modify] https://crrev.com/8a9c23403a7f9840cf4d9cbc517535ad6b8de953/components/payments/core/payment_request_delegate.h
Comment 1 by se...@chromium.org
, Apr 3 2017