New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707764 link

Starred by 1 user
Status: Duplicate
Merged: issue 707010
Owner:
michaeldo@chromium.org
Closed: Apr 2017
Cc:
█ huangml@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Evaluate if relaxing the cross-thread checks in http_server is correct.

Project Member Reported by jif@chromium.org, Apr 3 2017 
https://codereview.chromium.org/2666423002 added thread checks regarding RefCount.
This broke the EG tests relying on the HttpServer.

I disabled the DCHECKs with ScopedAllowCrossThreadRefCountAccess to get the tests working and the tree opened, but this may not be the correct fix.

Comment 1 by baxley@chromium.org, Apr 3 2017

Cc: huangml@chromium.org
Owner: michaeldo@chromium.org

Comment 2 by jif@chromium.org, Apr 3 2017 

Cl is https://codereview.chromium.org/2794933002/
It's currently being reviewed by sdefresne, and it sounds as if there will need to be some changes.

Comment 3 by baxley@chromium.org, Apr 3 2017 

Yes. huangml@ is in progress of swapping out the http_server for one that supports https. If there is a serious bug in http_server it should be fixed, but if we can last the ~weeks for the new server to land, then I think this is okay.

jif@, thanks for addressing this!

Comment 4 by jif@chromium.org, Apr 3 2017

Mergedinto: 707010
Status: Duplicate (was: Assigned)
►

Sign in to add a comment