The suggested content on the NTP should display the Most Visited tiles.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faf8e94ac52d828621c9ad0d3a491a147c701de7 commit faf8e94ac52d828621c9ad0d3a491a147c701de7 Author: gambard <gambard@chromium.org> Date: Tue Apr 04 06:55:22 2017 Create an Obj-C bridge for MostVisitedSitesObserver BUG= 707754 Review-Url: https://codereview.chromium.org/2791253002 Cr-Commit-Position: refs/heads/master@{#461648} [modify] https://crrev.com/faf8e94ac52d828621c9ad0d3a491a147c701de7/ios/chrome/browser/ntp_tiles/BUILD.gn [add] https://crrev.com/faf8e94ac52d828621c9ad0d3a491a147c701de7/ios/chrome/browser/ntp_tiles/most_visited_sites_observer_bridge.h [add] https://crrev.com/faf8e94ac52d828621c9ad0d3a491a147c701de7/ios/chrome/browser/ntp_tiles/most_visited_sites_observer_bridge.mm [modify] https://crrev.com/faf8e94ac52d828621c9ad0d3a491a147c701de7/ios/chrome/browser/ui/ntp/google_landing_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3147e853f63020dc085577281385e4aa898a95c6 commit 3147e853f63020dc085577281385e4aa898a95c6 Author: gambard <gambard@chromium.org> Date: Thu Apr 06 12:16:50 2017 Add MostVistedSites to ContentSuggestionsMediator The ContentSuggestionsMediator now returns the MostVisited tiles in the suggestions availables. BUG= 707754 Review-Url: https://codereview.chromium.org/2798563002 Cr-Commit-Position: refs/heads/master@{#462435} [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/content_suggestions/BUILD.gn [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/content_suggestions/mediator_util.h [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/content_suggestions/mediator_util.mm [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/ui/content_suggestions/content_suggestion.h [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm [modify] https://crrev.com/3147e853f63020dc085577281385e4aa898a95c6/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cde4c9664fbafda7dffe1c61ac059d6bd80882b3 commit cde4c9664fbafda7dffe1c61ac059d6bd80882b3 Author: gambard <gambard@chromium.org> Date: Mon Apr 10 14:27:48 2017 Create a Most Visited tile for ContentSuggestions This CL creates a ContentSuggestionsMostVisitedTile view displaying a Most Visited suggestion, with a favicon and a title. It also creates a ContentSuggestionsMostVisited, containing the informations for the tile. BUG= 707754 Review-Url: https://codereview.chromium.org/2803223002 Cr-Commit-Position: refs/heads/master@{#463258} [modify] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [add] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h [add] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.mm [add] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_tile.h [add] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_tile.mm [add] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_tile_unittest.mm [add] https://crrev.com/cde4c9664fbafda7dffe1c61ac059d6bd80882b3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4ac95b13ea78688e1a8dfd6dbceac097e7fc968 commit d4ac95b13ea78688e1a8dfd6dbceac097e7fc968 Author: gambard <gambard@chromium.org> Date: Wed Apr 12 07:51:08 2017 Create a MostVisited cell for ContentSuggestions This CL creates a MostVisited cell and item which can be used to display the Most Visited sites in Content Suggestions. BUG= 707754 Review-Url: https://codereview.chromium.org/2808433002 Cr-Commit-Position: refs/heads/master@{#463949} [modify] https://crrev.com/d4ac95b13ea78688e1a8dfd6dbceac097e7fc968/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [add] https://crrev.com/d4ac95b13ea78688e1a8dfd6dbceac097e7fc968/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h [add] https://crrev.com/d4ac95b13ea78688e1a8dfd6dbceac097e7fc968/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm [add] https://crrev.com/d4ac95b13ea78688e1a8dfd6dbceac097e7fc968/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29067c254b36f05d476335066744e3f6782c7e98 commit 29067c254b36f05d476335066744e3f6782c7e98 Author: gambard <gambard@chromium.org> Date: Tue May 09 07:55:55 2017 Add Most Visited tiles to ContentSuggestions This CL creates and add the Most Visited tiles to the ContentSuggestions. BUG= 707754 , 708491 , 713183 Review-Url: https://codereview.chromium.org/2815023003 Cr-Commit-Position: refs/heads/master@{#470264} [modify] https://crrev.com/29067c254b36f05d476335066744e3f6782c7e98/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39c34e94e02aa327f7f08b888f1d0949cb940a9c commit 39c34e94e02aa327f7f08b888f1d0949cb940a9c Author: gambard <gambard@chromium.org> Date: Wed May 10 07:23:11 2017 Create individual cells for MostVisited tiles This CL displays the MostVisited tiles as individual cells instead of using one big cell and fitting all of them inside. This allows easier interactions with the user and easier animations on rotation. The layout is yet to be done. BUG= 707754 Review-Url: https://codereview.chromium.org/2873503005 Cr-Commit-Position: refs/heads/master@{#470512} [modify] https://crrev.com/39c34e94e02aa327f7f08b888f1d0949cb940a9c/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn [delete] https://crrev.com/399218194335c41bdb975bff6a7aac99d4dd6b0c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h [delete] https://crrev.com/399218194335c41bdb975bff6a7aac99d4dd6b0c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.mm [modify] https://crrev.com/39c34e94e02aa327f7f08b888f1d0949cb940a9c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.h [modify] https://crrev.com/39c34e94e02aa327f7f08b888f1d0949cb940a9c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item.mm [modify] https://crrev.com/39c34e94e02aa327f7f08b888f1d0949cb940a9c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_item_unittest.mm [delete] https://crrev.com/399218194335c41bdb975bff6a7aac99d4dd6b0c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_tile.h [delete] https://crrev.com/399218194335c41bdb975bff6a7aac99d4dd6b0c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_tile.mm [delete] https://crrev.com/399218194335c41bdb975bff6a7aac99d4dd6b0c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_tile_unittest.mm [delete] https://crrev.com/399218194335c41bdb975bff6a7aac99d4dd6b0c/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_unittest.mm [modify] https://crrev.com/39c34e94e02aa327f7f08b888f1d0949cb940a9c/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91228d6c2af35f799237940bd218ab5df9d18008 commit 91228d6c2af35f799237940bd218ab5df9d18008 Author: gambard <gambard@chromium.org> Date: Wed May 17 16:11:16 2017 Identify MostVisited by item instead of URL The Most Visited items displayed by the Collection View cannot be identified by their URL as the UI layer cannot know about them. When a favicon of a Most Visited is updated, the ContentSuggestionsDataSource directly passes the item instead of the URL. BUG= 707754 , 720271 Review-Url: https://codereview.chromium.org/2888533002 Cr-Commit-Position: refs/heads/master@{#472466} [modify] https://crrev.com/91228d6c2af35f799237940bd218ab5df9d18008/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/91228d6c2af35f799237940bd218ab5df9d18008/ios/chrome/browser/content_suggestions/mediator_util.h [modify] https://crrev.com/91228d6c2af35f799237940bd218ab5df9d18008/ios/chrome/browser/content_suggestions/mediator_util.mm [modify] https://crrev.com/91228d6c2af35f799237940bd218ab5df9d18008/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/91228d6c2af35f799237940bd218ab5df9d18008/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/91228d6c2af35f799237940bd218ab5df9d18008/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77cd7e79cf24ddef0c1a40c3f5497eb125432aee commit 77cd7e79cf24ddef0c1a40c3f5497eb125432aee Author: gambard <gambard@chromium.org> Date: Thu May 18 06:41:34 2017 Layout Most Visited for ContentSuggestions Layout the Most Visited tiles to have them displayed as wanted in the ContentSuggestions view. It displays them as individual cells, maximum 4 by rows. BUG= 707754 Review-Url: https://codereview.chromium.org/2887073002 Cr-Commit-Position: refs/heads/master@{#472712} [modify] https://crrev.com/77cd7e79cf24ddef0c1a40c3f5497eb125432aee/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm [modify] https://crrev.com/77cd7e79cf24ddef0c1a40c3f5497eb125432aee/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/77cd7e79cf24ddef0c1a40c3f5497eb125432aee/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/77cd7e79cf24ddef0c1a40c3f5497eb125432aee/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f344e0cdffec00b918859ccc01419cd1791b35dc commit f344e0cdffec00b918859ccc01419cd1791b35dc Author: gambard <gambard@chromium.org> Date: Thu May 18 15:28:32 2017 Limit the number of Most Visited lines to two The Most Visited tiles are not longer displayed on more than two lines. BUG= 707754 Review-Url: https://codereview.chromium.org/2888403002 Cr-Commit-Position: refs/heads/master@{#472820} [modify] https://crrev.com/f344e0cdffec00b918859ccc01419cd1791b35dc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h [modify] https://crrev.com/f344e0cdffec00b918859ccc01419cd1791b35dc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm [modify] https://crrev.com/f344e0cdffec00b918859ccc01419cd1791b35dc/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc commit 28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc Author: gambard <gambard@chromium.org> Date: Wed Jun 07 11:05:37 2017 Reload the Most Visited section when it changes When the Most Visited model changes, the UI should be updated only on user interaction. BUG= 707754 , 724427 Review-Url: https://codereview.chromium.org/2923973002 Cr-Commit-Position: refs/heads/master@{#477610} [modify] https://crrev.com/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/28050dfc93a9ff9de70fcfba4e49aefdfc08d5fc/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
Comment 1 by bugdroid1@chromium.org
, Apr 4 2017