New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707751 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
not available
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

build/android/test_runner.py --wait_debugger flag currently does nothing.

Project Member Reported by jdoerrie@chromium.org, Apr 3 2017

Issue description

Chrome Version: Master
OS: Android

What steps will reproduce the problem?
(1) Build chrome_public_apk chrome_sync_shell_test_apk chrome_sync_shell_apk targets for Android
(2) Install Chrome (build/android/adb_install_apk.py out/Android/apks/ChromePublic.apk)
(3) Run SyncShellTest with Wait for Debugger Flag:
./out/Android/bin/run_chrome_sync_shell_test_apk -w      

What is the expected result?
Test waits 60 seconds to give a debugger a chance to attach.

What happens instead?
Test does not wait and runs immediately.
 
Labels: -Type-Bug OS-Android Type-Feature
Owner: yolandyan@chromium.org
Status: Assigned (was: Untriaged)
Summary: build/android/test_runner.py --wait_debugger flag currently does nothing. (was: ChromeSyncShellTest ignores Wait for Debugger Flag)
Hmmm, it seems that we do absolutely nothing if wait_for_debugger flag is set.

Assigning to Yoland who was interested in getting Java debugger set up for Android tests.


Cc: mikec...@chromium.org
I thought that this worked the last time I tried it, but that (1) may have been for gtests, not instrumentation tests, and (2) was definitely before my flag rewrite.
Searching "wait_for_debugger file:pylib" currently turns up empty on codesearch.

https://cs.chromium.org/search/?q=wait_for_debugger+file:pylib&type=cs

If this option is used, I dont see it
Hmm, maybe I was passing --test-arguments="--wait-for-debugger" (which should now just work as "test_runner.py --wait-for-debugger")

Sign in to add a comment