New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707730 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Dismissal of Reading List suggestions

Project Member Reported by gambard@chromium.org, Apr 3 2017

Issue description

What is the intended behavior if the user dismisses a suggested Reading List entry?
I think we should not present it again on the NTP of the device on which it has been dismissed. The other devices should still present it.
 
Cc: mard...@chromium.org olivierrobin@chromium.org
mardini, WDYT?

Comment 2 by treib@chromium.org, Apr 3 2017

Dismissing the suggestion should *not* remove it from the reading list, but it should remove it from future NTPs. It could be shown again on explicit "update" events, e.g. if the users explicitly refreshes it (I don't know if such an action exists).

I'm not sure if the dismissal should propagate to other devices. I think we generally don't do that.
As discussed offline, dismissal should remove it only from future NTPs but leave it on its dedicated surface (on device or on other devices).
Ok, the behavior will be:
- Dismissal on swipe left only (no long press)
- Once dismissed the Reading List entry no longer appear on the NTPs of the device on which it has been dismissed
- The entry is not dismissed on the NTP of other synced device
- The entry is unchanged on the dedicated Reading List surface
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0043013229fffab3555daf28c64ee27521209d7b

commit 0043013229fffab3555daf28c64ee27521209d7b
Author: gambard <gambard@chromium.org>
Date: Tue Apr 11 14:05:38 2017

Track if a ReadingListEntry has been dismissed

This CL adds a field to the ReadingListEntry, saved only on the device, to
track if the entry has been dismissed from the NTP.
The only way to change the extra information is to use the model, allowing
the data to be stored.

BUG= 707730 

Review-Url: https://codereview.chromium.org/2806213004
Cr-Commit-Position: refs/heads/master@{#463615}

[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/proto/reading_list.proto
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_entry.cc
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_entry.h
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_entry_unittest.cc
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_model.h
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_model_impl.cc
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_model_impl.h
[modify] https://crrev.com/0043013229fffab3555daf28c64ee27521209d7b/components/reading_list/core/reading_list_model_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f978a173b3be6cb45f306ec00d666911d0ee40

commit c6f978a173b3be6cb45f306ec00d666911d0ee40
Author: gambard <gambard@chromium.org>
Date: Wed Jun 07 12:42:09 2017

Implement the swipe-to-dismiss gesture

The swipe to dismiss gesture allows the user to remove a suggestion from the
list.

BUG= 707730 

Change-Id: I89b6f8c52b8bd8fd3e49ee17436049d422dd3a78
Reviewed-on: https://chromium-review.googlesource.com/527073
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477619}
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/c6f978a173b3be6cb45f306ec00d666911d0ee40/ios/showcase/content_suggestions/sc_content_suggestions_data_source.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 61.0.3128.0 canary, iPhone 6 plus iOS 10.2.1, iPad mini 10.3 beta 7

Followed comment #4.
Looks good. 

Sign in to add a comment