[DevTools] Settings overlay gets closed after hitting Enter key when focus is on 'Remove' button.
Reported by
db...@etouch.net,
Apr 3 2017
|
|||
Issue descriptionChrome Version: 59.0.3061.0 Revision 9e03960f75b3019372157db5c4fe5264dfc36616-refs/heads/master@{#461353} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1) What steps will reproduce the problem? (1) Launch Chrome, open devtools on NTP and press F1 key to open Settings of devtools (2) Click on Workspace and add any folder,press Tab key upto focus reaches to Remove icon. (3) Then hitt Enter key and observe Actual: Settings overlay gets closed after hitting Enter key. Expected: Settings overlay should not gets closed after hitting Enter key. This is a non-regression issue, seen from M-59.0.3059.0 as Tab focus on Remove button seen from this build. Note: Issue is not seen when mouse click on Remove button.
,
Apr 6 2017
dgozman@ can you please look at this, I believe it's similar to the label bug from before. It is triggering the "_onMouseDown" (click event) in GlassPane.js for keyboard events on buttons.
,
Apr 6 2017
I think this will be fixed by https://codereview.chromium.org/2800733004/.
,
Apr 11 2017
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/63f5c5e26e2c4c9bec94a1c4f96d1c373b6471eb commit 63f5c5e26e2c4c9bec94a1c4f96d1c373b6471eb Author: Ryan Tseng <hinoka@google.com> Date: Tue Oct 10 20:43:36 2017 bot_update.py: Remove git_cache locking Makes it so it doesn't pass --ignore_locks into gclient.py and git_cache.py for the non-recipe version of bot_update because those flags are being removed. Also remove /tests/bot_update_test.py, which tries to replicate a whole bunch of services for integration test, but has been slow and currently broken. scripts/slave/unittests/bot_update_coverage_tests.py just does coverage, but is probably sufficient. Bug: 707728 Change-Id: I42644a766798fe3960938086146d4448b13bc171 Reviewed-on: https://chromium-review.googlesource.com/710078 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/63f5c5e26e2c4c9bec94a1c4f96d1c373b6471eb/PRESUBMIT.py [delete] https://crrev.com/40ab3130b4245c1c6c7db445906c412f1c1147c6/tests/bot_update_test.py [modify] https://crrev.com/63f5c5e26e2c4c9bec94a1c4f96d1c373b6471eb/scripts/slave/bot_update.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by ranjitkan@chromium.org
, Apr 3 2017