New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707713 link

Starred by 176 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 423895
issue 595803
issue 698557


Show other hotlists

Hotlists containing this issue:
Top-Starred-Bugs


Sign in to add a comment

Uneven letter spacing with Calibri on Windows

Project Member Reported by drott@chromium.org, Apr 3 2017

Issue description

There is a number of reports on uneven letter spacing with system fonts on Windows. Let's try to group those that are valid support into this meta bug. 

Also, and importantly, let's try to separate letter spacing issues from rendering mode differences issues which are or have been addressed separately in  issue 645055 ,  issue 706693 , issue skia:6421 or  issue skia:6432 .

 

Comment 1 by drott@chromium.org, Apr 3 2017

Blockedon: 423895

Comment 2 by drott@chromium.org, Apr 3 2017

Blockedon: 698557

Comment 3 by drott@chromium.org, Apr 3 2017

Blockedon: 595803

Comment 4 by drott@chromium.org, Apr 3 2017

Cc: behdad@chromium.org
I finally have a stable and easy to understand visualization for this bug:
http://roettsch.es/winspacing.html

The demo page shifts the left: CSS position for the example paragraphs by subpixel amounts. 

Tested on Windows 10:

Before our gasp-table rendering mode improvements, i.e. current Chrome stable 57: Both in the first and second paragraph there is some letter spacing polka dance going on. Cyrillic text in Arial (first paragraph), as well as text in 13px Calibri (second paragraph), expose uneven letter spacing and alternate between bad and worse letter spacing depending on subpixel position.

In the remaining paragraphs 3 and 4, we only see two subpixel rasterization alternatives, one below 0.5px shift, and one above, due to DWrite asymmetric rendering mode which does not do smoothing in x direction. 

Post gasp table improvements, Canary M59:

The issue disappears for cyrillic (first paragraph) and the third and fourth paragraphs show much better projection to the pixel grid due to the x-direction smoothing through the symmetric rendering mode that is used for them.

Still, the second paragraph with Latin text in Calibri displays the letter spacing polka.

Comment 5 by drott@chromium.org, Apr 3 2017

Some videos illustrating the letter spacing dance in Calibri. While the video compression messes with identifying subpixel differences, I believe seeing the subpixel shift in motion helps to see the spacing issue. 

spacing_stable_57.mp4
328 KB View Download
spacing_canary_59.mp4
978 KB View Download

Comment 6 by drott@chromium.org, Apr 3 2017

Blockedon: -423895

Comment 7 by drott@chromium.org, Apr 3 2017

Blockedon: 423895
Cc: kojii@chromium.org ranjitkan@chromium.org ajha@chromium.org nyerramilli@chromium.org msrchandra@chromium.org drott@chromium.org ashej...@chromium.org scottmg@chromium.org kavvaru@chromium.org kulshin@chromium.org jam@chromium.org smokana@chromium.org tkonch...@chromium.org
 Issue 423895  has been merged into this issue.

Comment 8 by drott@chromium.org, Apr 3 2017

Blockedon: -698557

Comment 9 by drott@chromium.org, Apr 3 2017

Blockedon: 698557
 Issue 698557  has been merged into this issue.
Blockedon: -595803
Blockedon: 595803
Issue 595803 has been merged into this issue.
According to https://bugzilla.mozilla.org/show_bug.cgi?id=627840 and dumping calibri.ttf using ttx, the font has bitmaps for font sizes 12, 13, 15, 16, 17, 19, which is consistent with the observation that the above example works fine (= displays the second paragraphs without wobbly spacing) at font sizes 14 and 18px.

FF has special handling for bitmap fonts and rounds the font size to full pixels, and disables subpixel positioning for them. FF developers observed that DWrite seems to use the bitmap glyphs only for CJK fonts or has some kind of blacklisting mechanism for bitmap fonts. The theory for their fix was then that the bitmap drawing improvements only need to be applied to CJK fonts as they are the only once where the bitmap glyphs are used.

However, Skia always uses the bitmap glyphs at the given sizes for Calibri, while we still do subpixel positioning, which leads to the odd spacing.

Labels: OS-Windows
Summary: Uneven letter spacing with Calibri on Windows (was: Uneven letter spacing issues on Windows)
I remember seeing this issue while writing out in email in outlook.com on a Windows 7 machine, but I won't be able to provide screenshots for a couple of months (it's my parents computer, they live very far away)

Comment 15 by drott@chromium.org, May 10 2017

Ben, I'd like to get this fixed. There is a second issue with Calibri in that ligatures formed for tt, fl, fi etc. for example start to appear bold, compare
https://bugzilla.redhat.com/show_bug.cgi?id=857860

So at least for Calibri (or perhaps for non-CJK in general?) I would like to disable using the embedded bitmaps. Can we have an interface on SkTypeface for that? 

Alternatively, we could try to round font sizes to nearest bitmap size, compare https://hg.mozilla.org/mozilla-central/rev/e0c9841ac3dd - but that still would not fix the ligatures issue.

Thanks for taking a look.
please see attached screenshot: is it possible this spacing issue is also 'squishing' letters or is there something else causing that? look at the lower case C (red arrows are pointing to it). And on the left you can compare it to text in Firefox
05f2917f-d868-4ebc-a6e2-792d79d4d039.png
113 KB View Download
Yes, text rendering in Firefox on Windows, it is the standard of quality to which one should strive.
drott@, it looks like you are actively working on this issue. Is that the case? Could you please update with the current plan? As part of predictability program, we have an OKR to get resolution or a concrete plan in place for the highest starred bugs in Blink and this one is #6 on the list.

Comment 19 by drott@chromium.org, May 29 2017

That's the case but I need to sync with Ben on the Skia team on how we tackle this issue. Most likely, the approach will be to try and avoid bitmap glyphs in mixed bitmap/TrueType-outline fonts for non CJK languages. 

Comment 20 by drott@chromium.org, Jun 13 2017

I discussed with Ben: As a first step Blink can use the setEmbeddedBitmapText() setting on SkPaint, for example hardcoded for the Calibri font for now or for fonts that do not have CJK glyph coverage. 

The better fix would be to detect the bitmap glyph sizes range in the font and avoid subpixel font sizes for those, but I am not sure it's worthwhile doing this.

There might also be benefit in Skia adjusting font sizes automatically to the nearest bitmap strike size, but that requires more investigation.

I'll try to upload a Blink side CL this week. 

Comment 21 by drott@chromium.org, Aug 10 2017

I've started to investigate the effects of setEmbeddedBitmapText() and I am observing a somewhat odd behavior. Usually our SkPaint settings on Windows are subpixel and lcdtext flags are on. Embeddedbitmaptext is left to default, so probably it's on. So far, I am only looking at integer pixel sizes, e.g. 16 (bitmap strikes available) or 18px (no bitmap strikes available).

Strangely, when subpixel and embeddedbitmaptext flags are set to 'on' on SkPaint, painting text on canvas at pixel sizes for which Calibri does have bitmap glyphs, Skia paints with RGB antialiased glyphs and does not seem to use the bitmaps, but subpixel positioning is broken, or in other words, only one variant/RGB-version of each glyph is used, which leads to the uneven letter spacing, and to "dancing letters" in the winspacing.html test above.

When the embeddedbitmap flag is off, but subpixel is on, spacing is correct, multiple RGB antialiased glyph variants are used.

Same, when painted at sizes where there is no bitmap strike available, for example 18ppem, then subpixel positioning works, multiple RGB subpixel variants of the glyphs are used.

I believe I am able to reproduce this in the Blink context, as well with a quick test using: https://skia-review.googlesource.com/c/33240

In the first painted block, spacing is okay, multiple variants of RGB antialiased glyphs are used.

In the second painted block, spacing is off, some groups of o's and m's have uneven spacing, e.g. one o/m looks closer to the left than the right or vice versa and only one subpixel variant is used. Note: No bitmap glyphs are used.

In my opinion, this behavior of the SkCanvas/SkPaint text painting API is somewhat surprising. Either bitmap glyphs should be used (and Blink as the client should probably round advances for drawTextPosH or drawBlob), or they should not in the case of the embeddedbitmap flag being off, but then fully RGB antialiased glyph variants should be used, and subpixel painting should not be broken.


Project Member

Comment 22 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e52a0d6a39b417147357baca123b8281fa3d1431

commit e52a0d6a39b417147357baca123b8281fa3d1431
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Oct 05 10:23:16 2017

Avoid using bitmap glyphs for blacklisted fonts

The Calibri Windows font has bitmap strikes for sizes 12, 13, 15, 16,
17, 19. When this font is drawn while using subpixel positioning, letter
spacing becomes wonky: Skia/DWrite are not using multiple subpixel
aliased glyph versions. Usually, with subpixel positioning and
antialiasing 3 or 4 versions of an antialiased glyph exist with
different shading and color filtering. Here, only one antialiased glyph
variant is used, which is placed at full pixel boundaries. For bitmap
strike font sizes Skia/DWrite now rounds the glyph positions within the
text to full pixel positions to place this one glyph variant. The result
is that the letter spacing becomes uneven, whith glyphs moving closer or
further away from each other when the horizontal subpixel offset is
changed [1].

As a mitigation of this problem, disable the usage of embedded bitmap
strikes for Calibri for now. We have not encountered any other non CJK
script fonts that would expose bitmap _and_ vector outline glyphs.

The setEmbeddedBitmapText flag of SkPaint mostly controls what to do
with fonts that have outlines and embedded bitmaps.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=707713#c5
[2] https://hg.mozilla.org/mozilla-central/rev/c93381b53df3

Bug:  707713 
Change-Id: Iae81803ece1ada49e363ff46e0e06df3a26dbcde
Reviewed-on: https://chromium-review.googlesource.com/623672
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506693}
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/001-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/009-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/013-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/generic-family-changes-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/emoticons-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/international/unicode-bidi-plaintext-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/large-text-composed-char-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/selection-hard-linebreak-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/wbr-pre-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/wbr-styled-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/001-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/023-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/024-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/029-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/030-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-newline-box-test-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-wrap-overflow-selection-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win/fast/text/word-break-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/013-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/generic-family-changes-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/emoticons-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/khmer-selection-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/unicode-bidi-plaintext-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/large-text-composed-char-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/selection-hard-linebreak-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/wbr-pre-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/wbr-styled-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/001-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/019-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/022-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/023-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/024-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/029-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/030-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-newline-box-test-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-wrap-overflow-selection-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/LayoutTests/platform/win7/fast/text/word-break-expected.png
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklist.cpp
[add] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklist.h
[add] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklistTest.cpp
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/e52a0d6a39b417147357baca123b8281fa3d1431/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5

commit 4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Oct 05 13:39:44 2017

Missing baselines for "Avoid using bitmap glyphs for blacklisted fonts"

Baseline fixes for CL landed in e52a0d6a39b417147357baca123b8281fa3d1431

NOTRY=TRUE
TBR=tnagel

Bug:  707713 
Change-Id: Ic146c44d36f62445abb7ef6702031848e779f898
Reviewed-on: https://chromium-review.googlesource.com/702480
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506714}
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/001-expected.png
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/generic-family-reset-expected.png
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win/fast/text/international/khmer-selection-expected.png
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/019-expected.png
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/009-expected.png
[modify] https://crrev.com/4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/generic-family-reset-expected.png

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db19870f1433d0d30434b9a4d24c08952462b8da

commit db19870f1433d0d30434b9a4d24c08952462b8da
Author: James MacLean <wjmaclean@chromium.org>
Date: Thu Oct 05 14:17:26 2017

Revert "Avoid using bitmap glyphs for blacklisted fonts"

This reverts commit e52a0d6a39b417147357baca123b8281fa3d1431.

Reason for revert: This CL looks to be causing a lot of carnage on the WebKit layout tests on various bots.

Original change's description:
> Avoid using bitmap glyphs for blacklisted fonts
> 
> The Calibri Windows font has bitmap strikes for sizes 12, 13, 15, 16,
> 17, 19. When this font is drawn while using subpixel positioning, letter
> spacing becomes wonky: Skia/DWrite are not using multiple subpixel
> aliased glyph versions. Usually, with subpixel positioning and
> antialiasing 3 or 4 versions of an antialiased glyph exist with
> different shading and color filtering. Here, only one antialiased glyph
> variant is used, which is placed at full pixel boundaries. For bitmap
> strike font sizes Skia/DWrite now rounds the glyph positions within the
> text to full pixel positions to place this one glyph variant. The result
> is that the letter spacing becomes uneven, whith glyphs moving closer or
> further away from each other when the horizontal subpixel offset is
> changed [1].
> 
> As a mitigation of this problem, disable the usage of embedded bitmap
> strikes for Calibri for now. We have not encountered any other non CJK
> script fonts that would expose bitmap _and_ vector outline glyphs.
> 
> The setEmbeddedBitmapText flag of SkPaint mostly controls what to do
> with fonts that have outlines and embedded bitmaps.
> 
> [1] https://bugs.chromium.org/p/chromium/issues/detail?id=707713#c5
> [2] https://hg.mozilla.org/mozilla-central/rev/c93381b53df3
> 
> Bug:  707713 
> Change-Id: Iae81803ece1ada49e363ff46e0e06df3a26dbcde
> Reviewed-on: https://chromium-review.googlesource.com/623672
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506693}

TBR=bungeman@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,behdad@chromium.org

Change-Id: I278899fb8cc929e0e08390b3c7b0a5a1b2289e9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  707713 
Reviewed-on: https://chromium-review.googlesource.com/702494
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506720}
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/009-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/013-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/generic-family-changes-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/emoticons-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/international/unicode-bidi-plaintext-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/large-text-composed-char-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/selection-hard-linebreak-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/wbr-pre-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/wbr-styled-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/001-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/023-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/024-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/029-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/030-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-newline-box-test-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-wrap-overflow-selection-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win/fast/text/word-break-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/013-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/generic-family-changes-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/emoticons-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/khmer-selection-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/unicode-bidi-plaintext-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/large-text-composed-char-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/selection-hard-linebreak-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/wbr-pre-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/wbr-styled-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/001-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/019-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/022-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/023-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/024-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/029-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/030-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-newline-box-test-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-wrap-overflow-selection-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/LayoutTests/platform/win7/fast/text/word-break-expected.png
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/fdac6853113863b7f6486781c465c8193b1c8ed9/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklist.cpp
[delete] https://crrev.com/fdac6853113863b7f6486781c465c8193b1c8ed9/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklist.h
[delete] https://crrev.com/fdac6853113863b7f6486781c465c8193b1c8ed9/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklistTest.cpp
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/db19870f1433d0d30434b9a4d24c08952462b8da/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp

Project Member

Comment 25 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f820527ed71a8dcfe48096818d3f0140621fad72

commit f820527ed71a8dcfe48096818d3f0140621fad72
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Oct 05 14:29:03 2017

Revert "Missing baselines for "Avoid using bitmap glyphs for blacklisted fonts""

This reverts commit 4835d56dc1ce67faf3dad73f18ce045e9ebaf1d5.

Reason for revert: Original CL got reverted due to redness.

Original change's description:
> Missing baselines for "Avoid using bitmap glyphs for blacklisted fonts"
> 
> Baseline fixes for CL landed in e52a0d6a39b417147357baca123b8281fa3d1431
> 
> NOTRY=TRUE
> TBR=tnagel
> 
> Bug:  707713 
> Change-Id: Ic146c44d36f62445abb7ef6702031848e779f898
> Reviewed-on: https://chromium-review.googlesource.com/702480
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506714}

TBR=tnagel@chromium.org,drott@chromium.org

Change-Id: I9f849efc328182da71f41b9e788492ca81afb29a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  707713 
Reviewed-on: https://chromium-review.googlesource.com/701759
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506723}
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/001-expected.png
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/generic-family-reset-expected.png
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win/fast/text/international/khmer-selection-expected.png
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/019-expected.png
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/009-expected.png
[modify] https://crrev.com/f820527ed71a8dcfe48096818d3f0140621fad72/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/generic-family-reset-expected.png

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d93a42a2c8e7f5347524a97935e7b89251c48bca

commit d93a42a2c8e7f5347524a97935e7b89251c48bca
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Oct 05 19:46:00 2017

Fix baseline for fast/text/basic/001.html

The original correct baseline got lost in the shuffle of
a series of colliding reverts. This restores the file to its
state prior to the (now reverted) r506693.

TBR=drott@chromium.org
TBR=eae@chromium.org

Bug:  707713 
Change-Id: I0f15bc1c4b01ad5972d30e86f3d47b13183fffaa
Reviewed-on: https://chromium-review.googlesource.com/703354
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506830}
[modify] https://crrev.com/d93a42a2c8e7f5347524a97935e7b89251c48bca/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/001-expected.png

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95

commit a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Oct 06 14:55:17 2017

Reland: Avoid using bitmap glyphs for blacklisted fonts

Additional baselines from the main waterfall added.
Previously reviewed in:
https://chromium-review.googlesource.com/c/chromium/src/+/623672

Sheriffs, if you see any redness on Windows bots related to
letterspacing of the the sans-serif Calibri or the monospaced Courier
New fonts, please mark those as NeedsRebaseline and assign them to me
instead of reverting, if possible. Thanks!

The Calibri Windows font has bitmap strikes for sizes 12, 13, 15, 16,
17, 19. When this font is drawn while using subpixel positioning, letter
spacing becomes wonky: Skia/DWrite are not using multiple subpixel
aliased glyph versions. Usually, with subpixel positioning and
antialiasing 3 or 4 versions of an antialiased glyph exist with
different shading and color filtering. Here, only one antialiased glyph
variant is used, which is placed at full pixel boundaries. For bitmap
strike font sizes Skia/DWrite now rounds the glyph positions within the
text to full pixel positions to place this one glyph variant. The result
is that the letter spacing becomes uneven, whith glyphs moving closer or
further away from each other when the horizontal subpixel offset is
changed [1].

As a mitigation of this problem, disable the usage of embedded bitmap
strikes for Calibri for now. We have not encountered any other non CJK
script fonts that would expose bitmap _and_ vector outline glyphs.

The setEmbeddedBitmapText flag of SkPaint mostly controls what to do
with fonts that have outlines and embedded bitmaps.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=707713#c5
[2] https://hg.mozilla.org/mozilla-central/rev/c93381b53df3

Bug:  707713 
Change-Id: I3e11df05fab9b0fdc465c97c4b2f7579b5403723
Tbr: eae, kojii
Reviewed-on: https://chromium-review.googlesource.com/702422
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507066}
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/009-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/013-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/generic-family-changes-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/basic/generic-family-reset-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/emoticons-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/international/khmer-selection-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/international/unicode-bidi-plaintext-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/large-text-composed-char-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/selection-hard-linebreak-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/wbr-pre-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/wbr-styled-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/001-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/019-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/023-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/024-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/029-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/030-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-newline-box-test-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-wrap-overflow-selection-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win/fast/text/word-break-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/009-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/013-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/generic-family-changes-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/basic/generic-family-reset-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/emoticons-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/khmer-selection-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/unicode-bidi-plaintext-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/large-text-composed-char-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/selection-hard-linebreak-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/wbr-pre-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/wbr-styled-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/001-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/019-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/022-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/023-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/024-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/029-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/030-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-newline-box-test-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-wrap-overflow-selection-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/LayoutTests/platform/win7/fast/text/word-break-expected.png
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklist.cpp
[add] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklist.h
[add] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/BitmapGlyphsBlacklistTest.cpp
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/a4eab4fa86aa0f2a0be6ef7234687b70c7a02f95/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp

Status: Fixed (was: Started)
This seems to stick now.

Sign in to add a comment