LayerTreeHostTilesTestPartialInvalidation.* is flaky |
|||||||||||||||
Issue description"LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVgsSBUZsYWtlIktMYXllclRyZWVIb3N0VGlsZXNUZXN0UGFydGlhbEludmFsaWRhdGlvbi5QYXJ0aWFsUmFzdGVyX011bHRpVGhyZWFkX09uZUNvcHkM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 4 2017
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be9ef6cdb1aaed6104620f951b0f336ae30d6c6d commit be9ef6cdb1aaed6104620f951b0f336ae30d6c6d Author: maxmorin <maxmorin@chromium.org> Date: Tue Apr 04 13:49:24 2017 Disable flaky {Full,Partial}Raster_MultiThread_OneCopy. See e.g. https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20(1)/builds/34778. TBR=enne@chromium.org BUG=707711 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2797473004 Cr-Commit-Position: refs/heads/master@{#461699} [modify] https://crrev.com/be9ef6cdb1aaed6104620f951b0f336ae30d6c6d/cc/trees/layer_tree_host_pixeltest_tiles.cc
,
Apr 4 2017
,
May 9 2017
Running this locally on Linux with release asan netted me two failures in LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster
--snip--
set -e
ninja -C out/gasan cc_unittests -j500 -l20
while true; do
out/gasan/cc_unittests --gtest_filter=*LayerTreeHostTilesTestPartialInvalidation.*
done
--snip--
Error #1 (pixels attached as images below)
[ RUN ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster
[21858:21924:0509/105051.573894:2408701337206:ERROR:gles2_cmd_decoder.cc(7783)] [.GpuRasterization]GL ERROR :GL_INVALID_OPERATION : glFramebufferTexture2D: unknown texture_ref
[21858:22222:0509/105051.575345:2408701338663:ERROR:gpu_raster_buffer_provider.cc(54)] Failed to allocate raster surface
[21858:21858:0509/105052.062227:2408701825546:ERROR:pixel_comparator.cc(47)] Number of pixel with an error: 30000
[21858:21858:0509/105052.062360:2408701825666:ERROR:pixel_comparator.cc(48)] Error Bounding Box : 0,0 200x200
[21858:21858:0509/105052.085300:2408701848619:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
../../cc/test/layer_tree_pixel_test.cc:117: Failure
Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
Actual: false
Expected: true
[ FAILED ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster (597 ms)
Error #2 (pixels the same as above)
[ RUN ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster
[24226:24296:0509/105106.024943:2408715788256:ERROR:gles2_cmd_decoder.cc(7783)] [.GpuRasterization]GL ERROR :GL_INVALID_OPERATION : glFramebufferTexture2D: unknown texture_ref
[24226:24611:0509/105106.025226:2408715788543:ERROR:gpu_raster_buffer_provider.cc(54)] Failed to allocate raster surface
[24226:24296:0509/105106.104554:2408715867864:ERROR:gles2_cmd_decoder.cc(7790)] [.GpuRasterization]GL ERROR :GL_INVALID_OPERATION : glFramebufferTexture2D: Attachment textarget doesn't match texture target
[24226:24611:0509/105106.104744:2408715868046:ERROR:gpu_raster_buffer_provider.cc(54)] Failed to allocate raster surface
[24226:24226:0509/105106.437862:2408716201180:ERROR:pixel_comparator.cc(47)] Number of pixel with an error: 30000
[24226:24226:0509/105106.438000:2408716201306:ERROR:pixel_comparator.cc(48)] Error Bounding Box : 0,0 200x200
[24226:24226:0509/105106.460812:2408716224128:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
../../cc/test/layer_tree_pixel_test.cc:117: Failure
Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
Actual: false
Expected: true
[ FAILED ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster (510 ms)
,
May 9 2017
ericrk suggests that the original bug here may have been fixed by the ForceReclaimResources patch reland.
,
May 10 2017
Filed issue 720530 for comment #6. I ran this in a bunch of instances simultaneously and wasn't able to get this to repro. I am going to tentatively turn this back on.
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05bbc16200b82e786110bd6ff3592fd29d4edf68 commit 05bbc16200b82e786110bd6ff3592fd29d4edf68 Author: Adrienne Walker <enne@chromium.org> Date: Wed May 10 20:00:19 2017 cc: Turn on PartialRaster_MultiThread_OneCopy test LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy was marked flaky a month ago by chromium-try-flakes. I attempted to repro this locally but was unable to (and found other flakes while doing so). Tentatively turning this back on. Bug: 707711 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I07305f2dd3401cb2ff7343c4fde1d4158b73f856 Reviewed-on: https://chromium-review.googlesource.com/501472 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#470680} [modify] https://crrev.com/05bbc16200b82e786110bd6ff3592fd29d4edf68/cc/trees/layer_tree_host_pixeltest_tiles.cc
,
May 10 2017
Leaving this open to fish for flakes.
,
May 10 2017
Issue 703279 has been merged into this issue.
,
May 18 2017
Ok, looks like this is still flaky then, and not just LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_GpuRaster. I was unable to get anything but that to fail and it does appear that this hasn't flaked on try jobs since I turned it back on. I'll leave this open then. If anybody else has time to investigate, please do. I was unable to repro the non-gpu raster version failures locally.
,
Oct 13 2017
,
Oct 13 2017
,
Oct 13 2017
Issue 767080 has been merged into this issue.
,
Nov 15 2017
,
Feb 26 2018
,
Aug 3
Detected 4 new flakes for test/step "LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVgsSBUZsYWtlIktMYXllclRyZWVIb3N0VGlsZXNUZXN0UGFydGlhbEludmFsaWRhdGlvbi5QYXJ0aWFsUmFzdGVyX011bHRpVGhyZWFkX09uZUNvcHkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 10
Reporting to stale-flakes-reports@google.com to investigate why this issue is not being processed despite being in an appropriate queue for 7 days or more.
,
Aug 15
,
Aug 21
Issue 876190 has been merged into this issue.
,
Aug 21
Issue 876190 has LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy and MultiThread both failing. The result is that it looks like the staging buffer isn't found and it's doing a full raster instead of a partial raster. There's already a finish inside of WillPrepareTilesOnThread, so I'm not sure what else we need to add here to verify that the previous staging buffer is ready.
,
Aug 21
Detected 3 new flakes for test/step "LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVgsSBUZsYWtlIktMYXllclRyZWVIb3N0VGlsZXNUZXN0UGFydGlhbEludmFsaWRhdGlvbi5QYXJ0aWFsUmFzdGVyX011bHRpVGhyZWFkX09uZUNvcHkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 22
Disabling LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy on Linux TSAN due to flakiness.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1830d47f6f9a05aace48f1ea16112953b42dbfb6 commit 1830d47f6f9a05aace48f1ea16112953b42dbfb6 Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Aug 22 11:37:07 2018 Disable LayerTreeHostTilesTestPartialInvalidation.PartialRaster_MultiThread_OneCopy This test is flaky on Linux TSAN. TBR: enne@chromium.org Bug: 707711 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88e4510fd3fc151de8f69b5b9632e6d5709ccd81 Reviewed-on: https://chromium-review.googlesource.com/1184845 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#584986} [modify] https://crrev.com/1830d47f6f9a05aace48f1ea16112953b42dbfb6/cc/trees/layer_tree_host_pixeltest_tiles.cc |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by anthonyvd@chromium.org
, Apr 3 2017