New issue
Advanced search Search tips

Issue 707692 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7% regression in memory.desktop at 460616:460691

Project Member Reported by ulan@google.com, Apr 3 2017

Issue description

See the link to graphs below.
 

Comment 1 by ulan@google.com, Apr 3 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=707692

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnObi_ggM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel

=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Error: INFRA_FAILURE

The bisect was able to narrow the range, you can try running with:
  good_revision: ca0c42f15513945c221387f203b8521143612be1
  bad_revision : b9058f285cf483b7c49fe46e554f55f54ffeb956

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : memory.desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg

Revision             Result                  N
chromium@460615      3306465 +- 35.4307      6      good
chromium@460620      3306462 +- 49.9333      6      good
chromium@460622      3365412 +- 58.5392      6      bad
chromium@460623      3365401 +- 69.3782      6      bad
chromium@460625      3365414 +- 47.464       6      bad
chromium@460634      3365438 +- 32.6726      6      bad
chromium@460653      3365421 +- 41.0284      6      bad
chromium@460691      3362444 +- 18.6369      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983351481983546864

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6342060841369600


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by u...@chromium.org, May 12 2017

Labels: Performance-Sheriff-V8
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 21 2017

Labels: Hotlist-Google
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jul 25 2017

Cc: ca...@igalia.com
Owner: ca...@igalia.com

=== Auto-CCing suspected CL author caitp@igalia.com ===

Hi caitp@igalia.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Caitlin Potter
  Commit : bf463c4dc080abb1ae39c6f0a93e6a95867b0ca3
  Date   : Wed Mar 29 17:33:12 2017
  Subject: [async-iteration] implement AsyncGenerator

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : memory.desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg
  Change       : 1.74% | 3384265.66667 -> 3443172.66667

Revision                           Result                  N
chromium@460528                    3384266 +- 93.077       6      good
chromium@460580                    3384243 +- 31.4006      6      good
chromium@460606                    3384255 +- 50.3074      6      good
chromium@460619                    3384241 +- 45.1756      6      good
chromium@460620                    3384256 +- 36.8511      6      good
chromium@460620,v8@6234fda3c9      3384057 +- 52.8851      6      good
chromium@460620,v8@bf463c4dc0      3456732 +- 24399.6      6      bad       <--
chromium@460620,v8@367d646a9e      3443688 +- 69.4934      6      bad
chromium@460620,v8@5615e5b866      3442972 +- 32.6113      6      bad
chromium@460621                    3443191 +- 39.3362      6      bad
chromium@460622                    3443186 +- 84.211       6      bad
chromium@460625                    3443185 +- 68.712       6      bad
chromium@460631                    3443173 +- 34.3705      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8973097048954163744


For feedback, file a bug with component Speed>Bisection

Comment 8 by ca...@igalia.com, Jul 25 2017

Status: WontFix (was: Assigned)
there is an expected growth in snapshot size here, which affects memory used for each v8 isolate. This regression is, I think, within the expected range.

Historically, these have been marked as WontFix. Sorry for wasting sheriff time here.

Sign in to add a comment