New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707689 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

shapedetection/detection-* flakily crashing everywhere

Project Member Reported by timloh@chromium.org, Apr 3 2017

Issue description

Looks like shapedetection/detection-HTMLCanvasElement.html is flakily crashing on all platforms. I'm guessing it started when https://codereview.chromium.org/2765723002 landed.

crash log for renderer (pid <unknown>):
STDOUT: #CRASHED - renderer
STDERR: [11864:11934:0403/000343.911594:1307112694:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
STDERR: [11864:11934:0403/000343.911710:1307112808:WARNING:url_request_job_manager.cc(90)] Failed to map: layout-test-mojom://content/shell/renderer/layout_test/interface_registry
STDERR: [1:1:0403/000343.917112:1307118354:ERROR:mojo_context_state.cc(209)] Failed to fetch source for module "content/shell/renderer/layout_test/frame_interface_registry"
STDERR: [1:1:0403/000343.917326:1307118466:ERROR:mojo_context_state.cc(209)] Failed to fetch source for module "content/shell/renderer/layout_test/interface_registry"
STDERR: [1:1:0403/000344.157484:1307358657:FATAL:waiting_callback.cc(82)] Check failed: gin::ConvertFromV8(isolate, hidden_value, &callback). 
STDERR: #0 0x00000155cdc7 base::debug::StackTrace::StackTrace()
STDERR: #1 0x00000156e74b logging::LogMessage::~LogMessage()
STDERR: #2 0x00000331edbc mojo::edk::js::WaitingCallback::OnHandleReady()
STDERR: #3 0x00000171192a mojo::SimpleWatcher::OnHandleReady()
STDERR: #4 0x0000015d3540 base::debug::TaskAnnotator::RunTask()
STDERR: #5 0x000002212788 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
STDERR: #6 0x000002210cc8 blink::scheduler::TaskQueueManager::DoWork()
STDERR: #7 0x0000015d3540 base::debug::TaskAnnotator::RunTask()
STDERR: #8 0x00000157354d base::MessageLoop::RunTask()
STDERR: #9 0x000001573868 base::MessageLoop::DeferOrRunPendingTask()
STDERR: #10 0x000001573d96 base::MessageLoop::DoWork()
STDERR: #11 0x000001574d3a base::MessagePumpDefault::Run()
STDERR: #12 0x000001573277 base::MessageLoop::RunHandler()
STDERR: #13 0x00000158c6ce base::RunLoop::Run()
STDERR: #14 0x0000031d0550 content::RendererMain()
STDERR: #15 0x000001022d5a content::RunZygote()
STDERR: #16 0x000001023acc content::ContentMainRunnerImpl::Run()
STDERR: #17 0x0000020ac65f service_manager::Main()
STDERR: #18 0x0000007003a2 content::ContentMain()
STDERR: #19 0x00000043d421 main
STDERR: #20 0x7fa4143e7ec5 __libc_start_main
STDERR: #21 0x00000043d2fd <unknown>

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=shapedetection%2Fdetection-HTMLCanvasElement.html

Going to disable this test for now...
 
Summary: shapedetection/detection-HTMLCanvasElement.html flakily crashing everywhere (was: shapedetection/detection-HTMLCanvasElement.html crashing everywhere)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d96da3328608d15036eb4531e4ef62a7e583fc8

commit 3d96da3328608d15036eb4531e4ef62a7e583fc8
Author: timloh <timloh@chromium.org>
Date: Mon Apr 03 09:13:35 2017

Skip flakily crashing shapedetection/detection-HTMLCanvasElement.html

TBR=mcasas@chromium.org
BUG= 707689 

Review-Url: https://codereview.chromium.org/2792933002
Cr-Commit-Position: refs/heads/master@{#461390}

[modify] https://crrev.com/3d96da3328608d15036eb4531e4ef62a7e583fc8/third_party/WebKit/LayoutTests/TestExpectations

Status: Assigned (was: Untriaged)
Cc: xianglu@chromium.org
 Issue 707137  has been merged into this issue.
Labels: -Pri-3 OS-All Pri-2
Summary: shapedetection/detection-* flakily crashing everywhere (was: shapedetection/detection-HTMLCanvasElement.html flakily crashing everywhere)
I can repro randomly on my Linux when running a given set
of html LayoutTests in sequence, but haven't found the root cause yet.
Status: Started (was: Assigned)
I'm running

third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn shapedetection/*.html --verbose  --repeat-each=20 --order=random 

on master and on a side branch where I reverted 

https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59
https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8

(https://crrev.com/2771703002 and https://crrev.com/2629433003, resp.)

and it seems like reverting those two fixes the flake, but
otherwise I'm not sure what's happening here.
log.branch.txt
9.0 KB View Download
log.master.txt
9.5 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f

commit 7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f
Author: mcasas <mcasas@chromium.org>
Date: Thu Apr 06 21:58:38 2017

REVERT: ShapeDetection: use mojom::Bitmap for mojo interface.

This CL reverts two landed CLs, namely:

https://chromium.googlesource.com/chromium/src.git/+/f59872240739c45017e90aa1be20548177d6df59
https://chromium.googlesource.com/chromium/src.git/+/11a82c3aaabd39fc3a0981a6e66bf870cc46d5e8

(reviewed in https://crrev.com/2771703002 and
https://crrev.com/2765723002, resp.), because they
seemed to have introduced a flake in the associated
LayoutTests.

TBR=rockot@chromium.org, dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com, tsepez@chromium.org

BUG= 665488 ,  707689 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2799153005
Cr-Commit-Position: refs/heads/master@{#462639}

[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/AUTHORS
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/chrome/android/BUILD.gn
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/BarcodeDetectionImpl.java
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/chrome/android/java/src/org/chromium/chrome/browser/shapedetection/TextDetectionImpl.java
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/content/public/android/BUILD.gn
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/DEPS
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/barcode_detection_impl_mac.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/barcode_detection_impl_mac.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/barcode_detection_impl_mac_unittest.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/detection_utils_mac.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/detection_utils_mac.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/face_detection_impl_mac.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/face_detection_impl_mac_unittest.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/BUILD.gn
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/barcodedetection.mojom
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/facedetection.mojom
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/public/interfaces/textdetection.mojom
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/text_detection_impl_mac.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/text_detection_impl_mac.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/services/shape_detection/text_detection_impl_mac_unittest.mm
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/BUILD.gn
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/DEPS
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[modify] https://crrev.com/7f2e5dcdcecc501ddf56396c2846d3ebfe4fa46f/third_party/WebKit/Source/modules/shapedetection/TextDetector.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b0f0765add212a66e9b80928278abf473f2acb3

commit 2b0f0765add212a66e9b80928278abf473f2acb3
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Apr 12 20:26:20 2017

Prevent gin from recreating wrappers after GC

This changes gin::Wrappable to track its cleanup
state in order to prevent async operations from
recreating a wrapper between first and second weak
callbacks.

GetWrapper is changed to return a MaybeLocal,
and callers are updated accordingly; checking
in some cases and failing gracefully in others.

Mojo JS's WaitingCallback is changed to silently
ignore handle notifications if its wrapper is
no longer alive.

BUG= 707689 

Change-Id: I3fc11a24209f0ef35bfa18556f5734c4b18ae229
Reviewed-on: https://chromium-review.googlesource.com/475077
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464134}
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/extensions/renderer/api_binding_bridge.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/extensions/renderer/chrome_setting.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/converter.h
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/handle.h
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/interceptor_unittest.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/modules/timer.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/modules/timer_unittest.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/wrappable.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/wrappable.h
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/gin/wrappable_unittest.cc
[modify] https://crrev.com/2b0f0765add212a66e9b80928278abf473f2acb3/mojo/edk/js/waiting_callback.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb89503baf314afded40d6517c8e6e18f1f89b6b

commit bb89503baf314afded40d6517c8e6e18f1f89b6b
Author: junwei.fu <junwei.fu@intel.com>
Date: Fri Apr 21 11:35:36 2017

Ignore fired timer if the object wrapper is no longer alive

CL [1] has prevented gin from recreating wrappers after GC,
so doesn't fire timer if its wrapper is empty otherwise it will
be crashed.

[1] https://chromium-review.googlesource.com/475077

BUG= 707689 

Review-Url: https://codereview.chromium.org/2830723003
Cr-Commit-Position: refs/heads/master@{#466314}

[modify] https://crrev.com/bb89503baf314afded40d6517c8e6e18f1f89b6b/AUTHORS
[modify] https://crrev.com/bb89503baf314afded40d6517c8e6e18f1f89b6b/gin/modules/timer.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6b49242db9774de7370bd302ffe97d090f85b9

commit 7f6b49242db9774de7370bd302ffe97d090f85b9
Author: mcasas <mcasas@chromium.org>
Date: Wed May 03 14:53:30 2017

Shape Detection: reconnect LayoutTests

These tests were marked as flaky/crashy but after the revert in
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c7
and the extra CLs
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c8
and
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c9

we should be good again, so let's reconnect these tests and
monitor
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=shapedetection%2F

BUG= 707689 

Review-Url: https://codereview.chromium.org/2857803002
Cr-Commit-Position: refs/heads/master@{#468970}

[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input-expected.txt
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/http/tests/shapedetection/shapedetection-cross-origin-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-HTMLCanvasElement-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-HTMLImageElement-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-HTMLVideoElement-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-ImageBitmap-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-ImageData-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/shapedetection/detection-security-test-expected.txt
[delete] https://crrev.com/eb6bd1966e3d4605bb8cc911764889ebf0597129/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/shapedetection/shapedetection-cross-origin-expected.txt
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
[modify] https://crrev.com/7f6b49242db9774de7370bd302ffe97d090f85b9/third_party/WebKit/LayoutTests/shapedetection/detection-security-test.html

Labels: M-60
Status: Fixed (was: Started)
Monitoring the tests in [1] I only see green so we're back to a 
good situation, and one that allows us to see if landed changes
break anything in any obscure bot, so marking this issue as Fixed.


[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=shapedetection%2F
Project Member

Comment 12 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3324464e62044d7d8cfdac18bac1fcb2835cc6ff

commit 3324464e62044d7d8cfdac18bac1fcb2835cc6ff
Author: junwei.fu <junwei.fu@intel.com>
Date: Mon May 29 11:09:48 2017

ShapeDetection: Make sure tests are running serially

There could be more than one MockFaceDetection association with the same
MockFaceDetectionProvider, the first mock service is random Gcd in same
context, so ensure these tests run serially.

BUG= 707689 

Review-Url: https://codereview.chromium.org/2818563006
Cr-Commit-Position: refs/heads/master@{#475335}

[modify] https://crrev.com/3324464e62044d7d8cfdac18bac1fcb2835cc6ff/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
[modify] https://crrev.com/3324464e62044d7d8cfdac18bac1fcb2835cc6ff/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js

Comment 13 by tzik@chromium.org, Jun 27 2017

Issue 737024 has been merged into this issue.

Sign in to add a comment