New issue
Advanced search Search tips

Issue 707661 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707638



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in platform/wtf

Project Member Reported by tkent@chromium.org, Apr 3 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/wtf.
 
Owner: hs1217....@samsung.com
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/177d44c2b478ca96d5cff47940509b578e4af697

commit 177d44c2b478ca96d5cff47940509b578e4af697
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Mon Apr 24 17:37:51 2017

Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf

Replace RELEASE_ASSERT, and ASSERT_NOT_REACHED
with CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/wtf.

BUG= 707661 

Review-Url: https://codereview.chromium.org/2833123002
Cr-Commit-Position: refs/heads/master@{#466672}

[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/Deque.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/HashTable.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/StackUtil.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/TerminatedArrayBuilder.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/Vector.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/WTF.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/allocator/Partitions.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/dtoa/utils.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/AtomicStringTable.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/CString.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/StringConcatenate.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/StringImpl.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/StringOperators.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/text/WTFString.cpp
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBuffer.h
[modify] https://crrev.com/177d44c2b478ca96d5cff47940509b578e4af697/third_party/WebKit/Source/platform/wtf/typed_arrays/TypedArrayBase.h

Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cf75135e125604870a9eb91e4178ba18398d8f3

commit 0cf75135e125604870a9eb91e4178ba18398d8f3
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Tue May 09 04:12:41 2017

Replace ASSERT with DHCECK_op in platform/wtf

Replace ASSERT with DCHECK_op respectively
in third_party/WebKit/Source/platform/wtf

BUG= 707661 

Review-Url: https://codereview.chromium.org/2839663003
Cr-Commit-Position: refs/heads/master@{#470188}

[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/cached-powers.cc
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.cc
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc
[modify] https://crrev.com/0cf75135e125604870a9eb91e4178ba18398d8f3/third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc

Status: Fixed (was: Started)

Sign in to add a comment