New issue
Advanced search Search tips

Issue 707660 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707638



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in platform/text

Project Member Reported by tkent@chromium.org, Apr 3 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/text.
 
Owner: hs1217....@samsung.com
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5

commit 28d7e2fdd0bb11a7d0061b60ee1664728ce869d5
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Tue Apr 11 07:54:39 2017

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/text.

BUG= 707660 

Review-Url: https://codereview.chromium.org/2811453002
Cr-Commit-Position: refs/heads/master@{#463569}

[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/BidiCharacterRun.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/BidiContext.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/BidiContext.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/BidiResolver.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/BidiRunList.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/Character.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/DateTimeFormat.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/DecodeEscapeSequences.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/LocaleICU.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/LocaleMac.mm
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/LocaleWin.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/PlatformLocale.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/SegmentedString.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/SegmentedString.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/StringTruncator.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/SuffixTree.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/TextBreakIterator.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/TextRun.h
[modify] https://crrev.com/28d7e2fdd0bb11a7d0061b60ee1664728ce869d5/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

Status: Fixed (was: Started)

Sign in to add a comment