New issue
Advanced search Search tips

Issue 707658 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 707638



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in platform/graphics

Project Member Reported by tkent@chromium.org, Apr 3 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/graphics.

 

Comment 1 by tkent@chromium.org, Apr 3 2017

Blocking: 707638
Labels: -codeha Hotlist-CodeHealth
Labels: BugSource-Chromium PaintTeamTriaged-20170404 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Owner: hs1217....@samsung.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e9d9cf0302323949e90805222c8aa342b53641

commit 94e9d9cf0302323949e90805222c8aa342b53641
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Wed Apr 12 02:26:21 2017

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/graphics

BUG= 707658 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2807923002
Cr-Commit-Position: refs/heads/master@{#463903}

[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ColorSpace.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/GraphicsContextStateSaver.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/GraphicsTypes.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ImageOrientation.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/InterceptingCanvas.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/Path.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/ProfilingCanvas.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp
[modify] https://crrev.com/94e9d9cf0302323949e90805222c8aa342b53641/third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h

Status: Fixed (was: Started)

Sign in to add a comment