New issue
Advanced search Search tips

Issue 707657 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 707638



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in platform/fonts

Project Member Reported by tkent@chromium.org, Apr 3 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/fonts.

 

Comment 1 by kojii@chromium.org, Apr 3 2017

Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)
Owner: hs1217....@samsung.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5e496d06dc34dd313677ad3cd125d719d838830

commit e5e496d06dc34dd313677ad3cd125d719d838830
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Wed Apr 12 00:10:20 2017

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/fonts

BUG= 707657 

Review-Url: https://codereview.chromium.org/2807913002
Cr-Commit-Position: refs/heads/master@{#463850}

[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/CharacterRange.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/Font.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontCacheMemoryDumpProvider.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontDescription.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontFaceCreationParams.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontFallbackList.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/OrientationIterator.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/SmallCapsIteratorTest.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/UTF16TextIterator.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/e5e496d06dc34dd313677ad3cd125d719d838830/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp

Status: Fixed (was: Started)

Sign in to add a comment