Editing should work with LayoutNG |
||||||||||||||||||||||||||
Issue descriptionMeta bug for adopting editing to work with LayoutNG. Until LayoutNG replaces legacy layout, editing should work with mixed tree, e.g. legacy layout tree hosting NG tree. Overview: https://goo.gl/Wv9bZV There are three phases to complete this: 1. Adopt Selection for LayoutNG: 1-1. Adopt SelectionController and SelectionModifier 1-2. Selection painter 2. Adopt TextIterator for LayoutNG; copy and find 3. Adopt Visible Position Canonicalization for LayoutNG; execCommand ⛆ |
|
|
,
Apr 4 2017
,
Apr 4 2017
>#c1 Is it blocking LayoutNG or blocked by LayoutNG? Editing blocks LayoutNG to ship. Editing works now with legacy layout tree and works without LayoutNG. But to ship LayoutNG, editing should work on NG tree.
,
Apr 18 2017
,
Apr 27 2017
,
May 12 2017
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92f32265bc3c70ee7f5e75993207fc72e91d2789 commit 92f32265bc3c70ee7f5e75993207fc72e91d2789 Author: yosin <yosin@chromium.org> Date: Fri May 26 18:43:13 2017 Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable This patch replaces redundant local variable |pop| with |return| statement in |SelectionModifier::ModifyMovingLeft()| to simplify and switches then-clause and else-clause to reduce indentation for improving code health. This patch also adds |NOTREACHED()| to catch unexpected cases. This patch is a preparation of adopting |SelectionModifier| to Layout NG. BUG=707656 TEST=n/a; Review-Url: https://codereview.chromium.org/2904813006 Cr-Commit-Position: refs/heads/master@{#475071} [modify] https://crrev.com/92f32265bc3c70ee7f5e75993207fc72e91d2789/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98c9b996ae68f0973d595b094fc0d2dbefc886a3 commit 98c9b996ae68f0973d595b094fc0d2dbefc886a3 Author: yosin <yosin@chromium.org> Date: Tue May 30 05:08:54 2017 Move LeftWordPosition/RightWordPosition() to SelectionModifierWord.cpp This patch moves |LeftWordPosition()|, |RightWordPosition()| with related functions to "SelectionModifierWord.cpp" as a preparation of making |{Left,Right}WordPosition()| as file local function since these functions are used only in |SelectionModifier| class for improving code health. This patch also makes moved code C++11'ish, |0| to |nullptr|, adding |final|, etc. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2908083002 Cr-Commit-Position: refs/heads/master@{#475428} [modify] https://crrev.com/98c9b996ae68f0973d595b094fc0d2dbefc886a3/third_party/WebKit/Source/core/editing/BUILD.gn [add] https://crrev.com/98c9b996ae68f0973d595b094fc0d2dbefc886a3/third_party/WebKit/Source/core/editing/SelectionModifierWord.cpp [modify] https://crrev.com/98c9b996ae68f0973d595b094fc0d2dbefc886a3/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/98c9b996ae68f0973d595b094fc0d2dbefc886a3/third_party/WebKit/Source/core/editing/VisibleUnits.h
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/362c1c955a0893adbbbbd53395c1f174df9f54c7 commit 362c1c955a0893adbbbbd53395c1f174df9f54c7 Author: yosin <yosin@chromium.org> Date: Tue May 30 05:09:25 2017 Change SelectionModifier::ModifyMovingRight() not to use redundant local variable This patch replaces redundant local variable |pop| with |return| statement in |SelectionModifier::ModifyMovingRight()| to simplify and switches then-clause and else-clause to reduce indentation for improving code health. This patch also adds |NOTREACHED()| to catch unexpected cases. This patch is a preparation of adopting |SelectionModifier| to Layout NG. Note: This patch is similar to the patch[1]. [1] http://crrev.com/2904813006: Change SelectionModifier::ModifyMovingLeft() not to use redundant local variable BUG=707656 TEST=n/a; Review-Url: https://codereview.chromium.org/2906263002 Cr-Commit-Position: refs/heads/master@{#475430} [modify] https://crrev.com/362c1c955a0893adbbbbd53395c1f174df9f54c7/third_party/WebKit/Source/core/editing/SelectionModifier.cpp
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1712085e2cbb5ce8e817a94dd59c90f31eaf9f27 commit 1712085e2cbb5ce8e817a94dd59c90f31eaf9f27 Author: yosin <yosin@chromium.org> Date: Wed May 31 10:06:45 2017 Limit visibility {Left,Right}BoundaryOfLine() to SelectionModifier only This patch moves |{Left,Right}BoundaryOfLine()| to "SelectionModifier.cpp" as file local functions since these functions are used in |SelectionModifier| class only, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2912303002 Cr-Commit-Position: refs/heads/master@{#475863} [modify] https://crrev.com/1712085e2cbb5ce8e817a94dd59c90f31eaf9f27/third_party/WebKit/Source/core/editing/SelectionModifier.cpp [modify] https://crrev.com/1712085e2cbb5ce8e817a94dd59c90f31eaf9f27/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/1712085e2cbb5ce8e817a94dd59c90f31eaf9f27/third_party/WebKit/Source/core/editing/VisibleUnits.h
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4e4efc136c41f9182c0143eec4e15f4bc47ac95 commit d4e4efc136c41f9182c0143eec4e15f4bc47ac95 Author: yosin <yosin@chromium.org> Date: Mon Jun 05 09:15:05 2017 Move "line" granularity related functions to VisibleUnitLine.cpp This patch moves "line" granularity related functions to "VisibleUnitLine.cpp" for ease of adopting them to Layout NG. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2914793002 Cr-Commit-Position: refs/heads/master@{#476960} [modify] https://crrev.com/d4e4efc136c41f9182c0143eec4e15f4bc47ac95/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/d4e4efc136c41f9182c0143eec4e15f4bc47ac95/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/d4e4efc136c41f9182c0143eec4e15f4bc47ac95/third_party/WebKit/Source/core/editing/VisibleUnits.h [add] https://crrev.com/d4e4efc136c41f9182c0143eec4e15f4bc47ac95/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/436a66696c7fe35e921076cf22d2bc35ffb2c7f6 commit 436a66696c7fe35e921076cf22d2bc35ffb2c7f6 Author: yosin <yosin@chromium.org> Date: Tue Jun 06 06:00:54 2017 Extract InlineBox handling from MostForwardCaretPosition() This patch extracts |InlineBox| handling code fragment into |IsOffsetRenderedForForward()| for ease of adopting |MostForwardCaretPosition()| to Layout NG. Note: The patch[1] does same thing for |MostBackwardCaretPosition()| [1] http://crrev.com/2919503003: Extract InlineBox handling from MostBackwardCaretPosition() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2918783002 Cr-Commit-Position: refs/heads/master@{#477207} [modify] https://crrev.com/436a66696c7fe35e921076cf22d2bc35ffb2c7f6/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1e24a705ef71b37dec0cb8a9e83f2f84327a7d commit ff1e24a705ef71b37dec0cb8a9e83f2f84327a7d Author: yosin <yosin@chromium.org> Date: Tue Jun 06 06:28:11 2017 Extract InlineBox handling from MostBackwardCaretPosition() This patch extracts |InlineBox| handling code fragment into |IsOffsetRenderedForBackward()| for ease of adopting |MostBackwardCaretPosition()| to Layout NG. Note: The patch[1] does same thing for |MostForkwardCaretPosition()| [1] http://crrev.com/2918783002: Extract InlineBox handling from MostForkwardCaretPosition() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2919503003 Cr-Commit-Position: refs/heads/master@{#477214} [modify] https://crrev.com/ff1e24a705ef71b37dec0cb8a9e83f2f84327a7d/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d458772d4250347ab3ed34e8cf682b16658d208a commit d458772d4250347ab3ed34e8cf682b16658d208a Author: yosin <yosin@chromium.org> Date: Wed Jun 07 01:01:33 2017 Move "paragraph" granularity related functions to VisibleUnitParagraph.cpp This patch moves "paragraph" granularity related functions to "VisibleUnitParagraph.cpp" for ease of adopting them to Layout NG. This patch is similar to the patch[1] which move "line" granularity related functions to "VisibleUnitLine.cpp" [1] http://crrev.com/2914793002: Move "line" granularity related functions to VisibleUnitLine.cpp BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2923153002 Cr-Commit-Position: refs/heads/master@{#477498} [modify] https://crrev.com/d458772d4250347ab3ed34e8cf682b16658d208a/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/d458772d4250347ab3ed34e8cf682b16658d208a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [add] https://crrev.com/d458772d4250347ab3ed34e8cf682b16658d208a/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73ba34deaf39eb774f8541d84480833527a47572 commit 73ba34deaf39eb774f8541d84480833527a47572 Author: yosin <yosin@chromium.org> Date: Wed Jun 07 01:02:10 2017 Refactor CanBe{Back,For}wardCaretPosition() This patch moves common code fragment in |{Back,For}wardCaretPosition()| into |DoesContinueOnNextLine()|, with cleanup, to reduce source code size for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2924793002 Cr-Commit-Position: refs/heads/master@{#477499} [modify] https://crrev.com/73ba34deaf39eb774f8541d84480833527a47572/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b053be0ada3400b7784fd1a1cba5399e49f2daf9 commit b053be0ada3400b7784fd1a1cba5399e49f2daf9 Author: yosin <yosin@chromium.org> Date: Thu Jun 08 00:59:32 2017 This patch changes |Most{Back,For}wardCaretPosition()| to use const-variable and early-return style for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2928703002 Cr-Commit-Position: refs/heads/master@{#477841} [modify] https://crrev.com/b053be0ada3400b7784fd1a1cba5399e49f2daf9/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59a986d9f16270986092fd9c157975eb224393d8 commit 59a986d9f16270986092fd9c157975eb224393d8 Author: yosin <yosin@chromium.org> Date: Thu Jun 08 01:00:31 2017 Refactor SelectionModifier::{Left,Right}WordPosition() This patch changes |SelectionModifier::{Left,Right}WordPosition()| to use const-variable and early-return style for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2925023002 Cr-Commit-Position: refs/heads/master@{#477842} [modify] https://crrev.com/59a986d9f16270986092fd9c157975eb224393d8/third_party/WebKit/Source/core/editing/SelectionModifierWord.cpp
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5fb415739fdd30d61a3507ccd624553c8f46eef commit f5fb415739fdd30d61a3507ccd624553c8f46eef Author: yosin <yosin@chromium.org> Date: Thu Jun 08 06:20:42 2017 Move "word" granularity related functions to VisibleUnitWord.cpp This patch moves "word" granularity related functions to "VisibleUnitWord.cpp" for ease of adopting them to Layout NG. This patch is similar to the patch[1] which move "line" granularity related functions to "VisibleUnitLine.cpp" [1] http://crrev.com/2914793002: Move "line" granularity related functions to VisibleUnitLine.cpp BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2920193003 Cr-Commit-Position: refs/heads/master@{#477913} [modify] https://crrev.com/f5fb415739fdd30d61a3507ccd624553c8f46eef/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/f5fb415739fdd30d61a3507ccd624553c8f46eef/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/f5fb415739fdd30d61a3507ccd624553c8f46eef/third_party/WebKit/Source/core/editing/VisibleUnits.h [add] https://crrev.com/f5fb415739fdd30d61a3507ccd624553c8f46eef/third_party/WebKit/Source/core/editing/VisibleUnitsWord.cpp
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf commit 23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf Author: yosin <yosin@chromium.org> Date: Thu Jun 08 09:57:49 2017 Introduce InlineTextBoxesOf() for ease of loop over InlineTextBox of LayoutText This patch Introduces |InlineTextBoxesOf()| to simplify pattern: for (InlineTextBox* box = layout_text->FirstTextBox(); box; box = box->NextTextBox()) to for (InlineTextBox* box : InlineTextBoxesOf(*layout_text)) for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2929763002 Cr-Commit-Position: refs/heads/master@{#477933} [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/layout/LayoutInline.cpp [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/layout/LayoutText.cpp [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/layout/LayoutText.h [modify] https://crrev.com/23804ef2df58586b1e2e6ccaf0f0bc7f407c2caf/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69ea6604a7a96b6cdca71aa43a0e1cb0d2eb8492 commit 69ea6604a7a96b6cdca71aa43a0e1cb0d2eb8492 Author: yosin <yosin@chromium.org> Date: Fri Jun 09 01:10:05 2017 Move "sentence" granularity related functions to VisibleUnitSentence.cpp This patch moves "sentence" granularity related functions to "VisibleUnitSentence.cpp" for ease of adopting them to Layout NG. This patch is similar to the patch[1] which move "line" granularity related functions to "VisibleUnitLine.cpp" [1] http://crrev.com/2914793002: Move "line" granularity related functions to VisibleUnitLine.cpp BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2927013002 Cr-Commit-Position: refs/heads/master@{#478149} [modify] https://crrev.com/69ea6604a7a96b6cdca71aa43a0e1cb0d2eb8492/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/69ea6604a7a96b6cdca71aa43a0e1cb0d2eb8492/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [add] https://crrev.com/69ea6604a7a96b6cdca71aa43a0e1cb0d2eb8492/third_party/WebKit/Source/core/editing/VisibleUnitsSentence.cpp
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93057ddbe435d42cbd1c3b39b63276f29076acdc commit 93057ddbe435d42cbd1c3b39b63276f29076acdc Author: yosin <yosin@chromium.org> Date: Fri Jun 09 03:51:55 2017 Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp This patch moves |LeftPositionOf()| and |RightPositionOf()| with related functions with tests to "SelectionModifierCharacter.cpp" and "SelectionModifierTest.cpp" since these functions are used only in |SelectionModifier| class for improving code health. This patch also makes moved code C++11'ish, |0| to |nullptr|. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2930863002 Cr-Commit-Position: refs/heads/master@{#478192} [modify] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/SelectionModifier.h [add] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp [add] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/SelectionModifierTest.cpp [modify] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/VisibleUnits.h [modify] https://crrev.com/93057ddbe435d42cbd1c3b39b63276f29076acdc/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
,
Jun 9 2017
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6c973e6a860ef254df119b535653b987d0e9d90 commit c6c973e6a860ef254df119b535653b987d0e9d90 Author: yosin <yosin@chromium.org> Date: Fri Jun 09 07:51:55 2017 Introduce LocalCaretRect for refactoring Local{Caret,Selection}RectPosition() This patch introduces |LocalCaretRect| to use as return value of |Local{Caret,Selection}RectPosition()| to avoid output-parameter with utilizing const-variables for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2926823002 Cr-Commit-Position: refs/heads/master@{#478231} [modify] https://crrev.com/c6c973e6a860ef254df119b535653b987d0e9d90/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp [modify] https://crrev.com/c6c973e6a860ef254df119b535653b987d0e9d90/third_party/WebKit/Source/core/editing/SelectionModifier.cpp [modify] https://crrev.com/c6c973e6a860ef254df119b535653b987d0e9d90/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/c6c973e6a860ef254df119b535653b987d0e9d90/third_party/WebKit/Source/core/editing/VisibleUnits.h [modify] https://crrev.com/c6c973e6a860ef254df119b535653b987d0e9d90/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8f46de2517307a1a0c72f1c41b72594e21028d3 commit f8f46de2517307a1a0c72f1c41b72594e21028d3 Author: yosin <yosin@chromium.org> Date: Mon Jun 12 03:14:52 2017 Avoid to reuse local variable in ComputeInlineBoxPosition() This patch chagnes |ComputeInlineBoxPosition()| to avoid to reuse local variable |equivalent| by introducing two const-variable and another call site of |ComputeInlineBoxPosition()| to explicitly denotes what value is used, e.g. |downstream_equivalent| or |upstream_equivalent|, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2933513002 Cr-Commit-Position: refs/heads/master@{#478543} [modify] https://crrev.com/f8f46de2517307a1a0c72f1c41b72594e21028d3/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85c02b2c4d6c4a9fe3025ba70d98324be01b994e commit 85c02b2c4d6c4a9fe3025ba70d98324be01b994e Author: yosin <yosin@chromium.org> Date: Mon Jun 12 03:16:49 2017 Introduce AdjustInlineBoxPositionForTextDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForTextDirection()| which is split from |ComputeInlineBoxPosition()| to reduce source code size of |ComputeInlineBoxPosition()| for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2928083003 Cr-Commit-Position: refs/heads/master@{#478544} [modify] https://crrev.com/85c02b2c4d6c4a9fe3025ba70d98324be01b994e/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3de8b2e022a8448fec77e19e47aa2d3dd769508f commit 3de8b2e022a8448fec77e19e47aa2d3dd769508f Author: yosin <yosin@chromium.org> Date: Tue Jun 13 08:21:12 2017 Utilize one template to implement LeftPositionOf() and RightPositionOf() This patch introduces |TraverseAlgorhtim()| and |TraverseInternalAlgorhtim()| to unify |LeftPositoinOf()| and |RightPositionOf()| implementations since these functions use identical algorithm except for except for traverse direction to avoid source code duplication for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2934773002 Cr-Commit-Position: refs/heads/master@{#478933} [modify] https://crrev.com/3de8b2e022a8448fec77e19e47aa2d3dd769508f/third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736123357fcf3d8bf78af92fdd24efa81333117e commit 736123357fcf3d8bf78af92fdd24efa81333117e Author: yosin <yosin@chromium.org> Date: Wed Jun 14 01:08:03 2017 Introduce IsCaretAtEdgeOfInlineTextBox() to simplify ComputeInlineBoxPosition() This patch introduces |IsCaretAtEdgeOfInlineTextBox()| to simplify loop body and simplify condition expression in |ComputeInlineBoxPosition()| for improving code health. The implementation of |IsCaretAtEdgeOfInlineTextBox()| based on following reasoning: Table of exclusive-or expressions: 1 (caret_offset == caret_max_offset) ^ (affinity == Downstream) 2 (caret_offset == caret_min_offset) ^ (affinity == Upstream) Results of expression 1 and 2 are same for combinations of |caret_offset| and |affinity|. caret_offset|affinity |result ------------+----------+------- max_offset |Downstream|false max_offset |Upstream |true min_offset |Downstream|true min_offset |Upstream |false BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2932283002 Cr-Commit-Position: refs/heads/master@{#479236} [modify] https://crrev.com/736123357fcf3d8bf78af92fdd24efa81333117e/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a043e477b4857645c2f73583ea147b318fb40a4 commit 4a043e477b4857645c2f73583ea147b318fb40a4 Author: yosin <yosin@chromium.org> Date: Wed Jun 14 02:50:07 2017 Make InlineBoxPosition constructor not to accept null-InlineBox and an negative offset This patch makes |InlineBoxPosition| not to accept null |InlineBox| and an negative offset to avoid wrong usage of |InlineBoxPosition|. Before this patch, |InlineBoxPosition.offset_in_box| holds an offset of specified position event if |.layout_object| is null. After this patch, |.offset_in_box| is zero if |.layout_object| is null. Other than explicit test case and |LocalCaretRectOfPositionTemplate()|, we don't use |offset_in_box| member when |InlineBox| is null. We've not seen wrong usage so far and code reading doesn't find wrong usages. Once we find wrong call sites, we'll fix them. BUG=707656 TEST=run_webkit_unit_tests --gtest_filter=VisibleUnitsTest.ComputeInlineBoxPositionMixedEditable Review-Url: https://codereview.chromium.org/2931673004 Cr-Commit-Position: refs/heads/master@{#479264} [modify] https://crrev.com/4a043e477b4857645c2f73583ea147b318fb40a4/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/4a043e477b4857645c2f73583ea147b318fb40a4/third_party/WebKit/Source/core/editing/VisibleUnits.h [modify] https://crrev.com/4a043e477b4857645c2f73583ea147b318fb40a4/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06b859c5dac92e22ea6db5c59643ce574d58ea3c commit 06b859c5dac92e22ea6db5c59643ce574d58ea3c Author: yosin <yosin@chromium.org> Date: Thu Jun 15 05:16:39 2017 Utilize ComputeInlineBoxPositionTempalte() in early-return style This patch changes |ComputeInlineBoxPositionTemplate()| to utilize early-return style to limit scope variable |inline_box|, which is the result of the function, for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2934223002 Cr-Commit-Position: refs/heads/master@{#479610} [modify] https://crrev.com/06b859c5dac92e22ea6db5c59643ce574d58ea3c/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c3619e9e404908d6f67e4e7195bd03e5f0316d7 commit 9c3619e9e404908d6f67e4e7195bd03e5f0316d7 Author: yosin <yosin@chromium.org> Date: Thu Jun 15 08:56:52 2017 Introduce ComputeInlineBoxPositionForTextNode() This patch Introduces |ComputeInlineBoxPositionForTextNode()| split from |ComputeInlineBoxPositionTemplate()| to make it smaller for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2941013003 Cr-Commit-Position: refs/heads/master@{#479645} [modify] https://crrev.com/9c3619e9e404908d6f67e4e7195bd03e5f0316d7/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0367089c48e7a709c7464545f7f5d1b2221017cc commit 0367089c48e7a709c7464545f7f5d1b2221017cc Author: yosin <yosin@chromium.org> Date: Thu Jun 15 09:47:40 2017 Introduce FindRightNonPseudoNodeInlineBox() This patch Introduces |FindRightNonPseudoNodeInlineBox()| extracted from |StartPositionForLine()| to simplify it for improving code health. This patch is similar to the patch[1] which introduces |FindLeftNonPseudoNodeInlineBox()|. [1] http://crrev.com/2937173002: Introduce FindLeftNonPseudoNodeInlineBox() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2938153002 Cr-Commit-Position: refs/heads/master@{#479651} [modify] https://crrev.com/0367089c48e7a709c7464545f7f5d1b2221017cc/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52a8a744798e4033ebf8fdc8e21cfe21fc1e89d0 commit 52a8a744798e4033ebf8fdc8e21cfe21fc1e89d0 Author: yosin <yosin@chromium.org> Date: Thu Jun 15 09:57:30 2017 Introduce FindLeftNonPseudoNodeInlineBox() This patch Introduces |FindLeftNonPseudoNodeInlineBox()| extracted from |EndPositionForLine()| to simplify it for improving code health. This patch is similar to the patch[1] which introduces |FindRightNonPseudoNodeInlineBox()|. [1] http://crrev.com/2938153002: Introduce FindRightNonPseudoNodeInlineBox() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2937173002 Cr-Commit-Position: refs/heads/master@{#479655} [modify] https://crrev.com/52a8a744798e4033ebf8fdc8e21cfe21fc1e89d0/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b173d3f09519dccd5cd6fbc1d55bd300a895ae commit e7b173d3f09519dccd5cd6fbc1d55bd300a895ae Author: yosin <yosin@chromium.org> Date: Fri Jun 16 01:50:00 2017 Get rid of redundant block scope from ComputeInlineBoxPositionForTextNode() This patch gets rid of redundant block scope from |ComputeInlineBoxPositionForTextNode()| for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2938923004 Cr-Commit-Position: refs/heads/master@{#479899} [modify] https://crrev.com/e7b173d3f09519dccd5cd6fbc1d55bd300a895ae/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/415ac0eadcdf44479c216c06445e84c7556b718c commit 415ac0eadcdf44479c216c06445e84c7556b718c Author: yosin <yosin@chromium.org> Date: Fri Jun 16 02:03:16 2017 Introduce Find{Left,Right}BoundaryOfBidiRun() and variations This patch introduces |Find{Left,Right}BoundaryOfBidiRun()| and variations in |InlineBoxTraversal| class to simplify common pattern in |AdjustInlineBoxPositionForTextDirection()| for improving code health. Pattern: InlineBox* result = start; while (InlineBox* runner = runner->Forward()) { if (ShouldBreak(runner->BidiLevel(), bidi_level)) break; result = runner; } - Forward can be {Next,Prev}LeafChild{,IgnoreLineBreak}() - ShouldBreak can be operator<() or operator<=() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2942523003 Cr-Commit-Position: refs/heads/master@{#479919} [modify] https://crrev.com/415ac0eadcdf44479c216c06445e84c7556b718c/third_party/WebKit/Source/core/editing/BUILD.gn [add] https://crrev.com/415ac0eadcdf44479c216c06445e84c7556b718c/third_party/WebKit/Source/core/editing/InlineBoxTraversal.cpp [add] https://crrev.com/415ac0eadcdf44479c216c06445e84c7556b718c/third_party/WebKit/Source/core/editing/InlineBoxTraversal.h [modify] https://crrev.com/415ac0eadcdf44479c216c06445e84c7556b718c/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f27177df9fa6d949bd33fd6095f8c8a1481b1890 commit f27177df9fa6d949bd33fd6095f8c8a1481b1890 Author: yosin <yosin@chromium.org> Date: Fri Jun 16 07:56:42 2017 2941213002: Get rid of forward declaration of ComputeInlineBoxPositionForTextNode() This patch moves implementation of |ComputeInlineBoxPositionForTextNode()| at forward declaration to get rid of forward declaration for improving code health. This is follow-up the patch[1] which inttroduces it. [1] http://crrev.com/2941013003 Introduce ComputeInlineBoxPositionForTextNode() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2941213002 Cr-Commit-Position: refs/heads/master@{#479986} [modify] https://crrev.com/f27177df9fa6d949bd33fd6095f8c8a1481b1890/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fdb190540dab20a6d35b4eb34f8ae7efe37a7d7 commit 8fdb190540dab20a6d35b4eb34f8ae7efe37a7d7 Author: yosin <yosin@chromium.org> Date: Fri Jun 16 08:11:24 2017 Utilize Find{Left,Right}BoundaryOfEntireBidiRunIgnoringLineBreak() in RenderedPosition This patch changes |RenderedPosition::{Left,Right}BoundaryOfBidiRun()| to use |Find{Left,Right}BoundaryOfEntireBidiRunIgnoringLineBreak()| to avoid duplicating common pattern for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2940273002 Cr-Commit-Position: refs/heads/master@{#479990} [modify] https://crrev.com/8fdb190540dab20a6d35b4eb34f8ae7efe37a7d7/third_party/WebKit/Source/core/editing/RenderedPosition.cpp
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13729cdfbd63d6814a5a09e764e012b142576f34 commit 13729cdfbd63d6814a5a09e764e012b142576f34 Author: yosin <yosin@chromium.org> Date: Fri Jun 16 08:19:48 2017 Utilize InlineBoxTraversal in {Left,Right}PositionOf() left/right traversal This patch utilizes |Find{Left,Right}BoundaryOfEntireBidiRun()| in |TraverseInternalAlgorithm()| for |{Left,Right}PositionOf()| in |SelectionModifier| class to avoid common pattern for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2944563002 Cr-Commit-Position: refs/heads/master@{#479993} [modify] https://crrev.com/13729cdfbd63d6814a5a09e764e012b142576f34/third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp
,
Jun 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38c57515aad29dfce4bd77c885ba937c5b93371b commit 38c57515aad29dfce4bd77c885ba937c5b93371b Author: yosin <yosin@chromium.org> Date: Mon Jun 19 03:28:45 2017 Reduce indentation in ComputeInlineBoxPositionTemplate() This patch reduces indentation in |ComputeInlineBoxPositionTemplate()| by switching if-condition to move large then-clause out of if-statement for improving of readability. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2943623002 Cr-Commit-Position: refs/heads/master@{#480337} [modify] https://crrev.com/38c57515aad29dfce4bd77c885ba937c5b93371b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a3854354e0d85a1ba68d3468795a261c4a72052 commit 2a3854354e0d85a1ba68d3468795a261c4a72052 Author: yosin <yosin@chromium.org> Date: Mon Jun 19 03:41:52 2017 Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style, e.g. move break-statement at end of if-else-statement to inside then-clause, to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2939023003 Cr-Commit-Position: refs/heads/master@{#480338} [modify] https://crrev.com/2a3854354e0d85a1ba68d3468795a261c4a72052/third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp
,
Jun 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/add3c68a6c8aea99a4f7088193f99d5eaaa5b510 commit add3c68a6c8aea99a4f7088193f99d5eaaa5b510 Author: yosin <yosin@chromium.org> Date: Mon Jun 19 03:47:11 2017 Introduce Find{Left,Right}BidiRun() and utilize in AdjustInlineBoxPositionForTextDirection() This patch introduces |Find{Left,Right}BidiRun()| in |InlineBoxTraversal| to unify common pattern into function for improving of readability. Before this patch: InlineBox* result = start; do { result = result->Forward(); } while (result && result->BidiLevel() > level); ... use result ... After this patch: InlineBox* Find(InlineBox* start, unsigned level) { for (InlineBox* runner = start->Forward(); runner; runner = runner->Forward()) { if (runner->BidiLevel() <= level) return runner; } return nullptr; } InlineBox* result = Find(start, level); ... use result ... BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2943053002 Cr-Commit-Position: refs/heads/master@{#480340} [modify] https://crrev.com/add3c68a6c8aea99a4f7088193f99d5eaaa5b510/third_party/WebKit/Source/core/editing/InlineBoxTraversal.cpp [modify] https://crrev.com/add3c68a6c8aea99a4f7088193f99d5eaaa5b510/third_party/WebKit/Source/core/editing/InlineBoxTraversal.h [modify] https://crrev.com/add3c68a6c8aea99a4f7088193f99d5eaaa5b510/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59326d74274f028a233a2561f940a84675e0c967 commit 59326d74274f028a233a2561f940a84675e0c967 Author: yosin <yosin@chromium.org> Date: Wed Jun 21 01:10:56 2017 Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. Note: The diff could be small but changing indentation makes diff larger. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2950763002 Cr-Commit-Position: refs/heads/master@{#481056} [modify] https://crrev.com/59326d74274f028a233a2561f940a84675e0c967/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Aug 21 2017
Mark Available since this is meta bug and everybody can work.
,
Aug 30 2017
,
Oct 3 2017
,
Oct 19 2017
,
Oct 20 2017
,
Oct 26 2017
,
Oct 31 2017
,
Nov 6 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ac60e0c1a2e63f6a92e633ac90f70cd9f159e87 commit 2ac60e0c1a2e63f6a92e633ac90f70cd9f159e87 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Nov 10 06:23:38 2017 [LayoutNG] Disable LayoutNG for block-level contenteditable This patch disables LayoutNG for block-level contenteditable until we're ready to start working on. Also gives us more test opportunities of mixed-tree layout. This patch is continued from the patch[1]. The idea of this patch is attaching legacy layout object to block-level element if it is editaible instead of NG layout object. Hence, this patch doesn't disable inline-level contenteditable, e.g. <span contenteditable>foo</span>. Following patch will handle inline-level contenteditable as similar as RUBY in NG block layout object. [1] http://crrev.com/c/734962 [LayoutNG] Disable LayoutNG for contenteditable Bug: 707656 Change-Id: Ia7a20d88f2e9499dc614791e46021072e4702669 Reviewed-on: https://chromium-review.googlesource.com/758309 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515476} [modify] https://crrev.com/2ac60e0c1a2e63f6a92e633ac90f70cd9f159e87/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/2ac60e0c1a2e63f6a92e633ac90f70cd9f159e87/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp [modify] https://crrev.com/2ac60e0c1a2e63f6a92e633ac90f70cd9f159e87/third_party/WebKit/Source/core/layout/LayoutObject.cpp
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d301cfc6b7aaf6b88738e16040534b5e8358aca2 commit d301cfc6b7aaf6b88738e16040534b5e8358aca2 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Tue Nov 14 09:01:22 2017 [LayoutNG] Introduce CanUseInlineBox() for tracking project progress This patch introduces |CanUseInlineBox()| as a preparation to add |DCHECK(CanUseInlineBox())| to functions using |InlineBox| for marker of progress of LayoutNG project. To release LayoutNG, we should not hit these |DCHECK()|. Following patch will utilize |CanUseInlineBox()| into layout/ and editing/. The patch[1] is a sample of utilization. [1] http://crrev.com/c/763188 [LayoutNG] Utilize DCHECK(CanUseInlineBox()) in core/layout/ Bug: 591099, 707656 Change-Id: Id71c39ae8520ab18fd1b8b8f3e18a66e8a7d567c Reviewed-on: https://chromium-review.googlesource.com/768572 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#516239} [modify] https://crrev.com/d301cfc6b7aaf6b88738e16040534b5e8358aca2/third_party/WebKit/Source/core/layout/line/InlineBox.cpp [modify] https://crrev.com/d301cfc6b7aaf6b88738e16040534b5e8358aca2/third_party/WebKit/Source/core/layout/line/InlineBox.h
,
Nov 30 2017
,
Nov 30 2017
,
Nov 30 2017
,
Feb 9 2018
,
Feb 12 2018
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a4bea4f1fae10e5012e93fb09092c3f996f8681 commit 7a4bea4f1fae10e5012e93fb09092c3f996f8681 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu May 24 02:09:38 2018 Utilize selection_test() in editing/pasteboard/merge-start-blockquote.html This patch changes "merge-start-blockquote.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977, 707656 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib8b5d63687c42e9ead5167a11f0a592e19297f84 Reviewed-on: https://chromium-review.googlesource.com/1069965 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561359} [modify] https://crrev.com/7a4bea4f1fae10e5012e93fb09092c3f996f8681/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/7a4bea4f1fae10e5012e93fb09092c3f996f8681/third_party/WebKit/LayoutTests/editing/pasteboard/merge-start-blockquote.html [delete] https://crrev.com/62b6928f6a8a8fd89fe75fad1add244879a8c28b/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-start-blockquote-expected.png [delete] https://crrev.com/62b6928f6a8a8fd89fe75fad1add244879a8c28b/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-start-blockquote-expected.txt [delete] https://crrev.com/62b6928f6a8a8fd89fe75fad1add244879a8c28b/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-start-blockquote-expected.png [delete] https://crrev.com/62b6928f6a8a8fd89fe75fad1add244879a8c28b/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt [delete] https://crrev.com/62b6928f6a8a8fd89fe75fad1add244879a8c28b/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-start-blockquote-expected.png [delete] https://crrev.com/62b6928f6a8a8fd89fe75fad1add244879a8c28b/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-start-blockquote-expected.txt
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67b5dc832b4dee7660efc6c2f0012c136407325d commit 67b5dc832b4dee7660efc6c2f0012c136407325d Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu May 24 09:04:25 2018 Utilize selection_test() in editing/pasteboard/merge-start-list.html This patch changes "merge-start-list.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977, 707656 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4cb1f79ae6df06a47114550e7af32439d994a186 Reviewed-on: https://chromium-review.googlesource.com/1071155 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561432} [modify] https://crrev.com/67b5dc832b4dee7660efc6c2f0012c136407325d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/67b5dc832b4dee7660efc6c2f0012c136407325d/third_party/WebKit/LayoutTests/editing/pasteboard/merge-start-list.html [delete] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-start-list-expected.png [delete] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/merge-start-list-expected.txt [delete] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-start-list-expected.png [delete] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/merge-start-list-expected.txt [delete] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-start-list-expected.png [delete] https://crrev.com/f57f3b2bc53cb0d52be69faee2b175612b0df23a/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/merge-start-list-expected.txt
,
Jun 7 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0cb8e1708bae69cbde78f0ad3eea22ba905dc9c commit f0cb8e1708bae69cbde78f0ad3eea22ba905dc9c Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jun 27 07:51:58 2018 [LayoutNG] Add layout_ng try bots for core/editing This patch adds LayoutNG bots for changes in core/editing directory because of deep dependency. Bug: 707656 Change-Id: Iafcf381f9fab5c8472917c3d7ca22d8c378ba2f7 Reviewed-on: https://chromium-review.googlesource.com/1116402 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#570690} [modify] https://crrev.com/f0cb8e1708bae69cbde78f0ad3eea22ba905dc9c/third_party/blink/PRESUBMIT.py
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aeee73ec2493263b06346a3e8cd13378bce41069 commit aeee73ec2493263b06346a3e8cd13378bce41069 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Jul 27 19:46:13 2018 Introduce EditingNG runtime enabled feature This patch introduces "EditingNG" runtime enabled feature which implies "LayoutNG" for adapting editing to LayoutNG incremental. Once editing functionalities adapted to LayoutNG, this runtime enabled feature will be removed. Bug: 707656 Change-Id: I3e9edcf9a207e284740d082feb8ef08dbec090a9 Reviewed-on: https://chromium-review.googlesource.com/1152715 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578756} [modify] https://crrev.com/aeee73ec2493263b06346a3e8cd13378bce41069/third_party/blink/renderer/platform/runtime_enabled_features.json5
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3055c3402fbcca5a93450d508d7e7c0e283220a commit f3055c3402fbcca5a93450d508d7e7c0e283220a Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu Aug 16 06:14:06 2018 Make EditingNG runtime enabled feature to enable content editable in LayoutNG This patch makes EditingNG runtime enabled feature to enable content editable in LayoutNG. This is follow-up patch of the patch[1] which add "EditingNG" runtime enabled feature. Layout test failures in editing/ Total 633 - Crash 25 - Timeout 2 - Text failure 122 - Harness failure 355 - Image failure 61 - Image+text failure 88 Failures are tracked by ttps://goo.gl/ijHgn0 [1] http://crrev.com/c/1152715 Introduce EditingNG runtime enabled feature Bug: 707656 Change-Id: I043c41c95b947b082d456034f1a934bffcbbe839 Reviewed-on: https://chromium-review.googlesource.com/1177098 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583561} [modify] https://crrev.com/f3055c3402fbcca5a93450d508d7e7c0e283220a/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
,
Aug 21
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9537e32b4ee13970cdcbe99bb7e929b53b3b5856 commit 9537e32b4ee13970cdcbe99bb7e929b53b3b5856 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Thu Aug 23 18:16:31 2018 [EditingNG] Remove spaces before <br> from some layout tests Legacy layout has a bug that, whitespaces before <br> are not collapsed (https://crbug.com/40634). The issue is fixed in NG. This difference results in that, in some editing/selection layout tests, one less character is moved through when EditingNG is enabled, so these tests fail. This patch removes the spaces before <br> so that these tests pass. Bug: 707656 Change-Id: I4256865abb0a1fe925cfa584fe111b8ba8312332 Reviewed-on: https://chromium-review.googlesource.com/1185998 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585548} [modify] https://crrev.com/9537e32b4ee13970cdcbe99bb7e929b53b3b5856/third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html [modify] https://crrev.com/9537e32b4ee13970cdcbe99bb7e929b53b3b5856/third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-002.html [modify] https://crrev.com/9537e32b4ee13970cdcbe99bb7e929b53b3b5856/third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-003.html [modify] https://crrev.com/9537e32b4ee13970cdcbe99bb7e929b53b3b5856/third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-004.html [modify] https://crrev.com/9537e32b4ee13970cdcbe99bb7e929b53b3b5856/third_party/WebKit/LayoutTests/editing/selection/modify_move/move-by-character-005.html
,
Aug 23
,
Oct 17
|
|||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by xiaoche...@chromium.org
, Apr 3 2017