New issue
Advanced search Search tips

Issue 707655 link

Starred by 1 user
Status: Verified
Owner:
hongchan@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707638



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in platform/audio

Project Member Reported by tkent@chromium.org, Apr 3 2017 
Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/audio/.

Comment 1 by hongchan@chromium.org, Apr 4 2017

Owner: hongchan@chromium.org
Status: Started (was: Untriaged)

Comment 2 by hongchan@chromium.org, Apr 4 2017 

Considering the |op| should be used accordingly based on the the meaning of assertion, this is hard to be automated. I am doing this manually.

Comment 3 by rtoy@chromium.org, Apr 4 2017 

You could go a very long way by auto-converting ASSERT(var) to DCHECK(var).  grep didn't find any RELEASE_ASSERT or ASSERT_NOT_REACHED.

That would make reviewing much easier.

Comment 4 by tkent@chromium.org, Apr 5 2017 

I recommend to replace ASSERT with DECHK mechanically, then review the diff and apply DCHECK_op manually.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/497c247fb764715c64de5a4e73dbd014cb13bb65

commit 497c247fb764715c64de5a4e73dbd014cb13bb65
Author: hongchan <hongchan@chromium.org>
Date: Wed Apr 05 23:14:35 2017

Change from ASSERT() to DCHECK() mechanically, replacing the assertion
with a single argument only. I used the following script:

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
find . -type f -exec sed -i -E 's:(\s)ASSERT\(([^ ]+)\)\;:\1DCHECK\(\2\)\;:g' {} \;
```

BUG= 707655 

Review-Url: https://codereview.chromium.org/2803733002
Cr-Commit-Position: refs/heads/master@{#462261}

[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioChannel.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioResampler.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/DownSampler.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/FFTConvolver.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/HRTFKernel.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/HRTFPanner.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/IIRFilter.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/Reverb.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/SincResampler.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/StereoPanner.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/UpSampler.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/VectorMath.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/497c247fb764715c64de5a4e73dbd014cb13bb65/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5

commit f90cae07269c724f98ca3c196ea37ce7f6a801d5
Author: hongchan <hongchan@chromium.org>
Date: Fri Apr 07 17:16:46 2017

Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG= 707655 

Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462904}

[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioChannel.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/AudioUtilities.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/HRTFKernel.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/HRTFPanner.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/IIRFilter.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/SincResampler.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/ipp/FFTFrameIPP.cpp
[modify] https://crrev.com/f90cae07269c724f98ca3c196ea37ce7f6a801d5/third_party/WebKit/Source/platform/audio/mac/FFTFrameMac.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019

commit b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019
Author: hongchan <hongchan@chromium.org>
Date: Fri Apr 07 17:29:55 2017

Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (patchset #3 id:40001 of https://codereview.chromium.org/2803073002/ )

Reason for revert:
Unexpected compilation error from buildbot Android Builder.

Original issue's description:
> Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio
>
> This CL is the second part of the conversion. It manually replaces:
>
>  - RELEASE_ASSERT() with CHECK().
>  - ASSERT(...args) with one or more DCHECK_op(arg).
>
> With this CL the following script returns 0 result.
>
> ```
> cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
> grep -rnw . -e 'ASSERT('
> ```
>
> BUG= 707655 
>
> Review-Url: https://codereview.chromium.org/2803073002
> Cr-Commit-Position: refs/heads/master@{#462904}
> Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5

TBR=rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 707655 

Review-Url: https://codereview.chromium.org/2807593003
Cr-Commit-Position: refs/heads/master@{#462908}

[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioChannel.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/AudioUtilities.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/HRTFKernel.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/HRTFPanner.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/IIRFilter.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/SincResampler.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/ipp/FFTFrameIPP.cpp
[modify] https://crrev.com/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019/third_party/WebKit/Source/platform/audio/mac/FFTFrameMac.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36640ecf2e136c9d8d4dd1a4a25d9175129bb587

commit 36640ecf2e136c9d8d4dd1a4a25d9175129bb587
Author: hongchan <hongchan@chromium.org>
Date: Fri Apr 07 19:25:26 2017

Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

This CL is the second part of the conversion. It manually replaces:

 - RELEASE_ASSERT() with CHECK().
 - ASSERT(...args) with one or more DCHECK_op(arg).

With this CL the following script returns 0 result.

```
cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
grep -rnw . -e 'ASSERT('
```

BUG= 707655 

Review-Url: https://codereview.chromium.org/2803073002
Cr-Original-Commit-Position: refs/heads/master@{#462904}
Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5
Review-Url: https://codereview.chromium.org/2803073002
Cr-Commit-Position: refs/heads/master@{#462958}

[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioArray.h
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioChannel.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/AudioUtilities.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/DirectConvolver.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/HRTFKernel.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/HRTFPanner.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/IIRFilter.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/SincResampler.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/ipp/FFTFrameIPP.cpp
[modify] https://crrev.com/36640ecf2e136c9d8d4dd1a4a25d9175129bb587/third_party/WebKit/Source/platform/audio/mac/FFTFrameMac.cpp

Comment 9 by hongchan@chromium.org, Apr 8 2017

Status: Verified (was: Started)
►

Sign in to add a comment