New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707652 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 707642



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in modules/fetch

Project Member Reported by tkent@chromium.org, Apr 3 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/fetch.
 
Status: Available (was: Untriaged)
Owner: pilgrim@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9239bcb33250cd613229d19a90af7cfa28d861

commit 0d9239bcb33250cd613229d19a90af7cfa28d861
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Apr 18 03:08:15 2017

Replace ASSERT with DCHECK in modules/fetch.

BUG= 707652 

Review-Url: https://codereview.chromium.org/2804023004
Cr-Commit-Position: refs/heads/master@{#465122}

[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/Body.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/Headers.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/0d9239bcb33250cd613229d19a90af7cfa28d861/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Status: Started (was: Assigned)
Status: Fixed (was: Started)
no instances of ASSERT_NOT_REACHED or RELEASE_ASSERT, so that's all folks.

Sign in to add a comment