New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707651 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility

Blocking:
issue 707642



Sign in to add a comment

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in modules/accessibility

Project Member Reported by tkent@chromium.org, Apr 3 2017

Issue description

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/accessibility.

 
Owner: pilgrim@chromium.org
Status: (was: Untriaged)
Status: Assigned
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6648272c4139109fa7a452b6f4da3e124d9d02a8

commit 6648272c4139109fa7a452b6f4da3e124d9d02a8
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Apr 07 23:10:24 2017

Replace ASSERT with DCHECK in modules/accessibility

BUG= 707651 

Review-Url: https://codereview.chromium.org/2804383002
Cr-Commit-Position: refs/heads/master@{#463037}

[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/6648272c4139109fa7a452b6f4da3e124d9d02a8/third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.cpp

Status: Fixed (was: Assigned)
no RELEASE_ASSERT instances

Sign in to add a comment