New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707650 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unnecessary focus is seen around the profile icon of YouTube.com

Project Member Reported by ratnavar...@techmahindra.com, Apr 3 2017

Issue description

Chrome Version:59.0.3060.0 dev
OS:Ubuntu 14.04,Windows

Precondition:Sign-in to any Google Account with valid credentials.

What steps will reproduce the problem?
(1)Launch Chrome,go to https://www.youtube.com/
(2)Observe the profile icon on top-right corner.

Actual Result:Unnecessary focus is seen around profile icon.
Expected Result:No such focus should be seen.

This is a Regression issue broken in M-59.

Manual bisect Info:
===================
Good Build:59.0.3057.0 dev
Bad Build :59.0.3059.0 dev



 

Comment 1 by ajha@chromium.org, Apr 3 2017

Labels: OS-Mac
Status: Untriaged (was: Unconfirmed)
Seen on canary version: 59.0.3060.0 on Mac OS 10.12.3 as well.
Labels: -Needs-Bisect hasbisect-per-revision
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build: 59.0.3057.0 (Revision: 460966).
Bad build : 59.0.3059.0 (Revision: 461269).

You are probably looking for a change made after 461013 (known good), but no later than 461014 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/904a97549b34407f69820f1ff114c861f9c35bf6..9dde8ce672f222dc77bd460ac703a2bef6910bc7

@chrishtr: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Components: -UI Blink>Paint
Status: Started (was: Assigned)
Labels: ReleaseBlock-Stable
Labels: BugSource-Chromium PaintTeamTriaged-20170404
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6d12780972f3d9711de6d11c6dd6e0536020339

commit b6d12780972f3d9711de6d11c6dd6e0536020339
Author: chrishtr <chrishtr@chromium.org>
Date: Wed Apr 05 22:20:04 2017

Compute rounded-ness of visual rects.

This was not needed until https://codereview.chromium.org/2781863005.
Previously we were computing rounded-ness internally to GeometryMapper,
but did not expose it through the *VisualRect* methods, only the
*ClipRect* ones. Thus this CL is just plumbing and API type updates.

BUG= 707650 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2802443002
Cr-Commit-Position: refs/heads/master@{#462242}

[add] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/LayoutTests/fast/clip/nested-rounded-rect-expected.html
[delete] https://crrev.com/ac31b98fab70714a777f7a208ddeeb2e50ad0749/third_party/WebKit/LayoutTests/fast/clip/nested-rounded-rect-expected.png
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/platform/graphics/paint/FloatClipRect.h
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h
[modify] https://crrev.com/b6d12780972f3d9711de6d11c6dd6e0536020339/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment