New issue
Advanced search Search tips

Issue 707647 link

Starred by 1 user
Status: Fixed
Owner:
noel@chromium.org
Closed: Apr 2017
Cc:
scroggo@chromium.org
mmoroz@chromium.org
hcm@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add more APNG LLVM fuzzer seeds

Project Member Reported by noel@chromium.org, Apr 3 2017 
APNG support was added to chrome in  bug 437662 .  A few more APNG seeds for fuzzing would be good.

Change that added the //WebKit/LayoutTests/images/png-suite/samples to the blink (a)png
fuzzer was https://codereview.chromium.org/2686843002 for reference.  Seems to me the png-suite directory would be a good place to store apng seeds.

And the images?  One can run a perl script to produce said images.

Comment 2 by noel@chromium.org, Apr 3 2017

Cc: hcm@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98750d7d38046584536d60a3a89a2863a8264ec7

commit 98750d7d38046584536d60a3a89a2863a8264ec7
Author: noel <noel@chromium.org>
Date: Mon Apr 03 15:35:09 2017

Add APNG fuzzer seeds to png-suite

Add APNG image samples to LayoutTests/images/png-suite, to be used
as seeds for the LLVM Blink PNG fuzzer.

BUG= 707647 

Review-Url: https://codereview.chromium.org/2793883002
Cr-Commit-Position: refs/heads/master@{#461437}

[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/000.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/001.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/002.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/003.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/004.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/005.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/006.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/007.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/008.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/009.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/010.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/011.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/012.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/013.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/014.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/015.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/016.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/017.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/018.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/019.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/020.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/021.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/022.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/023.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/024.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/025.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/026.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/027.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/028.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/029.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/030.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/031.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/032.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/033.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/034.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/035.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/036.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/037.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/038.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/039.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/040.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/041.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/042.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/043.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/044.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/045.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/046.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/047.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/048.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/049.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/050.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/051.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/052.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/053.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/054.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/055.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/056.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/057.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/058.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/059.png
[add] https://crrev.com/98750d7d38046584536d60a3a89a2863a8264ec7/third_party/WebKit/LayoutTests/images/png-suite/samples/060.png

Comment 4 by noel@chromium.org, Apr 7 2017

Status: Fixed (was: Started)
If I moved these to png-suite/samples/animated/* would the fuzzer read them?

Comment 5 by mmoroz@google.com, Apr 7 2017 

Yes, the script goes through 'seed_corpus' directories recursively and collects all the files.

Comment 6 by noel@chromium.org, Apr 10 2017 

Ah good to know, thanks.  

I was thinking of your review comments about naming these files "apng" or similar.  Moving them into an animated sub-dir kinda does that, and does allow the LLVM fuzzers to still read/use them as seeds.

Let me prepare a patch for that.

Comment 7 by noel@chromium.org, Apr 10 2017

Status: Started (was: Fixed)
> Let me prepare a patch for that.

And I might do that after all the Blink rename changes land.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d09bddfdb6f6382732f654ca6273d4088c246d51

commit d09bddfdb6f6382732f654ca6273d4088c246d51
Author: noel <noel@chromium.org>
Date: Mon Apr 10 11:50:45 2017

Move APNG fuzzer seeds to png-suite/samples/animated

Move APNG image samples/* to samples/animated/* in png-suite.

TBR=scroggo@chromium.org
BUG= 707647 

Review-Url: https://codereview.chromium.org/2809623002
Cr-Commit-Position: refs/heads/master@{#463223}

[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/000.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/001.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/002.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/003.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/004.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/005.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/006.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/007.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/008.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/009.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/010.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/011.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/012.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/013.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/014.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/015.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/016.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/017.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/018.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/019.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/020.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/021.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/022.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/023.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/024.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/025.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/026.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/027.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/028.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/029.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/030.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/031.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/032.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/033.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/034.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/035.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/036.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/037.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/038.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/039.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/040.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/041.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/042.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/043.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/044.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/045.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/046.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/047.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/048.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/049.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/050.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/051.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/052.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/053.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/054.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/055.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/056.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/057.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/058.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/059.png
[rename] https://crrev.com/d09bddfdb6f6382732f654ca6273d4088c246d51/third_party/WebKit/LayoutTests/images/png-suite/samples/animated/060.png

Comment 9 by noel@chromium.org, Apr 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment