Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42ccb94de63888830e4dfaead1e22cae2ed9a447 commit 42ccb94de63888830e4dfaead1e22cae2ed9a447 Author: pilgrim <pilgrim@chromium.org> Date: Fri Apr 21 16:48:11 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in modules/webgl BUG= 707642 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2833133002 Cr-Commit-Position: refs/heads/master@{#466364} [modify] https://crrev.com/42ccb94de63888830e4dfaead1e22cae2ed9a447/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp [modify] https://crrev.com/42ccb94de63888830e4dfaead1e22cae2ed9a447/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ebd473db575c092f2342e9059d6583201ab9171 commit 8ebd473db575c092f2342e9059d6583201ab9171 Author: pilgrim <pilgrim@chromium.org> Date: Fri Apr 28 18:08:50 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in core/page BUG= 707642 Review-Url: https://codereview.chromium.org/2844223006 Cr-Commit-Position: refs/heads/master@{#468058} [modify] https://crrev.com/8ebd473db575c092f2342e9059d6583201ab9171/third_party/WebKit/Source/core/page/PageVisibilityState.cpp [modify] https://crrev.com/8ebd473db575c092f2342e9059d6583201ab9171/third_party/WebKit/Source/core/page/SpatialNavigation.cpp [modify] https://crrev.com/8ebd473db575c092f2342e9059d6583201ab9171/third_party/WebKit/Source/core/page/TouchAdjustment.cpp [modify] https://crrev.com/8ebd473db575c092f2342e9059d6583201ab9171/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0 commit eb02b0f82a7deac0cde8dbff100fa91dea5d30f0 Author: pilgrim <pilgrim@chromium.org> Date: Fri Apr 28 18:39:14 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in core/frame BUG= 707642 Review-Url: https://codereview.chromium.org/2846273002 Cr-Commit-Position: refs/heads/master@{#468069} [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/DOMWindowTimers.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/Deprecation.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/VisualViewport.cpp [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/VisualViewport.h [modify] https://crrev.com/eb02b0f82a7deac0cde8dbff100fa91dea5d30f0/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/935043d8964a6d85c4e3c943d1640f85bac6a326 commit 935043d8964a6d85c4e3c943d1640f85bac6a326 Author: pilgrim <pilgrim@chromium.org> Date: Fri Apr 28 19:35:26 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in core/paint BUG= 707642 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2845773005 Cr-Commit-Position: refs/heads/master@{#468093} [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/BoxPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/ObjectPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/PaintLayer.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp [modify] https://crrev.com/935043d8964a6d85c4e3c943d1640f85bac6a326/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdf7395bf725acf254fc025b8a14d6f83035435c commit cdf7395bf725acf254fc025b8a14d6f83035435c Author: pilgrim <pilgrim@chromium.org> Date: Mon May 01 22:15:00 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in the rest of core/ BUG= 707642 Review-Url: https://codereview.chromium.org/2846283002 Cr-Commit-Position: refs/heads/master@{#468449} [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/clipboard/DataObject.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/input/EventHandler.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/input/TouchEventManager.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp [modify] https://crrev.com/cdf7395bf725acf254fc025b8a14d6f83035435c/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65003efd91d69d2e4688e4b699dfb1b825683266 commit 65003efd91d69d2e4688e4b699dfb1b825683266 Author: pilgrim <pilgrim@chromium.org> Date: Mon May 01 22:20:40 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in build/scripts/templates/ BUG= 707642 Review-Url: https://codereview.chromium.org/2847203002 Cr-Commit-Position: refs/heads/master@{#468453} [modify] https://crrev.com/65003efd91d69d2e4688e4b699dfb1b825683266/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46b2bede398821330e8901c3f95c5ce33b00213d commit 46b2bede398821330e8901c3f95c5ce33b00213d Author: gyuyoung.kim <gyuyoung.kim@chromium.org> Date: Sat May 13 16:54:47 2017 Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules This CL affects instances of ASSERT() that have biary parameters mainly. Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform. BUG= 707642 , 707638 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2879773002 Cr-Commit-Position: refs/heads/master@{#471594} [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/cachestorage/Cache.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLSharedPlatform3DObject.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLTexture.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLUniformLocation.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBDevice.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBEndpoint.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBInterface.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
Comment 1 by tkent@chromium.org
, Apr 3 2017