Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in core/fileapi, modules/filesystem, modules/indexeddb, modules/quota, modules/storage, modules/webdatabase
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf4fb409e74c24d186de1f337221a72b4634cba6 commit cf4fb409e74c24d186de1f337221a72b4634cba6 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Apr 10 00:41:03 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/filesystem BUG= 707641 Review-Url: https://codereview.chromium.org/2810513002 Cr-Commit-Position: refs/heads/master@{#463160} [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/DOMFileSystemBase.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/FileWriterBase.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp [modify] https://crrev.com/cf4fb409e74c24d186de1f337221a72b4634cba6/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5136172049cbea062e1dcf86fa41fceef13183c3 commit 5136172049cbea062e1dcf86fa41fceef13183c3 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Apr 10 01:07:19 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/indexeddb Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/indexeddb BUG= 707641 Review-Url: https://codereview.chromium.org/2801893008 Cr-Commit-Position: refs/heads/master@{#463162} [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBAny.cpp [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBEventDispatcher.cpp [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBKey.cpp [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBKey.h [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.h [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp [modify] https://crrev.com/5136172049cbea062e1dcf86fa41fceef13183c3/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/718823aa31aecf6aad1751407ac2c55ce26cf88e commit 718823aa31aecf6aad1751407ac2c55ce26cf88e Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Apr 10 01:28:00 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/quota BUG= 707641 Review-Url: https://codereview.chromium.org/2812473002 Cr-Commit-Position: refs/heads/master@{#463163} [modify] https://crrev.com/718823aa31aecf6aad1751407ac2c55ce26cf88e/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp [modify] https://crrev.com/718823aa31aecf6aad1751407ac2c55ce26cf88e/third_party/WebKit/Source/modules/quota/StorageManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99bc0460eec9022684af3ee7386774953186e6a5 commit 99bc0460eec9022684af3ee7386774953186e6a5 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Apr 10 21:31:43 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/core/fileapi BUG= 707641 Review-Url: https://codereview.chromium.org/2804403003 Cr-Commit-Position: refs/heads/master@{#463401} [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/Blob.cpp [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/File.cpp [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/File.h [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/FileError.cpp [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/FileReader.cpp [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/FileReaderLoaderClient.h [modify] https://crrev.com/99bc0460eec9022684af3ee7386774953186e6a5/third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3 commit e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Apr 10 22:49:30 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/storage Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/storage BUG= 707641 Review-Url: https://codereview.chromium.org/2811523002 Cr-Commit-Position: refs/heads/master@{#463430} [modify] https://crrev.com/e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3/third_party/WebKit/Source/modules/storage/Storage.cpp [modify] https://crrev.com/e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3/third_party/WebKit/Source/modules/storage/StorageArea.cpp [modify] https://crrev.com/e99b6cfcee3c0d8f7bbd23d308bdd9fe72d0e1e3/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/226bee734ae45ec8634e1b1d9448cdce97d32290 commit 226bee734ae45ec8634e1b1d9448cdce97d32290 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Tue Apr 11 08:39:47 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/webdatabase BUG= 707641 Review-Url: https://codereview.chromium.org/2813433002 Cr-Commit-Position: refs/heads/master@{#463576} [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/Database.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLResultSet.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLResultSetRowList.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLValue.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.h [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemPosix.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystemWin.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp [modify] https://crrev.com/226bee734ae45ec8634e1b1d9448cdce97d32290/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp
missing ASSERT_NOT_REACHED() in modules/indexeddb https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h?type=cs&q=ASSERT_NOT_REACHED++file:%5Esrc/third_party/WebKit/Source/modules/indexeddb+package:%5Echromium$&l=123
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f4782f04c3766c34a6ee1fbc69bd815d724e977 commit 0f4782f04c3766c34a6ee1fbc69bd815d724e977 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Fri Apr 14 10:28:44 2017 Replace ASSERT_NOT_REACHED in modules/indexeddb Replace ASSERT_NOT_REACHED with NOTREACHED respectively in third_party/WebKit/Source/modules/indexeddb BUG= 707641 Review-Url: https://codereview.chromium.org/2810333005 Cr-Commit-Position: refs/heads/master@{#464711} [modify] https://crrev.com/0f4782f04c3766c34a6ee1fbc69bd815d724e977/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
Comment 1 by tkent@chromium.org
, Apr 3 2017