Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41a37b9e82b9f33982f6add34906fed081303ca9 commit 41a37b9e82b9f33982f6add34906fed081303ca9 Author: pilgrim <pilgrim@chromium.org> Date: Mon May 01 17:35:32 2017 Replace ASSERT with DCHECK in platform/ This CL only affects instances of ASSERT() that have unary parameters with no (in)equality checks. BUG= 707638 Review-Url: https://codereview.chromium.org/2846303002 Cr-Commit-Position: refs/heads/master@{#468346} [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/AsyncMethodRunner.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Crypto.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/DateComponents.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Decimal.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Decimal.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/DecimalTest.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/DragImageTest.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/EventDispatchForbiddenScope.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Language.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/LayoutTestSupport.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Length.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Length.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/LifecycleContextTest.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/LifecycleNotifier.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/LinkHash.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/PODRedBlackTree.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/PluginScriptForbiddenScope.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/Timer.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/WebThreadSupportingGC.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/blob/BlobURL.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/geometry/FloatPolygon.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/geometry/FloatPolygon.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/geometry/TransformState.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/geometry/TransformState.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/heap/ThreadState.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/image-encoders/PNGImageEncoder.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mediastream/MediaStreamWebAudioSource.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mhtml/ArchiveResource.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/transforms/ScaleTransformOperation.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/transforms/TranslateTransformOperation.h [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.cc [modify] https://crrev.com/41a37b9e82b9f33982f6add34906fed081303ca9/third_party/WebKit/Source/platform/wtf/text/StringImplCF.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e31774e6d1d019722ddd281617a76ecc907f86c commit 3e31774e6d1d019722ddd281617a76ecc907f86c Author: pilgrim <pilgrim@chromium.org> Date: Mon May 01 21:51:52 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in platform/ BUG= 707638 Review-Url: https://codereview.chromium.org/2849903002 Cr-Commit-Position: refs/heads/master@{#468434} [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/AsyncFileSystemCallbacks.h [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/Crypto.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/DateComponents.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/Decimal.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/Length.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/Length.h [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/LengthFunctions.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/SharedBuffer.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/StorageQuotaCallbacks.h [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/animation/TimingFunction.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/scroll/ScrollTypes.h [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp [modify] https://crrev.com/3e31774e6d1d019722ddd281617a76ecc907f86c/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46b2bede398821330e8901c3f95c5ce33b00213d commit 46b2bede398821330e8901c3f95c5ce33b00213d Author: gyuyoung.kim <gyuyoung.kim@chromium.org> Date: Sat May 13 16:54:47 2017 Replace remaining ASSERT with DCHECK|DCHECK_FOO in modules This CL affects instances of ASSERT() that have biary parameters mainly. Additionally two uses of DCHECK() is changed with DCHECK_EQ() in platform. BUG= 707642 , 707638 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2879773002 Cr-Commit-Position: refs/heads/master@{#471594} [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/cachestorage/Cache.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/crypto/CryptoKey.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLSharedPlatform3DObject.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLTexture.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webgl/WebGLUniformLocation.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBDevice.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBEndpoint.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/modules/webusb/USBInterface.cpp [modify] https://crrev.com/46b2bede398821330e8901c3f95c5ce33b00213d/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
Comment 1 by tkent@chromium.org
, Apr 3 2017