New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707634 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to change 'Destination' printer in print preview.

Reported by avsha...@etouch.net, Apr 3 2017

Issue description

Chrome Version : 59.0.3060.0 (Official Build) 01b9eb705b9a43196ad06435d7a37a3fb36529d7-refs/heads/master@{#461328} 32/64 bit
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome, open NTP give print command using 'Ctrl + P' keys.
2. In print preview window, try to change 'Destination' printer, observe.

Actual : Unable to change 'Destination' printer in print preview.
Expected : User should be able to change the printer.

This is a regression issue broken in ‘M-59’, below is the Manual Regression range and will soon update other info.
Good build : 59.0.3059.0
Bad build : 59.0.3060.0

Note : Will soon update Mac and Linux OS info.
 
Actual_Print.mp4
906 KB View Download
Expected_Print.mp4
954 KB View Download
Labels: OS-Linux OS-Mac
Update : 

Above issue is also reproducible on Linux(14.04 LTS) and Mac(10.11.6, 10.12.1, 10.12) OS using #59.0.3060.0 canary build.

Thank you.
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Dev
Owner: x...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3059.0 (Revision:461269).
Bad build:59.0.3060.0 (Revision:461328).

You are probably looking for a change made after 461309 (known good), but no later than 461310 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/c4dab7a401b27b39bfc8798751462fda6f20a7db..89ca6553d7d8d0303bfef17d17c20e0814b9ede2

From the CL above, assigning the issue to the concern owner

@xdai: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2760753002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3060.0
Adding Release Block-Dev for this issue.Please remove if not the case.
Cc: manoranj...@chromium.org abdulsyed@chromium.org ajha@chromium.org

Comment 4 by x...@chromium.org, Apr 3 2017

Sorry! It was caused by my CL. 
I have a very simple fix: https://codereview.chromium.org/2796603002/ 
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b53ec368dfffde2441b14afaae376f36bd906f2

commit 3b53ec368dfffde2441b14afaae376f36bd906f2
Author: xdai <xdai@chromium.org>
Date: Mon Apr 03 08:09:22 2017

CUPS: Fix the Print Preview UI regression.

It's a regression caused by https://codereview.chromium.org/2760753002/. I forgot the function invocation "this".

BUG= 707634 
TBR=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796603002
Cr-Commit-Position: refs/heads/master@{#461385}

[modify] https://crrev.com/3b53ec368dfffde2441b14afaae376f36bd906f2/chrome/browser/resources/print_preview/search/destination_list_item.js

Comment 6 by x...@chromium.org, Apr 3 2017

Status: Fixed (was: Assigned)
xdai@, can you please merge this fix to 3061 branch? I would like to trigger a new Dev RC w/ this fix.

PS: You do not need to follow any 'Merge-Approval' process since 3061 is yet to be branched officially.

Thank you!
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 4 2017

Labels: merge-merged-3061
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6980a49d3a55296ebeda6d724673686abe6bafd6

commit 6980a49d3a55296ebeda6d724673686abe6bafd6
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Apr 04 02:04:30 2017

CUPS: Fix the Print Preview UI regression.

It's a regression caused by https://codereview.chromium.org/2760753002/. I forgot the function invocation "this".

BUG= 707634 
TBR=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796603002
Cr-Commit-Position: refs/heads/master@{#461385}
(cherry picked from commit 3b53ec368dfffde2441b14afaae376f36bd906f2)

Review-Url: https://codereview.chromium.org/2796793002 .
Cr-Commit-Position: refs/branch-heads/3061@{#6}
Cr-Branched-From: 9e03960f75b3019372157db5c4fe5264dfc36616-refs/heads/master@{#461353}

[modify] https://crrev.com/6980a49d3a55296ebeda6d724673686abe6bafd6/chrome/browser/resources/print_preview/search/destination_list_item.js

verify this issue on Windows 10 and Mac 10.12.4 with chrome #59.0.3061.3, observed the fix is working as expected.

Attaching the screencast for reference.

Note:
------
Once linux builds are available, will verify them linux and add TE-verified labels. 
Issue 707634.mp4
964 KB View Download
Status: Verified (was: Fixed)

Sign in to add a comment