New issue
Advanced search Search tips

Issue 707633 link

Starred by 1 user
Status: Fixed
Owner:
jfernan...@igalia.com
Closed: May 2017
Cc:
jfernan...@igalia.com
r...@igalia.com
svil...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 79180



Sign in to add a comment

[css-grid] Ignore collapsed tracks for content distribution

Project Member Reported by r...@igalia.com, Apr 3 2017 

The spec has been recently updated as you can see in the following discussion:
https://github.com/w3c/csswg-drafts/issues/1140

The main issue here is that we shouldn't take into account the collapsed tracks for gutters when we do the Content Distribution.

Comment 1 by jfernan...@igalia.com, Apr 5 2017

Owner: jfernan...@igalia.com
Status: Started (was: Available)
I'll start working on this bug.
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/032e6e69429f3d726bcf71d342752a7f04824533

commit 032e6e69429f3d726bcf71d342752a7f04824533
Author: jfernandez <jfernandez@igalia.com>
Date: Tue May 02 11:31:06 2017

[css-grid] Ignore collapsed tracks on content-distribution alignment

The CSS Box Alignment spec states that we should ignore the collapsed
tracks when computing the Distribution Alignment space to assign to the
different grid tracks.

BUG= 707633 

Review-Url: https://codereview.chromium.org/2825133003
Cr-Commit-Position: refs/heads/master@{#468598}

[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-001.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-002.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-003.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-004.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-006.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-007.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-008.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-009.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-010.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-011.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-012.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-013.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-014.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-015.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-016.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-017.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-018.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-019.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-020.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-021.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-022.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-023.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-024.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-025.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-001.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-002.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-003.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-004.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-005.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-006.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-007.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-008.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-009.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-010.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-011.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-012.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-013.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-014.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-015.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-016.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-017.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-018.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-019.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-020.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-021.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-023.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-024.html
[add] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/LayoutTests/external/wpt/css/reference/ref-filled-green-300px-square.html
[modify] https://crrev.com/032e6e69429f3d726bcf71d342752a7f04824533/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Comment 3 by jfernan...@igalia.com, May 2 2017 

This bug should be FIXED now.

Comment 4 by jfernan...@igalia.com, May 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment