Compactify dialog headers
Reported by
rp...@etouch.net,
Apr 3 2017
|
|||||||
Issue descriptionVersion: 59.0.3060.0 01b9eb705b9a43196ad06435d7a37a3fb36529d7-refs/heads/master@{#461328} OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings/languages 2. Now expand 'Languages' and click on 'Add Languages' to open overlay and scroll down the list using mouse wheel and observe 'Add Languages' header line Actual: Unnecessary grey shadow is seen under header line in 'Add Languages' overlay after scrolling down 'Languages' list Expected: Unnecessary grey shadow should not be seen under header line in 'Add Languages' overlay after scrolling down 'Languages' list This is regression issue, broken in ‘M 59’ and will soon update other info : Good build:59.0.3056.0 Bad build: 59.0.3057.0
,
Apr 3 2017
,
Apr 3 2017
for all dialogs: remove bottom border and reduce padding/font size of headers for scrollable dialogs: remove the padding top/bottom of dialog bodies assigning to bettes@ for specs
,
Apr 3 2017
regarding "remove bottom border" for headers - should scrollable dialogs now have the border-top on the dialog body when there's stuff to scroll up to? currently it only adds a conditional border-bottom and not -top because it was assumed the header border's always going to be there.
,
Apr 4 2017
Hey Scott, To prepare us for future harmony design edits, I think it's best to remove the default bottom border for headers and allow the border to be drawn in conditionally for scrollable dialogs. So to answer your question in 4: I believe the answer is "yes." Header bottom borders will not exist in this new design so there should be conditional borders on top and bottom. - shrink close-x from 20px to 16px (36px ripple) - Title text should be 15pt. (inspect shows 15.999px?) - ensure title-text padding is 16 16 16 24 - With title text and new padding, title banner should equal 47px (15+16+16) >> for scrollable dialogs: remove the padding top/bottom of dialog bodies This is not true. Just cut it down from 12px to 8px.
,
Apr 5 2017
,
Apr 6 2017
I've made a CL that hits most of the stuff mentioned above, except for one: Due to weirdness in how <paper-input> display error-messages, if we shrink the dialog body padding, then it will start to show unnecessary scroll-bars on many dialog body at medium font (it's currently already a problem for large font). dpapad@ and I talked about paper-input's error-message display issue but we were not able to reach a good solution, so I'll be leaving dialog body padding at 12px for now to avoid regression bugs. I believe we'll be okay with launching beta with 12px body padding, and we can address it later when we find a good solution to deal with paper-input error message.
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fee40485e1568f0a7121576d722f2b66a5832c65 commit fee40485e1568f0a7121576d722f2b66a5832c65 Author: scottchen <scottchen@chromium.org> Date: Mon Apr 10 19:54:34 2017 MD Settings: adjust dialog style and scroll border visual BUG= 707631 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2795763003 Cr-Commit-Position: refs/heads/master@{#463373} [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/chrome/test/data/webui/cr_elements/cr_dialog_test.js [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/fee40485e1568f0a7121576d722f2b66a5832c65/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Apr 12 2017
Everything requested are in tip of tree, except for .body padding-top/bottom for reasons stated above. Marking as Fixed, and will open another bug for addressing paper-input error-message messing up layouts, and will include the body style in there. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msrchandra@chromium.org
, Apr 3 2017Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)