New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707631 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Compactify dialog headers

Reported by rp...@etouch.net, Apr 3 2017

Issue description

Version: 59.0.3060.0 01b9eb705b9a43196ad06435d7a37a3fb36529d7-refs/heads/master@{#461328}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/languages
2. Now expand 'Languages' and click on 'Add Languages' to open overlay and scroll down the list using mouse wheel and observe 'Add Languages' header line

Actual: Unnecessary grey shadow is seen under header line in 'Add Languages' overlay after scrolling down 'Languages' list
Expected: Unnecessary grey shadow should not be seen under header line in 'Add Languages' overlay after scrolling down 'Languages' list

This is regression issue, broken in ‘M 59’ and will soon update other info :
Good build:59.0.3056.0
Bad build: 59.0.3057.0
 
Actual_video.mp4
362 KB View Download
Expected_video.mp4
312 KB View Download
Actual_screenshot.png
170 KB View Download
Expected_screenshot.png
171 KB View Download
Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 59.0.3056.0 (Revision: 460603).
Bad build : 59.0.3057.0 (Revision: 460966).

You are probably looking for a change made after 460936 (known good), but no later than 460937 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d0203954892c94a15b4f5843bdc519b2be81f0bc..27793e2b00cd4f06e24cde9599be5693006ed02b

@scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Status: Started (was: Assigned)

Comment 3 by dbeam@chromium.org, Apr 3 2017

Labels: Hotlist-MD-Settings-General
Owner: bettes@chromium.org
Status: Assigned (was: Started)
Summary: Compactify dialog headers (was: Regression : Unnecessary grey shadow is seen under header line in chrome://md-settings/languages.)
for all dialogs: remove bottom border and reduce padding/font size of headers

for scrollable dialogs: remove the padding top/bottom of dialog bodies

assigning to bettes@ for specs
regarding "remove bottom border" for headers - should scrollable dialogs now have the border-top on the dialog body when there's stuff to scroll up to? currently it only adds a conditional border-bottom and not -top because it was assumed the header border's always going to be there.
Owner: scottchen@chromium.org
Hey Scott,

To prepare us for future harmony design edits, I think it's best to remove the default bottom border for headers and allow the border to be drawn in conditionally for scrollable dialogs. 

So to answer your question in 4: I believe the answer is "yes." Header bottom borders will not exist in this new design so there should be conditional borders on top and bottom. 

- shrink close-x from 20px to 16px (36px ripple)
- Title text should be 15pt. (inspect shows 15.999px?)
- ensure title-text padding is 16 16 16 24
- With title text and new padding, title banner should equal 47px (15+16+16)

>> for scrollable dialogs: remove the padding top/bottom of dialog bodies

This is not true. Just cut it down from 12px to 8px. 

Artboard 2.png
137 KB View Download

Comment 6 Deleted

Status: Started (was: Assigned)
Cc: dschuyler@chromium.org dpa...@chromium.org
I've made a CL that hits most of the stuff mentioned above, except for one:
Due to weirdness in how <paper-input> display error-messages, if we shrink the dialog body padding, then it will start to show unnecessary scroll-bars on many dialog body at medium font (it's currently already a problem for large font).

dpapad@ and I talked about paper-input's error-message display issue but we were not able to reach a good solution, so I'll be leaving dialog body padding at 12px for now to avoid regression bugs.

I believe we'll be okay with launching beta with 12px body padding, and we can address it later when we find a good solution to deal with paper-input error message.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 10 2017

Status: Fixed (was: Started)
Everything requested are in tip of tree, except for .body padding-top/bottom for reasons stated above. Marking as Fixed, and will open another bug for addressing paper-input error-message messing up layouts, and will include the body style in there.

Sign in to add a comment