WebApk doesn't navigate to deep links |
|||
Issue descriptionGoogle Chrome 59.0.3057.0 (Official Build) canary (32-bit) Revision a064840eb26683687c53dc6fa6b5c29a2c418b5c-refs/heads/master@{#460966} OS Android 7.1.2; Pixel XL Build/N2G47E What steps will reproduce the problem? (1) go to Twitter.com (2) save to home screen the web apk (3) google search for a hash tag (ex. https://www.google.com/search?q=boycottthebefore+twitter) (4) tap the search result. What is the expected result? Twitter pwa should launch navigated to the search result for that hash tag. What happens instead? Twitter launches but does not navigate. All deep linking appears to be busted.
,
Apr 3 2017
This is because the ShellApk needs to be updated on the server side
,
Apr 3 2017
This is because the ShellApk needs to be updated on the server side I should have been more careful in landing https://codereview.chromium.org/2758193002/
,
Apr 3 2017
,
Apr 6 2017
Now that we're vending shell apk v2 everywhere, can this be closed?
,
Apr 6 2017
And chrome dev is fixed for me
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c23219e84056a088a4808da38d3c92c79018be93 commit c23219e84056a088a4808da38d3c92c79018be93 Author: pkotwicz <pkotwicz@chromium.org> Date: Thu Apr 06 20:51:23 2017 [Android WebAPKs] Force navigation on launch by default https://codereview.chromium.org/2758193002/ added EXTRA_WEBAPK_FORCE_NAVIGATION to enable WebAPK to specify whether to navigate the WebAPK to the start URL in the intent if the WebAPK is already running (WebApkActivity#onNewIntent). This CL fixes a regression caused by https://codereview.chromium.org/2758193002/ where the WebAPK would not navigate to the passed in URL if EXTRA_WEBAPK_FORCE_NAVIGATION is not specified. In particular, this broke deep links for WebAPKs which have not yet updated. BUG= 707590 Review-Url: https://codereview.chromium.org/2796773002 Cr-Commit-Position: refs/heads/master@{#462612} [modify] https://crrev.com/c23219e84056a088a4808da38d3c92c79018be93/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java [modify] https://crrev.com/c23219e84056a088a4808da38d3c92c79018be93/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java
,
Apr 7 2017
,
Apr 10 2017
I'm still seeing this bug in canary. When I tap a push notification the Twitter web apk refreshes and doesn't navigate to the deep link.
,
Apr 12 2017
When I do a search for #rains or #california in Chrome (59.0.3068.4) and tap on the twitter search result, Twitter Lite WebApp opens the intended page. Tested on S7 / NRD90M and LG G4 / MRA58K. Like I mentioned earlier to pkotwicz@ , on some devices my twitter search result is marked with 'Open with twitter.com' and it always opens in Chrome and never launches the WebApp.
,
Apr 12 2017
This seems fixed when coming from Chrome, but is broken when coming from push notifications, I moved that to issue 711011 .
,
Apr 19 2017
Comment #10: askatte@ sorry about the delay. I am forking the issue with "Open with twitter.com" to 713333 I have been unable to get the Google Search results to say "Open with twitter.com" though I have been able to get them to say "Open with twitter app" (I have been able to get the Google search results to say "Open with twitter app" if I uninstall the twitter app while Chrome is running) When the search results say "Open with twitter app", the URL is an intent:// URL which is why the WebAPK does not handle it |
|||
►
Sign in to add a comment |
|||
Comment 1 by sbirch@chromium.org
, Apr 3 2017