New issue
Advanced search Search tips

Issue 707570 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Resize icons

Reported by kaingard...@gmail.com, Apr 2 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 9413.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3054.0 Safari/537.36

Steps to reproduce the problem:
1. Open settings in Chrome OS
2. Observe settings icon/shortcut appear on shelf
3. Compare icon dimensions to Chrome browser icon

What is the expected behavior?
Icon resizing is common in android launchers.
Applying some kind of icon normalization (e.g. scale all icons to fit within an n pixel circle) would create a more consistent visual experience for users.

What went wrong?
Nothing.

Did this work before? N/A 

Chrome version: 59.0.3054.0  Channel: dev
OS Version: 9413.0.0
Flash Version: 9413.0.0 (Official Build) dev-channel swanky
 
Screenshot 2017-04-02 at 8.44.11 PM.png
910 KB View Download
Owner: sgabr...@chromium.org
Status: Assigned (was: Unconfirmed)
<triage> Hi Sebastien, could you take a look at this one?
Owner: weifangsun@chromium.org
There is no normalization happening here this is a Chrome OS native icon. 
I do not notice this issue on a 2x device. Checked assets seem to be delivered in the proper size: https://drive.google.com/drive/folders/0B6x6iYCtKinETkZya0VJZy1TcTg?usp=sharing

@Weifang can you check if repro on 1x device and check with eng ?
Cc: weifangsun@chromium.org tbuck...@chromium.org
Owner: steve...@chromium.org
Verified this behavior on a 1x device. stevejb@, could you please take a look?
Cc: sgabr...@chromium.org steve...@chromium.org
Owner: sgabr...@chromium.org
This looks like it is WAI to me. The Chrome icon and Settings icon appear to be the same relative size in that image as they are on a Pixel.

(FWIW, the Settings icon is the same size as the File icon, which is slightly smaller than the Chrome and Play Store icons; I assume that is as intended).

sgabriel@ please confirm.

@stevenjb the Settings icon appears to be bigger than both Chrome and Files.app in that screenshot: https://screenshot.googleplex.com/W5aQFB9ffK7
can you attach a screenshot? I have not 1x device handy.
Then I'm wondering what caused the issue in #0
Thanks Tom, it is bigger indeed. Did we check the proper assets available here:
https://drive.google.com/drive/folders/0B6x6iYCtKinETkZya0VJZy1TcTg?usp=sharing

The one we should be using for 1x shelf is "settings_app_icon_32.png"
Are we using separated assets or are we scaling the 128?

Components: -UI UI>Shell>Shelf Design

Comment 9 by vadimt@chromium.org, Nov 28 2017

Labels: Touch-Friendly-Launcher Touch-Friendly-Launcher-Triaged
Cc: newcomer@chromium.org
Mergedinto: 848007
Status: Duplicate (was: Assigned)

Sign in to add a comment