Long filename or title kills "Save as PDF" dialog
Reported by
dawpas2...@gmail.com,
Apr 1 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36 Steps to reproduce the problem: 1. Open "longTitle.html" or a page with a very long title. 2. Print. 3. Save as PDF. 4. Save. This also affects filename generation with a blank title, which is another way to reproduce the bug. To make a filename longer for a page with a blank title, add a period to a query string. Weirdly, the presence of a period changes the filename by including the query string. Notice the difference between a missing period and a period: /blankTitle.html?111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111a Effect: Filename generator ignores query string. /blankTitle.html?111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111111.a Effect: Filename generator includes long query string, which reproduces the bug. What is the expected behavior? "Save as" dialog should appear. What went wrong? "Save as" dialog does not appear. "Save" button does not work. Did this work before? N/A Chrome version: 57.0.2987.98 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 25.0 r0
,
Apr 4 2017
Able to reproduce the issue on Windows 10, MAC 10.12.3, Ubuntu 14.04. Issue is a non regression as seen from M24 version of chrome 24.0.1300.0. Untriaged it so that it gets addressed. Thanks.!
,
Apr 5 2017
On Windows the failure is happening in GetOpenFileName - the default filename for these pages is longer than the OS limit. Likely the same issue on Linux/Mac. We need to truncate filenames longer than 255 characters.
,
Apr 6 2017
RE: comment 2 - cannot reproduce this with the longTitle.html and blankTitle.html files on Linux (Ubuntu 14.04). Did you use a different test case?
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5be563564bd38f1f8355406a658ff93bc71027a commit e5be563564bd38f1f8355406a658ff93bc71027a Author: rbpotter <rbpotter@chromium.org> Date: Thu Apr 20 17:44:19 2017 Print Preview: Fix failure to save with long page title BUG= 707538 Review-Url: https://codereview.chromium.org/2804793002 Cr-Commit-Position: refs/heads/master@{#466053} [modify] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/chrome/browser/ui/webui/print_preview/print_preview_handler.h [add] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/chrome/browser/ui/webui/print_preview/print_preview_handler_win_unittest.cc [modify] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/chrome/test/BUILD.gn [modify] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/ui/shell_dialogs/BUILD.gn [modify] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/ui/shell_dialogs/select_file_dialog.cc [modify] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/ui/shell_dialogs/select_file_dialog.h [add] https://crrev.com/e5be563564bd38f1f8355406a658ff93bc71027a/ui/shell_dialogs/select_file_dialog_unittest.cc
,
May 1 2017
Tested on Canary (60.0.3086.0) on Windows 10. The silent failure is fixed; the system save as dialog now appears and prompts the user to change the name if it is too long. Since we were never able to reproduce this on Linux, not sure if it is fixed there or not. Is this still an issue on any of the platforms?
,
May 9 2017
,
Jul 1 2017
Let's call it done. If there are still problems with this on Linux/Mac, please say so. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Apr 3 2017