Timav: Could you help find an owner for this issue? Could https://codereview.chromium.org/2740103006 be related?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e272b699ad6aeb171ed6d4433d8caf1212fb424d

commit e272b699ad6aeb171ed6d4433d8caf1212fb424d
Author: maxmorin <maxmorin@chromium.org>
Date: Tue Apr 04 09:11:29 2017

Disable flaky ContextualSearchManagerTest#testHidesWhenOmniboxFocused.

TBR=donnd@chromium.org
BUG=707529

Review-Url: https://codereview.chromium.org/2794253002
Cr-Commit-Position: refs/heads/master@{#461666}

[modify] https://crrev.com/e272b699ad6aeb171ed6d4433d8caf1212fb424d/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

It looks like this has been flaking for a while and just hit the threshold for tryflakes to report.

It's possible that this is related to the errors we were seeing after wnwen@'s changes to make tests startup faster, because the timeout is happening due to the omnibox not being focusable. OmniboxTestUtils#toggleUrlBarFocus has this comment:

// During early startup (before completion of its first onDraw), the UrlBar
// is not focusable. Tests have to wait for that to happen before trying to focus it.


org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest#testHidesWhenOmniboxFocused (run #1):
junit.framework.AssertionFailedError: UrlBar was not focusable
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138)
	at org.chromium.chrome.test.util.OmniboxTestUtils.toggleUrlBarFocus(OmniboxTestUtils.java:291)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testHidesWhenOmniboxFocused(ContextualSearchManagerTest.java:1106)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Deleted: Screen Shot 2017-04-04 at 8.54.52 AM.png 86.6 KB

	Screen Shot 2017-04-04 at 8.54.52 AM.png 86.6 KB View Download

It does look like this got a lot more flaky on the 30th, which correlates with when Tima's change landed, so it's possible they are related.

It appears that the Contextual Search test is the only one failing when calling the OmniboxTestUtils method.

setUp() now takes longer. Can it be the reason?

It would be interesting to run the test w/ and w/out the setup change to see if that's to blame.

c#6: Sorry, I was referring to the wrong test.

I cannot think of anything obvious without actually debugging.

From reading your comments, is there a way to reliably wait for until the omnibox becomes focusable before

https://cs.corp.google.com/clankium/src/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java?rcl=0&l=1106

It would be more reliable to wait for a callback rather than relying on polling. It's odd that all of sudden the omnibox isn't focusable in the default timeout duration, though.