"NoStatePrefetchBrowserTest.AppCacheHtmlInitialized" is flaky |
|||||
Issue description"NoStatePrefetchBrowserTest.AppCacheHtmlInitialized" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJOb1N0YXRlUHJlZmV0Y2hCcm93c2VyVGVzdC5BcHBDYWNoZUh0bWxJbml0aWFsaXplZAw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 3 2017
I haven't worked on this code in years, and am completely unfamiliar with this test.
,
Apr 3 2017
Detected 3 new flakes for test/step "NoStatePrefetchBrowserTest.AppCacheHtmlInitialized". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPQsSBUZsYWtlIjJOb1N0YXRlUHJlZmV0Y2hCcm93c2VyVGVzdC5BcHBDYWNoZUh0bWxJbml0aWFsaXplZAw. This message was posted automatically by the chromium-try-flakes app.
,
Apr 3 2017
[+mattcary]: Hard to imagine this is unrelated to https://codereview.chromium.org/2642733002 That landed Friday, when the first failure was, and is related to appcache + prerendering.
,
Apr 4 2017
,
Apr 4 2017
Yup, I have to agree with Matt M's assessment. I'll take a look.
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c17879886146bbb41cb4435f275ebdbc0f70903a commit c17879886146bbb41cb4435f275ebdbc0f70903a Author: timloh <timloh@chromium.org> Date: Tue Apr 04 08:40:32 2017 Revert of Prerender: Disable prefetch if there's an appcache. (patchset #7 id:120001 of https://codereview.chromium.org/2642733002/ ) Reason for revert: Appears to make NoStatePrefetchBrowserTest.AppCacheHtmlInitialized and NoStatePrefetchBrowserTest.AppCacheRegistered flaky. Original issue's description: > Prerender: Disable prefetch if there's an appcache. > > Stops the preload scanner if an appcache manifest is detected and the document > is prefetching. > > BUG= 632368 > > Review-Url: https://codereview.chromium.org/2642733002 > Cr-Commit-Position: refs/heads/master@{#461081} > Committed: https://chromium.googlesource.com/chromium/src/+/d741ab419a18a996643c568434e0a756eaf7bee6 TBR=droger@chromium.org,csharrison@chromium.org,michaeln@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 632368 , 707522 Review-Url: https://codereview.chromium.org/2790323003 Cr-Commit-Position: refs/heads/master@{#461662} [modify] https://crrev.com/c17879886146bbb41cb4435f275ebdbc0f70903a/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc [modify] https://crrev.com/c17879886146bbb41cb4435f275ebdbc0f70903a/chrome/browser/prerender/prerender_test_utils.cc [modify] https://crrev.com/c17879886146bbb41cb4435f275ebdbc0f70903a/chrome/browser/prerender/prerender_test_utils.h [delete] https://crrev.com/b0c201c3dd37577f185f97bd397c4a8012ce17bc/chrome/test/data/prerender/appcache.manifest [delete] https://crrev.com/b0c201c3dd37577f185f97bd397c4a8012ce17bc/chrome/test/data/prerender/appcache.manifest.mock-http-headers [delete] https://crrev.com/b0c201c3dd37577f185f97bd397c4a8012ce17bc/chrome/test/data/prerender/prefetch_appcache.html [modify] https://crrev.com/c17879886146bbb41cb4435f275ebdbc0f70903a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
,
Apr 4 2017
Doesn't seem to flake after the revert.
,
Apr 18 2017
,
Apr 18 2017
Findit confirms https://codereview.chromium.org/2642733002 as the culprit according to analysis https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyogELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJsY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKDEpLzY1NTEyL2Jyb3dzZXJfdGVzdHMvVG05VGRHRjBaVkJ5WldabGRHTm9Rbkp2ZDNObGNsUmxjM1F1UVhCd1EyRmphR1ZTWldkcGMzUmxjbVZrDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Thanks for the revert! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by anthonyvd@chromium.org
, Apr 3 2017