Issue metadata
Sign in to add a comment
|
Commit Bot message still refers to unvote of Commite Queue label |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Click the CQ Dry Run button in the top right. (2) Wait for dry run to complete. What is the expected result? The dry-run button should be available for clicking again, and no confusing messages should be there. What happens instead? The dry-run button is available, but there is a confusing messagee: "Please, unvote/vote on Commit Queue label to re-trigger on the same patchset." The reason why it is confusing, is that the unvote happens automatically. Example CL: https://chromium-review.googlesource.com/c/465352/ Initial e-mail about review: ### Patch Set 1: Commit-Queue+1 dtrainor: PTAL ### The CQ dry run then started like expected, and added itself to CC. When it was finished, the following happened: ### MESSAGE 1 Commit Bot on behalf of Tommy Nyquist Patch Set 1: -Commit-Queue ### MESSAGE 2 Commit Bot Patch Set 1: Dry run: This issue passed the CQ dry run. Please, unvote/vote on Commit Queue label to re-trigger on the same patchset. Bot data: {"action": "cancel", "triggered_at": "2017-03-31T23:37:46.0Z", "revision": "8776724ae14fffde8762d1de800f2fe980a2ddde"} ### The confusing message: "Please, unvote/vote on Commit Queue label to re-trigger on the same patchset." I went looking for how to unvote, but after a while I realized it had already been done. So maybe we can remove or reword this message if this was a recent change to how the CQ works?
,
Apr 7 2017
,
Apr 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/52213773ceba91ac3ade43a0cde3ca2e8e60a6eb commit 52213773ceba91ac3ade43a0cde3ca2e8e60a6eb Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 11 23:33:51 2017
,
Apr 11 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by andyb...@chromium.org
, Apr 7 2017Status: Assigned (was: Unconfirmed)