New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707490 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

deploy will report error when there's no results for 'git log ... |grep autotest'

Project Member Reported by xixuan@chromium.org, Apr 1 2017

Issue description

When two deployment is close, maybe there's no autotest commit. But deployment should still continue. Now it will raise error like:

Getting pushed CLs for autotest repo.
Running command: git log --oneline 9c4a4339f..cd3012246|grep autotest
ERROR: 'git log --oneline 9c4a4339f..cd3012246|grep autotest' failed with error:

Deploy fails when running a subprocess cmd :

Below is the push log:


Traceback (most recent call last):
  File "./automated_deploy.py", line 194, in <module>
    sys.exit(main(sys.argv))
  File "./automated_deploy.py", line 174, in main
    update_log += get_pushed_commits(repo, repo_dir, push_commits_range)
  File "./automated_deploy.py", line 139, in get_pushed_commits
    pushed_commits = infra.local_runner(get_commits_cmd, stream_output=True)
  File "/usr/local/google/home/xixuan/chromiumos-backup-never-delete/src/third_party/autotest/files/site_utils/lib/infra.py", line 60, in local_runner
    raise subprocess.CalledProcessError(return_code, cmd, output[:1024])
subprocess.CalledProcessError: Command 'git log --oneline 9c4a4339f..cd3012246|grep autotest' returned non-zero exit status 1

 
Labels: -Restrict-View-Google Hotlist-Fixit
Nothing RVG here.

Comment 2 by xixuan@chromium.org, Jun 21 2017

Owner: xixuan@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6d782dce7e47f77a489d5f131257474b503d098e

commit 6d782dce7e47f77a489d5f131257474b503d098e
Author: xixuan <xixuan@chromium.org>
Date: Fri Jun 23 17:19:29 2017

autotest: Not raise error when there's no commmited autotest changes.

BUG= chromium:707490 
TEST=Ran unittest.

Change-Id: I5a71e471ace4e08af078480e68b8f4381a5a725f
Reviewed-on: https://chromium-review.googlesource.com/544120
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/6d782dce7e47f77a489d5f131257474b503d098e/site_utils/automated_deploy.py
[modify] https://crrev.com/6d782dce7e47f77a489d5f131257474b503d098e/site_utils/automated_deploy_unittest.py

Comment 4 by xixuan@chromium.org, Jun 26 2017

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment