New issue
Advanced search Search tips

Issue 707487 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

cr-network-list should support UI language switching.

Project Member Reported by alemate@chromium.org, Apr 1 2017

Issue description

<cr-network-list>, which is used in ChromeOS OOBE doesn't support language switching. It seems to use whatever strings were sent from the C++ side and these are not updated after language switch. As a result, I see network connection status in incorrect language.

This looks like a regression after  issue 670767 .
 
Cc: steve...@chromium.org
Owner: alemate@chromium.org
We will need to detect the language change and update the strings passed to the object.

alemate@, do you have bandwidth for this? I'm a bit swamped with Settings issues for 59 at the moment.

Currently those strings are set here:
https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/oobe_welcome.js?type=cs&q=CrOncStrings&l=104

(Note, in Settings and other Chrome UI, language changes do not take effect until after a restart).

Components: UI>Shell>OOBE
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261a0b276f6d7725877f735cc516d95182e5e360

commit 261a0b276f6d7725877f735cc516d95182e5e360
Author: alemate <alemate@chromium.org>
Date: Fri Apr 07 01:05:41 2017

ChromeOS OOBE: cr-network-list strings must be updated on UI language change.

BUG= 707487 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796343004
Cr-Commit-Position: refs/heads/master@{#462722}

[modify] https://crrev.com/261a0b276f6d7725877f735cc516d95182e5e360/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/261a0b276f6d7725877f735cc516d95182e5e360/chrome/browser/resources/chromeos/login/oobe_welcome.js

Labels: Merge-Request-58
Status: Fixed (was: Started)
Pls add appropriate OSs label.
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 11 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6f96b9681e15465d6d53f362c30ce18c0fde382

commit d6f96b9681e15465d6d53f362c30ce18c0fde382
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Apr 11 00:52:14 2017

ChromeOS OOBE: cr-network-list strings must be updated on UI language change.

BUG= 707487 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796343004
Cr-Commit-Position: refs/heads/master@{#462722}
(cherry picked from commit 261a0b276f6d7725877f735cc516d95182e5e360)

Review-Url: https://codereview.chromium.org/2812823002 .
Cr-Commit-Position: refs/branch-heads/3029@{#661}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/d6f96b9681e15465d6d53f362c30ce18c0fde382/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/d6f96b9681e15465d6d53f362c30ce18c0fde382/chrome/browser/resources/chromeos/login/oobe_welcome.js

Status: Verified (was: Fixed)
9334.58.2, 58.0.3029.89

Sign in to add a comment