cr-network-list should support UI language switching. |
||||||||
Issue description<cr-network-list>, which is used in ChromeOS OOBE doesn't support language switching. It seems to use whatever strings were sent from the C++ side and these are not updated after language switch. As a result, I see network connection status in incorrect language. This looks like a regression after issue 670767 .
,
Apr 3 2017
(Note, in Settings and other Chrome UI, language changes do not take effect until after a restart).
,
Apr 3 2017
,
Apr 6 2017
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/261a0b276f6d7725877f735cc516d95182e5e360 commit 261a0b276f6d7725877f735cc516d95182e5e360 Author: alemate <alemate@chromium.org> Date: Fri Apr 07 01:05:41 2017 ChromeOS OOBE: cr-network-list strings must be updated on UI language change. BUG= 707487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2796343004 Cr-Commit-Position: refs/heads/master@{#462722} [modify] https://crrev.com/261a0b276f6d7725877f735cc516d95182e5e360/chrome/browser/resources/chromeos/login/oobe_screen_network.js [modify] https://crrev.com/261a0b276f6d7725877f735cc516d95182e5e360/chrome/browser/resources/chromeos/login/oobe_welcome.js
,
Apr 7 2017
,
Apr 7 2017
Pls add appropriate OSs label.
,
Apr 8 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 10 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6f96b9681e15465d6d53f362c30ce18c0fde382 commit d6f96b9681e15465d6d53f362c30ce18c0fde382 Author: Alexander Alekseev <alemate@chromium.org> Date: Tue Apr 11 00:52:14 2017 ChromeOS OOBE: cr-network-list strings must be updated on UI language change. BUG= 707487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2796343004 Cr-Commit-Position: refs/heads/master@{#462722} (cherry picked from commit 261a0b276f6d7725877f735cc516d95182e5e360) Review-Url: https://codereview.chromium.org/2812823002 . Cr-Commit-Position: refs/branch-heads/3029@{#661} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/d6f96b9681e15465d6d53f362c30ce18c0fde382/chrome/browser/resources/chromeos/login/oobe_screen_network.js [modify] https://crrev.com/d6f96b9681e15465d6d53f362c30ce18c0fde382/chrome/browser/resources/chromeos/login/oobe_welcome.js
,
May 9 2017
9334.58.2, 58.0.3029.89 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by steve...@chromium.org
, Apr 3 2017Owner: alemate@chromium.org