New issue
Advanced search Search tips

Issue 707465 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Replace build archiving tools with GN build targets

Project Member Reported by mmoss@chromium.org, Apr 1 2017

Issue description

We have a very messy and fragile process of figuring out what to archive from our builds, involving a bunch of pieces like the FILES.cfg files in chromium/src and the archive_*.py tools in build/scripts/slave (and the related official_*.py scripts in build_internal/scripts/slave-internal). Would it be possible to replace all that with GN build targets to define/generate the archives, and basic recipes steps to handle the uploads?

This would make bot handling simpler and more robust, since the existing scripts aren't really well-integrated with recipes and thus not covered by the test infrastructure, and it would also add functionality, like allowing devs to generate and test archive files locally, which is currently difficult to do outside of the bot environment.

I haven't dealt much with these tools in a while, so it's possible I'm forgetting some compelling reason for their existence, but are there any? Are they just a legacy of a time before we had a capable enough build system?
 
Status: Available (was: Untriaged)
With GYP, at least, there was no real way to query the build system for stuff, or to export information from the build system. So, you couldn't really figure out things like "what all does this depend on". GN lets you do that.

There is still a tradeoff between having a list that is dynamically generated and a list that is statically fixed. We may want to be sure that we know when the list of stuff to bundle in an installer changes, for example, rather than accidentally picking up test data or something.
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment