New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 707448 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Apr 2018
Cc:
█ dkrahn@chromium.org
kinaba@chromium.org
xiy...@chromium.org
achuith@chromium.org
█ patricia@chromium.org
dchan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

autotest: Cut server/ => client/ dependency around sysinfo

Project Member Reported by kinaba@chromium.org, Mar 31 2017 
server/server_job.py imports client.bin.sysinfo
https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e70648162260bfd46a56fd1a1d1d7f86ec01e600/server/server_job.py#31
==>
which imports autotest_lib.client.bin.site_sysinfo
https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e70648162260bfd46a56fd1a1d1d7f86ec01e600/client/bin/sysinfo.py
==>
which is written with intention to be run on Chrome OS client, and does lots of client-specific things
https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e70648162260bfd46a56fd1a1d1d7f86ec01e600/client/bin/site_sysinfo.py

Nevertheless, since this site_sysinfo.py is indirectly imported from the server side script,
it cannot import client-only packages.
(If we do so we get CQ failure like this: https://luci-milo.appspot.com/buildbot/chromeos/kevin-paladin/664)


I think we need to put a clear barrier at some point in the above mentioned chain,
so that the server-side code and client-side code are clearly segregated.
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 2 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by hzl@chromium.org, Apr 2 2018

Status: WontFix (was: Untriaged)
Since this bug has been around for over a year, it means it is not important or it might not be relevant now. I am closing it.
►

Sign in to add a comment