New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 707444 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SVG Mask failure in SPv2

Project Member Reported by chrishtr@chromium.org, Mar 31 2017

Issue description

svg/as-background-image/svg-as-background-6.html

There is a mask on the element with id phraynx in linguistics.svg. For some
reason it isn't applying correctly in SPv2 mode.
 
Labels: BugSource-Team PaintTeamTriaged-20170331
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec6df740903bdd3482a3551ba6eca16e14a7d87

commit 2ec6df740903bdd3482a3551ba6eca16e14a7d87
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Wed Aug 02 02:29:05 2017

[SPv2] SVGPaintContext should apply mask clip if there is one

Failure to do so may result in malformed paint chunks that has chunk
clip escaping its effect's output clip.

BUG= 707444 , 737275 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6e19e774e89aea8146103f741cc1939ad354aed7
Reviewed-on: https://chromium-review.googlesource.com/596930
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491231}
[modify] https://crrev.com/2ec6df740903bdd3482a3551ba6eca16e14a7d87/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/2ec6df740903bdd3482a3551ba6eca16e14a7d87/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp

Status: Fixed (was: Assigned)
There are still some SPv2 failures pointing to this bug:

# Mask does not work correctly
 crbug.com/707444  paint/invalidation/svg/mask-clip-target-transform.svg [ Failure ]
 crbug.com/707444  paint/invalidation/svg/resource-invalidate-on-target-update.svg [ Failure ]
 crbug.com/707444  svg/W3C-SVG-1.1/masking-intro-01-f.svg [ Failure ]
 crbug.com/707444  svg/batik/masking/maskRegions.svg [ Failure ]
 crbug.com/707444  svg/custom/clamped-masking-clipping.svg [ Failure ]
 crbug.com/707444  svg/custom/clip-mask-negative-scale.svg [ Failure ]
 crbug.com/707444  svg/custom/mask-inside-defs.svg [ Failure ]

Should we reopen this bug for these failures or file a new bug?
Cc: pdr@chromium.org wangxianzhu@chromium.org

Sign in to add a comment